Red Hat Bugzilla – Bug 211317
Review Request: perl-Cache-Mmap - Shared data cache using memory mapped files
Last modified: 2007-11-30 17:11:46 EST
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Cache-Mmap/perl-Cache-Mmap.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Cache-Mmap-0.09-1.src.rpm
This module implements a shared data cache, using memory mapped files. If
routines are provided which interact with the underlying data, access to
the cache is completely transparent, and the module handles all the details
of refreshing cache contents, and updating underlying data, if necessary.
* rpmlint error:
E: perl-Cache-Mmap wrong-script-interpreter
This is indeed true, and maybe a simple sed line could correct
the shebang in cmmtest. I won't make it a blocker.
* free software, licence not included
* follow guidelines
* spec legible
* match upstream
* sane provides (Mmap.so is wrong, but it's usual)
Provides: Mmap.so perl(Cache::Mmap)
* %files section right
First, thank you for the quick review.
(In reply to comment #1)
> * rpmlint error:
> E: perl-Cache-Mmap wrong-script-interpreter
> /usr/share/doc/perl-Cache-Mmap-0.09/cmmtest "/usr/local/bin/perl-journals"
> This is indeed true, and maybe a simple sed line could correct
> the shebang in cmmtest.
I didn't think it was significant, since it is a %doc file. (And note that I
chmod a-x the thing in %prep, so there's no danger of mistaking it for a real
script, and it isn't causing any new dependencies.)
In other words, I'd prefer to leave it as-is. Besides, I have to assume
upstream had some reason for it...
(In reply to comment #2)
> I didn't think it was significant, since it is a %doc file. (And note that I
> chmod a-x the thing in %prep, so there's no danger of mistaking it for a real
> script, and it isn't causing any new dependencies.)
Indeed, and that's why I don't make it a blocker.
> In other words, I'd prefer to leave it as-is. Besides, I have to assume
> upstream had some reason for it...
Some reason we don't care about. In fedora it would be better in my
opinion if a user wouldn't have to guess why the shebang is like that
and whether he has to install something else to have the package work.
This example is meant to be read, so it should be as correct as possible.
Imported, built, etc.