SRPM URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli-0.004001-3.fc37.src.rpm Spec URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli.spec Description: This package provides bindings for brotli compression to perl. Source is taken from the cpan package IO::Compress::Brotli Fedora Account System Username: psalaba
FYI: New version of perl-HTTP-Message added support for brotli compression via this module. I am for adding to Fedora as perl-HTTP-Message maintainer.
Source files are ok TODO: perl-IO-Compress-Brotli.rpmlintrc can be removed. It isn't necessary to add it into rpm. Just add it to git repository. URL and Source0 are ok Summary FIX: Update the text of summary "Read and write Brotli buffers/streams" FIX: Remove 'Group' tag. 'Group' should not be used. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections License is ok Description is ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-IO-Compress-Brotli-0.004001-3.fc37.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libbrotlidec.so.1()(64bit) 1 libbrotlienc.so.1()(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.36()(64bit) 1 perl(bytes) 1 perl(Exporter) 1 perl(File::Slurper) 1 perl(Getopt::Long) 1 perl(IO::Compress::Brotli) 1 perl(IO::Uncompress::Brotli) 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(parent) 1 perl(strict) 1 perl(Time::HiRes) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) 1 /usr/bin/perl Binary requires are Ok. $ rpm -qp --provides perl-IO-Compress-Brotli-0.004001-3.fc37.x86_64.rpm | sort | uniq -c 1 perl(IO::Compress::Brotli) = 0.004001 1 perl-IO-Compress-Brotli = 0.004001-3.fc37 1 perl-IO-Compress-Brotli(x86-64) = 0.004001-3.fc37 1 perl(IO::Uncompress::Brotli) = 0.004001 Binary provides are Ok. $ rpmlint -r perl-IO-Compress-Brotli.rpmlintrc ./perl-IO-Compress-Brotli* ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('perl-IO-Compress-Brotli.rpmlintrc')] checks: 32, packages: 4 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint is ok FIX: Remove %defattr from %files section - it is needed only for EPEL =< 6 TODO: I think 'META.json' could be removed from %doc. It does not contain any useful information. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: Not Approved
(In reply to Jitka Plesnikova from comment #2) > -snip- I've done the things you suggested, new files are here: SRPM URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli-0.004001-4.fc37.src.rpm Spec URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli.spec rpmlintrc URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli.rpmlintrc
(In reply to Jitka Plesnikova from comment #2) > Source files are ok > TODO: perl-IO-Compress-Brotli.rpmlintrc can be removed. It isn't necessary > to add it into rpm. Just add it to git repository. Source0: https://cpan.metacpan.org/authors/id/M/MG/MGV/IO-Compress-Brotli-%{version}.tar.gz -Source1: perl-IO-Compress-Brotli.rpmlintrc Ok > FIX: Update the text of summary "Read and write Brotli buffers/streams" -Summary: Write Brotli buffers/streams +Summary: Brotli compression library for perl Ok. > FIX: Remove 'Group' tag. 'Group' should not be used. -Group: Development/Libraries Ok. > FIX: Remove %defattr from %files section - it is needed only for EPEL =< 6 > TODO: I think 'META.json' could be removed from %doc. It does not contain > any useful information. -%defattr(-,root,root,-) -%doc Changes META.json README +%doc Changes README Ok. FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages (perl-IO-Compress-Brotli.spec:5). Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct the last 'FIX' item and provide a new spec file. Resolution: Not Approved
(In reply to Jitka Plesnikova from comment #4) > FIX: We have new licensing guidelines. Please write a license tag value in > SPDX syntax > https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages > (perl-IO-Compress-Brotli.spec:5). > > Otherwise the package is in line with Fedora and Perl packaging guide lines. > Please correct the last 'FIX' item and provide a new spec file. Understood, I've changed the license to 'GPL-1.0-or-later OR Artistic-1.0-Perl' SRPM URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli-0.004001-5.fc37.src.rpm Spec URL: https://rpm.urumasi.xyz/perl-IO-Compress-Brotli/perl-IO-Compress-Brotli.spec
(In reply to Jitka Plesnikova from comment #4) > FIX: We have new licensing guidelines. Please write a license tag value in > SPDX syntax > https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages > (perl-IO-Compress-Brotli.spec:5). -License: GPL+ or Artistic +License: GPL-1.0-or-later OR Artistic-1.0-Perl Ok. The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-IO-Compress-Brotli