Bug 2114642 - vim-ale requires vim-enhanced
Summary: vim-ale requires vim-enhanced
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: vim-ale
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pavel Raiskup
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-03 02:44 UTC by Peter Simonyi
Modified: 2022-09-16 01:46 UTC (History)
3 users (show)

Fixed In Version: vim-ale-3.1.0-5.fc38 vim-ale-3.1.0-5.fc37 vim-ale-3.1.0-5.fc36 vim-ale-3.1.0-5.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-07 12:33:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Peter Simonyi 2022-08-03 02:44:54 UTC
Description of problem:
vim-ale requires vim-enhanced, but it should not because it can work with any Vim package, such as GVim or vimx from vim-X11.

I have vim-X11 installed (with alias vim=vimx)

Version-Release number of selected component (if applicable):
vim-ale-3.1.0-3.fc36
vim-enhanced-2:9.0.077-1.fc36

How reproducible:
Always

Steps to Reproduce:
1. Make sure vim-enhanced is not installed, but vim-X11 is.
2. dnf install vim-ale

Actual results:
DNF installs vim-enhanced as a required dependency.

Expected results:
vim-X11 (GVim and vimx) should be enough.

Additional info:
It seems vim-X11 provides 'gvim' but not 'vim'; maybe this is a problem with the vim-X11 package instead?

Comment 1 Pavel Raiskup 2022-08-03 04:50:08 UTC
> maybe this is a problem with the vim-X11 package instead?

Adding vim maintainer to CC.  Zdeňku, what is the expected way to depend
on vim-X11 OR vim-enhanced (== vim?)?

I think I'll add 'Requires: vim or gvim', but I'd like to know if this is
the recommended way to specify dependencies for vim packages.

Comment 2 Zdenek Dohnal 2022-09-07 08:55:13 UTC
Hi Pavel,

AFAIK there is not one specific recommended way of requiring Vim and I don't prefer one way over the other too much myself, so you can choose from the provides vim-X11 and vim-enhanced have (in case you don't want to depend on package name):

'vim' or '/usr/bin/vim' for vim-enhanced

'gvim' or '/usr/bin/gvim' for vim-X11

Only by guts I would go for the solution you've chosen, but all three are fine.


I'm sorry for not answering sooner and I hope it helps.

Comment 3 Fedora Update System 2022-09-07 12:30:51 UTC
FEDORA-2022-1af076f59b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1af076f59b

Comment 4 Fedora Update System 2022-09-07 12:33:00 UTC
FEDORA-2022-1af076f59b has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2022-09-07 12:35:40 UTC
FEDORA-2022-67193f4e7f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-67193f4e7f

Comment 6 Fedora Update System 2022-09-07 12:35:42 UTC
FEDORA-2022-16fc4ee6d6 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-16fc4ee6d6

Comment 7 Fedora Update System 2022-09-07 12:35:43 UTC
FEDORA-2022-6bb22821b9 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6bb22821b9

Comment 8 Pavel Raiskup 2022-09-07 12:38:07 UTC
Thank you for the report @Peter, and thanks for the update @zdohnal.

I went with this fix eventually:
https://src.fedoraproject.org/rpms/vim-ale/c/82ecf296f12009e91e4019eb34bdae022cbf12eb?branch=rawhide

I wish we had some guidelines related to vim-* plugin packaging in the future :-)

Comment 9 Fedora Update System 2022-09-08 09:32:46 UTC
FEDORA-2022-67193f4e7f has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-67193f4e7f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-67193f4e7f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-09-08 11:25:39 UTC
FEDORA-2022-16fc4ee6d6 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-16fc4ee6d6`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-16fc4ee6d6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-09-08 12:09:05 UTC
FEDORA-2022-6bb22821b9 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-6bb22821b9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6bb22821b9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Peter Simonyi 2022-09-13 16:39:12 UTC
Thank you for figuring this out!

Comment 13 Vít Ondruch 2022-09-14 12:49:29 UTC
I have used vim-common on various places (vim-nerdtree, vim-command-t). Nobody have complained yet.

Comment 14 Pavel Raiskup 2022-09-14 13:13:13 UTC
Yeah it seems to be the way this is typically done, but it doesn't seem to
be correct to me.  The `vim-common` doesn't provide a working environment
to operate the plugin (Requires: == runtime deps).

Comment 15 Vít Ondruch 2022-09-14 14:01:40 UTC
(In reply to Pavel Raiskup from comment #14)
> Yeah it seems to be the way this is typically done, but it doesn't seem to
> be correct to me.  The `vim-common` doesn't provide a working environment
> to operate the plugin (Requires: == runtime deps).

Does it need to? But the true is that vim is probably not part of the base installation anymore, as it used to be. But of course, every vim version could have some virtual provide, such as `vim(runtime_executable)` which the plugins could refer to.

Comment 16 Zdenek Dohnal 2022-09-15 12:55:26 UTC
(In reply to Vít Ondruch from comment #15)
> But of course, every vim version
> could have some virtual provide, such as `vim(runtime_executable)` which the
> plugins could refer to.

Hi Vita,

I've added 'Provides: vim(plugins-supported)' to vim-enhanced and vim-X11 - now I'm going to test it whether it causes some problems. If not, you can use it in packaged Vim plugins.

Comment 17 Fedora Update System 2022-09-16 00:16:06 UTC
FEDORA-2022-67193f4e7f has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2022-09-16 01:39:47 UTC
FEDORA-2022-6bb22821b9 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2022-09-16 01:46:23 UTC
FEDORA-2022-16fc4ee6d6 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.