Bug 2114685 - Review Request: git-credential-manager - Secure git credential helper with multi-factor authentication support
Summary: Review Request: git-credential-manager - Secure git credential helper with mu...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2022-08-03 06:15 UTC by M Hickford
Modified: 2024-04-01 00:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-04-01 00:45:26 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description M Hickford 2022-08-03 06:15:26 UTC
Spec URL: https://github.com/hickford/git-credential-manager/blob/rpm/git-credential-manager.spec
SRPM URL: https://copr.fedorainfracloud.org/coprs/matthickford/git-credential-manager/
Description: Git Credential Manager (GCM) is a secure Git credential helper built on .NET. GCM provides multi-factor authentication support for Azure DevOps, Azure DevOps Server, GitHub, Bitbucket, and GitLab.
Fedora Account System Username: matthickford

NB. The application is developed in .NET. I checked the Fedora packaging guidelines but couldn't find any special advice https://docs.fedoraproject.org/en-US/packaging-guidelines/

https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_New_Contributors/
https://fedoraproject.org/wiki/SIGs/DotNet

Comment 1 M Hickford 2022-08-03 06:27:22 UTC
An issue -- the rpm requires internet access to build, at least for the `dotnet restore` step. Advice welcome how to fix.

> Packages in the Fedora buildsystem are built in a mock chroot with no access to the internet.

Comment 2 Salman Butt 2022-08-04 03:30:09 UTC
UNOFFICIAL REVIEW / RECOMMENDATION
----------------------------

Please see https://blog.bigfont.ca/dotnet-restore-without-an-internet-connection/
for information on building without a network connection


Spec File Additions: (VERSION = needs to be replaced with number)

# Macro defs for dotnet builds
%global __dotnet_publish_dest %{_builddir}/__publish
%define __dotnet_build() \
	/usr/bin/dotnet restore --source %{1} \
	/usr/bin/dotnet publish --no-restore -o %{__dotnet_publish_dest}


BuildRequires: dotnet-sdk-VERSION
BuildRequires: systemd
Requires: dotnet-runtime-VERSION
Requires: aspnetcore-runtime-VERSION


%build
#dotnet restore --source .nuget/packages
#dotnet publish --no-restore 
%__dotnet_build .nuget/packages

Comment 3 Michael Cronenworth 2023-03-02 22:30:09 UTC
Hi, I packaged Jellyfin and have an "offline" script I run to pull down, tarball up, and include as part of the source package. You can follow that as a model to use in your package.

https://pkgs.rpmfusion.org/cgit/free/jellyfin.git/tree

Comment 4 Package Review 2024-03-02 00:45:23 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 5 Package Review 2024-04-01 00:45:26 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.