Bug 2115417 - Review Request: rapidyaml - A library to parse and emit YAML, and do it fast
Summary: Review Request: rapidyaml - A library to parse and emit YAML, and do it fast
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pat Riehecky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2034748
TreeView+ depends on / blocked
 
Reported: 2022-08-04 15:53 UTC by Ben Beasley
Modified: 2022-09-17 02:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-08-31 13:24:39 UTC
Type: ---
Embargoed:
riehecky: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2022-08-04 15:53:44 UTC
Spec URL: https://music.fedorapeople.org/rapidyaml.spec
SRPM URL: https://music.fedorapeople.org/rapidyaml-0.4.1-1.fc36.src.rpm
Description:

Rapid YAML, or ryml, for short. ryml is a C++ library to parse and emit YAML,
and do it fast, on everything from x64 to bare-metal chips without operating
system. (If you are looking to use your programs with a YAML tree as a
configuration tree with override facilities, take a look at c4conf).

Fedora Account System Username: music

I’ve been laying the groundwork for some time to make this package possible, by packaging the c4* support libraries and working with upstream to resolve various issues.

Upstream uses a home-grown CMake framework of rather significant complexity, and it wants to download dependencies at build time. Some downstream hacking on the CMake files is required in order to replace all downloaded-and-bundled dependencies with properly-unbundled ones. I hope to work with upstream further to simplify this. However, the approach here should be adequate for the time being, and I think this is a rather clean package considering those circumstances.

Koji scratch build:
F37/Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=90469409

Comment 1 Pat Riehecky 2022-08-25 16:51:37 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License", "*No copyright* [generated file]". 169 files have unknown
     license. Detailed output of licensecheck in
     /tmp/bar/2115417-rapidyaml/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 102400 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-rapidyaml
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 5

rapidyaml-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/rapidyaml-0.4.1-1.fc38.x86_64
rapidyaml-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libryml.so.0.4.1-0.4.1-1.fc38.x86_64.debug
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_ValueError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_IndexError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_SyntaxError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so _Py_NoneStruct	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_AttributeError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_IOError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_MemoryError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyType_Type	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyCFunction_Type	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_OverflowError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_ZeroDivisionError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_RuntimeError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so _Py_NotImplementedStruct	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_TypeError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_GenericGetAttr	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyExc_SystemError	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyTuple_SetItem	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_GetBuffer	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyLong_AsLong	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_GetAttr	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyImport_AddModule	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_Call	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyInstanceMethod_New	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_GetAttrString	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyErr_Restore	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyType_IsSubtype	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyModule_GetDict	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyDict_SetItem	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyModule_AddObject	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_CheckBuffer	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyUnicode_InternFromString	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyTuple_New	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_SetAttr	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_IsInstance	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyDict_SetItemString	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyUnicode_FromFormat	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyList_Append	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so _PyObject_New	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyBuffer_Release	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyErr_Format	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyUnicode_DecodeUTF8	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so _Py_Dealloc	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyList_New	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyUnicode_FromString	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyErr_Clear	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyDict_GetItem	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so Py_DecRef	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyCapsule_Import	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyLong_FromVoidPtr	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyDict_New	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyErr_SetString	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyCapsule_New	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyCapsule_GetPointer	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_Free	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyType_Ready	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyLong_FromLong	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyErr_WriteUnraisable	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_IsTrue	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyModule_Create2	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyLong_AsUnsignedLong	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyErr_Occurred	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyErr_Fetch	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyList_SetItem	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyObject_CallFunctionObjArgs	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyLong_FromUnsignedLong	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyArg_UnpackTuple	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyUnicode_AsUTF8AndSize	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyCMethod_New	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyUnicode_Concat	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyMemoryView_FromMemory	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyErr_GivenExceptionMatches	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyUnicode_AsUTF8String	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyBytes_AsStringAndSize	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
python3-rapidyaml.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/ryml/_ryml.so PyBool_FromLong	(/usr/lib64/python3.11/site-packages/ryml/_ryml.so)
rapidyaml-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/rapidyaml-0.4.1-1.fc38.x86_64
rapidyaml-devel.x86_64: W: no-documentation
rapidyaml-debugsource.x86_64: W: no-documentation
rapidyaml-debuginfo.x86_64: W: no-documentation
rapidyaml-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/rapidyaml-0.4.1-1.fc38.x86_64
rapidyaml-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib64/libryml.so.0.4.1-0.4.1-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib64/libryml.so.0.4.1-0.4.1-1.fc38.x86_64.debug'

rapidyaml-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
rapidyaml-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
rapidyaml-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/2c/cd1f373304bb9ec0feca85f56311625dcea9a9 ../../../.build-id/2c/cd1f373304bb9ec0feca85f56311625dcea9a9
 5 packages and 0 specfiles checked; 3 errors, 82 warnings, 3 badness; has taken 0.3 s 



Unversioned so-files
--------------------
python3-rapidyaml: /usr/lib64/python3.11/site-packages/ryml/_ryml.so

Source checksums
----------------
https://github.com/yaml/yaml-test-suite/archive/data-2022-01-17/yaml-test-suite-data-2022-01-17.tar.gz :
  CHECKSUM(SHA256) this package     : ccae49c1d010d27c20d315969a97752f95b14642fc1e73755db4eb2df4bb0256
  CHECKSUM(SHA256) upstream package : ccae49c1d010d27c20d315969a97752f95b14642fc1e73755db4eb2df4bb0256
https://github.com/biojppm/rapidyaml/archive/v0.4.1/rapidyaml-0.4.1.tar.gz :
  CHECKSUM(SHA256) this package     : b4ef0300b5899ede26ed529d8a8daa3347810693957707dbe522f69b17250ae2
  CHECKSUM(SHA256) upstream package : b4ef0300b5899ede26ed529d8a8daa3347810693957707dbe522f69b17250ae2


Requires
--------
rapidyaml (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libc4core.so.0.1.9()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

rapidyaml-devel (rpmlib, GLIBC filtered):
    c4core-devel(x86-64)
    cmake-filesystem(x86-64)
    libryml.so.0.4.1()(64bit)
    rapidyaml(x86-64)

python3-rapidyaml (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libc4core.so.0.1.9()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    python(abi)
    rtld(GNU_HASH)

rapidyaml-debuginfo (rpmlib, GLIBC filtered):

rapidyaml-debugsource (rpmlib, GLIBC filtered):



Provides
--------
rapidyaml:
    libryml.so.0.4.1()(64bit)
    rapidyaml
    rapidyaml(x86-64)

rapidyaml-devel:
    cmake(ryml)
    rapidyaml-devel
    rapidyaml-devel(x86-64)

python3-rapidyaml:
    python-rapidyaml
    python3-rapidyaml
    python3-rapidyaml(x86-64)
    python3.11-rapidyaml
    python3.11dist(rapidyaml)
    python3dist(rapidyaml)

rapidyaml-debuginfo:
    debuginfo(build-id)
    libryml.so.0.4.1-0.4.1-1.fc38.x86_64.debug()(64bit)
    rapidyaml-debuginfo
    rapidyaml-debuginfo(x86-64)

rapidyaml-debugsource:
    rapidyaml-debugsource
    rapidyaml-debugsource(x86-64)



Diff spec file in url and in SRPM
---------------------------------
--- /tmp/bar/2115417-rapidyaml/srpm/rapidyaml.spec	2022-08-25 10:59:06.330350238 -0500
+++ /tmp/bar/2115417-rapidyaml/srpm-unpacked/rapidyaml.spec	2022-05-14 06:26:47.000000000 -0500
@@ -99,5 +99,5 @@
 sed -r -i '/INCORPORATE c4core/d' 'CMakeLists.txt'
 
-# Patch out download of c4fs:
+# Patch out downlaod of c4fs:
 '%{SOURCE10}' 'ext/testbm.cmake' 'c4_require_subproject\(c4fs' '\)$'
 
@@ -185,7 +185,4 @@
 # Fix wrong installation paths for multilib; it would be nontrivial to patch
 # the source to get this right in the first place.
-#
-# Installation directory on Linux 64bit OS
-# https://github.com/biojppm/rapidyaml/issues/256
 if [ '%{_libdir}' != '%{_prefix}/lib' ]
 then


Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2115417
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Python, Generic, Shell-api
Disabled plugins: R, Ocaml, PHP, SugarActivity, Haskell, fonts, Java, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
---------------------------------------------------------------------------

Comment 2 Pat Riehecky 2022-08-25 16:52:18 UTC
Did you want to address any of the warnings?

Comment 3 Ben Beasley 2022-08-25 17:41:02 UTC
(In reply to Pat Riehecky from comment #2)
> Did you want to address any of the warnings?

Yes, I’ll take a look at them. A plethora of warnings from debug packages are normal, but warnings in python3-rapidyaml are not expected.

Comment 4 Ben Beasley 2022-08-27 12:30:41 UTC
Using rpmlint 2.2.0 on Fedora 36, I was unable to reproduce those warnings. I tried fedora-review -b 2115417. As usual, review.txt contained “Cannot parse rpmlint output,” but running

rpmlint 2115417-rapidyaml/results/{python3-rapidyaml-0.4.1-1.fc38.x86_64.rpm,rapidyaml-0.4.1-1.fc38.src.rpm,rapidyaml-0.4.1-1.fc38.x86_64.rpm,rapidyaml-devel-0.4.1-1.fc38.x86_64.rpm}

gave me the following:

=============================================== rpmlint session starts ===============================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

rapidyaml.src: W: strange-permission patch-no-download 775
rapidyaml-devel.x86_64: W: no-documentation
================ 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.7 s ================

The warnings you are getting look to me a lot like https://github.com/rpm-software-management/rpmlint/issues/864, which makes me think they are not a real problem.

Comment 5 Ben Beasley 2022-08-27 12:31:16 UTC
Repository requested: https://pagure.io/releng/fedora-scm-requests/issue/46915

Comment 6 Jens Petersen 2022-08-28 05:43:33 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rapidyaml

Comment 7 Fedora Update System 2022-08-31 13:21:51 UTC
FEDORA-2022-54e85e37bf has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-54e85e37bf

Comment 8 Fedora Update System 2022-08-31 13:24:39 UTC
FEDORA-2022-54e85e37bf has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2022-08-31 20:59:50 UTC
FEDORA-2022-e82c2ab9e4 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e82c2ab9e4

Comment 10 Fedora Update System 2022-08-31 21:35:11 UTC
FEDORA-2022-99a0bd13be has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-99a0bd13be

Comment 11 Fedora Update System 2022-09-01 07:48:28 UTC
FEDORA-2022-e82c2ab9e4 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-e82c2ab9e4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-e82c2ab9e4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-09-01 10:29:57 UTC
FEDORA-2022-99a0bd13be has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-99a0bd13be \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-99a0bd13be

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-09-01 11:56:25 UTC
FEDORA-EPEL-2022-e4920a3a73 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-e4920a3a73

Comment 14 Fedora Update System 2022-09-02 10:22:17 UTC
FEDORA-EPEL-2022-e4920a3a73 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-e4920a3a73

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-09-08 11:38:49 UTC
FEDORA-EPEL-2022-4a61198054 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-4a61198054

Comment 16 Fedora Update System 2022-09-09 11:22:08 UTC
FEDORA-2022-99a0bd13be has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2022-09-09 12:11:51 UTC
FEDORA-EPEL-2022-4a61198054 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-4a61198054

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2022-09-10 20:06:27 UTC
FEDORA-EPEL-2022-e4920a3a73 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2022-09-12 17:43:57 UTC
FEDORA-2022-e82c2ab9e4 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 20 Fedora Update System 2022-09-17 02:32:55 UTC
FEDORA-EPEL-2022-4a61198054 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.