Bug 2115886
| Summary: | fix IPRouteUtils.get_route_tables_mapping() to accept any whitespace sequence | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Wen Liang <wenliang> |
| Component: | rhel-system-roles | Assignee: | Rich Megginson <rmeggins> |
| Status: | CLOSED ERRATA | QA Contact: | Zhiqian Guan <zhguan> |
| Severity: | unspecified | Docs Contact: | Mayur Patil <maypatil> |
| Priority: | unspecified | ||
| Version: | 9.1 | CC: | jtrossba, maypatil, nhosoi, rhel-cs-system-management-subsystem-qe, rmeggins, spetrosi, thaller, zhguan |
| Target Milestone: | rc | Keywords: | Triaged |
| Target Release: | 9.1 | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | role:network | ||
| Fixed In Version: | rhel-system-roles-1.20.0-1.el9 | Doc Type: | Bug Fix |
| Doc Text: |
.The `IPRouteUtils.get_route_tables_mapping()` function now accepts any whitespace sequence
Previously, a parser for the `iproute2` routing table database, such as `/etc/iproute2/rt_tables`, asserted that entries in the file were of the form `254 main` and only a single space character separated the numeric id and the name. Consequently, the parser failed to cache all the mappings between the route table name and table id.Therefore the user could not add a static route into the route table by defining the route table name. With this update, the parser accepts any whitespace sequence in between the table ID and table name. As a result, as the parser caches all the mapping between the route table name and table ID, users can add a static route into the route table by defining the route table name.
|
Story Points: | --- |
| Clone Of: | 2115884 | Environment: | |
| Last Closed: | 2022-11-15 10:24:25 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2115884 | ||
| Bug Blocks: | |||
|
Description
Wen Liang
2022-08-05 15:32:07 UTC
*** Bug 2115887 has been marked as a duplicate of this bug. *** What playbooks need to be run to verify this is working properly? Has the CI run these tests already does anyone know where those results are? (In reply to Jon Trossbach from comment #9) > What playbooks need to be run to verify this is working properly? Has the CI > run these tests already does anyone know where those results are? Good questions for Thomas from whom I have requested the info. Test was added in PR - https://github.com/linux-system-roles/network/pull/508/files#diff-b06f1e1bf991f123e64cf9dde6dcf9574bb279a720609a570e8af27cc2d9a359 Test coverage is in tests_unit.yml [root@netqe3 Upstream-testsuite]# uname -r 5.14.0-145.el9.x86_64 rhel-system-roles-1.20.0-1.el9.noarch ansible-core-2.13.2-1.el9 :: [ 04:50:25 ] :: [ BEGIN ] :: Test tests_unit.yml with ANSIBLE-2.13 against RHEL_7_9_GA :: [ 04:51:00 ] :: [ PASS ] :: Test tests_unit.yml (Assert: expected 0, got 0) :: [ 04:53:21 ] :: [ BEGIN ] :: Test tests_unit.yml with ANSIBLE-2.13 against RHEL_8_6_0_GA :: [ 04:54:12 ] :: [ PASS ] :: Test tests_unit.yml (Assert: expected 0, got 0) :: [ 04:55:40 ] :: [ BEGIN ] :: Test tests_unit.yml with ANSIBLE-2.13 against RHEL_9_0_0_GA :: [ 04:56:14 ] :: [ PASS ] :: Test tests_unit.yml (Assert: expected 0, got 0) :: [ 05:00:12 ] :: [ BEGIN ] :: Test tests_unit.yml with ANSIBLE-2.13 against RHEL_8_7_TESTING :: [ 05:01:06 ] :: [ PASS ] :: Test tests_unit.yml (Assert: expected 0, got 0) :: [ 05:02:54 ] :: [ BEGIN ] :: Test tests_unit.yml with ANSIBLE-2.13 against RHEL_9_1_TESTING :: [ 05:03:31 ] :: [ PASS ] :: Test tests_unit.yml (Assert: expected 0, got 0) (In reply to Jon Trossbach from comment #9) > What playbooks need to be run to verify this is working properly? Has the CI > run these tests already does anyone know where those results are? the fix is covered by upstream unit tests. I think there are no playbooks that test this. But this issue is well suited for smaller unit tests, so I think we have this sufficiently covered. You are welcome to perform additional tests if you doubt it. You can test it (manually or with a playbook CI test) by creating a "/etc/iproute2/rt_tables" with certain entries. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2022:8117 |