Bug 2116596 - Review Request: rust-bit_field - Simple bit field trait providing get_bit, get_bits, set_bit, and set_bits methods for Rust's integral types
Summary: Review Request: rust-bit_field - Simple bit field trait providing get_bit, ge...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-09 02:15 UTC by Orion Poplawski
Modified: 2022-08-14 22:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-08-14 22:33:37 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Orion Poplawski 2022-08-09 02:15:15 UTC
Spec URL: https://orion.fedorapeople.org/rust-bit_field.spec
SRPM URL: https://orion.fedorapeople.org/rust-bit_field-0.10.1-1.fc37.src.rpm
Description:
Simple bit field trait providing get_bit, get_bits, set_bit, and set_bits methods for Rust's integral types.

Fedora Account System Username: orion

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90632289

Comment 1 Fabio Valentini 2022-08-11 16:13:31 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

FYI: Don't use "fedpkg import" on the current SRPM file. It will result in broken packages (i.e. double-processing by rpmautospec).
Use the pristine .spec file instead.

Please also trim the "Summary" value in the spec file. It's way too long right now.

Comment 2 Kevin Fenzi 2022-08-14 17:19:30 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bit_field

Comment 3 Orion Poplawski 2022-08-14 22:33:37 UTC
Checked in and built.  Thanks all.


Note You need to log in before you can comment on or make changes to this bug.