Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://orion.fedorapeople.org/rust-inflate.spec SRPM URL: https://orion.fedorapeople.org/rust-inflate-0.4.5-1.fc37.src.rpm Description: DEFLATE decoding. Fedora Account System Username: orion Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90632404
We already had this package, so you'll have to go through the un-retirement process: https://src.fedoraproject.org/rpms/rust-inflate It would be great if you could ensure that the NEVR of the re-imported package will be higher than the one that's still in F36 (0.4.5-8.fc36). You should be able to do this by adding "-b 8" to the %autorelease macro. Other than that, the package looks good (even though the code is pretty crufty and outdated, it's also over three years since the last release). === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
BTW: Don't import the SRPM file you uploaded for this review with "fedpkg import". It was already mangled by rpmautospec, and if you import it, the resulting package will be broken. Just FYI.
The -b option was not needed - the repo still has all of the old commits so still counts from the initial commit. Thanks for the review.