Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://orion.fedorapeople.org/rust-lebe.spec SRPM URL: https://orion.fedorapeople.org/rust-lebe-0.5.1-1.fc37.src.rpm Description: Tiny, dead simple, high performance endianness conversions with a generic API. Fedora Account System Username: orion Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90632511
There's a big red "FIXME" instead of the License tag. The project doesn't specify its license in the standard place in Cargo.toml metadata (package.license), but uses a custom license, and I don't even recognize it (though askalono claims it's BSD-3-Clause). I wonder why the upstream project doesn't just specify "license = BSD-3-Clause" in the metadata, but instead uses "license-file = LICENSE.md", which is intended for non-standard licenses.
I've fixed the license and reported the issue upstream.
Thanks for fixing the issue upstream! 🎉 Looks like you still need to replace %license %{crate_instdir}/LICENSE.md with %{crate_instdir}/LICENSE-BSD-3-Clause in %files of the devel subpackage? And the linked SRPM file doesn't reflect the latest changes yet. Other than those two issues, package looks good to me now.
Upstream did a release: Spec URL: https://orion.fedorapeople.org/rust-lebe.spec SRPM URL: https://orion.fedorapeople.org/rust-lebe-0.5.2-1.fc38.src.rpm
Awesome, thanks! Package looks good to me now. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (BSD-3-Clause) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lebe
Built. Thanks all.