Spec URL: http://math.ifi.unizh.ch/fedora/spec/nyquist.spec SRPM URL: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/nyquist-2.31-2.src.rpm Description: Nyquist is a language for sound synthesis and music composition. Unlike score languages that tend to deal only with events, or signal processing languages that tend to deal only with signals and synthesis, Nyquist handles both in a single integrated system. Nyquist is also flexible and easy to use because it is based on an interactive Lisp interpreter.
I will review this later.
Well, I quite don't know how to use this, however there seems nothing to be fixed (I will recheck). ------------------------------------------------------------------------- Just a interest. In the build log, I see: portaudio/pa_linux_alsa/pa_linux_alsa.c: In function 'Wait': portaudio/pa_linux_alsa/pa_linux_alsa.c:2251: warning: comparisons like X<=Y<=Z do not have their mathematical meaning And portaudio/pa_linux_alsa/pa_linux_alsa.c says: 2249 } 2250 2251 assert( !(captureAvail == playbackAvail == INT_MAX) ); 2252 2253 commonAvail = MIN( captureAvail, playbackAvail ); 2254 commonAvail -= commonAvail % stream->frames_per_period; Perhaps the line 2251 is a bug.
ping?
Hmm, this is strange. It does not make much sense. Probably it should be !(captureAvail == INT_MAX && playbackAvail == INT_MAX)
Ping? (In reply to comment #4) > Hmm, this is strange. It does not make much sense. Probably it should be > !(captureAvail == INT_MAX && playbackAvail == INT_MAX) I have not yet looked into this package, however would you upload new srpm and spec with this source fixed?
Here is the package which includes the fix (spec at the same place): http://math.ifi.unizh.ch/fedora/6/i386/SRPMS.gemi/nyquist-2.31-3.src.rpm
Oops, it should be: http://math.ifi.unizh.ch/fedora/6/i386/SRPMS.gemi/nyquist-2.31-3.fc6.src.rpm
Okay, this package meets the demand by http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines ------------------------------------------------------------------------------- This package (nyquist) is APPROVED by me.
Built on FC5, FC6 and FC7. Added entries to owners and comps files. Thanks for the review.