Bug 2117209 - libvirt-daemon can requires gettext-runtime
Summary: libvirt-daemon can requires gettext-runtime
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: RejectedFreezeException
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-10 10:34 UTC by Jens Petersen
Modified: 2022-11-10 22:31 UTC (History)
12 users (show)

Fixed In Version: libvirt-8.7.0-2.fc38 libvirt-8.6.0-4.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-10 22:31:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jens Petersen 2022-08-10 10:34:09 UTC
Description of problem:
In F37 we are subpackaging the gettext runtime tools in gettext-runtime.
This should allow normal users not to have to install the full gettext package
by default. libvirt-daemon currently Requires: gettext.  Assuming it does not
need the gettext translation management/development tools (like msgcat and
xgettext) at runtime, it can "Requires: gettext-runtime" instead.
This will help reduce the size of the Fedora Live image(s) etc.

https://fedoraproject.org/wiki/Changes/GettextRuntimeSubpackage

Additional info:
We can open a PR to make the spec file change if it helps.

Comment 1 Jens Petersen 2022-08-25 08:04:01 UTC
PR is https://src.fedoraproject.org/rpms/libvirt/pull-request/13, thanks

Comment 2 Jens Petersen 2022-09-07 01:32:09 UTC
If there are no objections, I will go ahead and merge this by the end of this week.

Then at the very least rawhide Live images will no longer pull in the gettext base package.

Comment 3 Cole Robinson 2022-09-07 15:31:38 UTC
ACK, looks correct to me. The specific dep is /usr/libexec/libvirt-guests.sh which is using /usr/bin/gettext.sh, which is in gettext-runtime on f37.

After you merge in Fedora, I'll forward the patch upstream

Comment 4 Jens Petersen 2022-09-09 09:59:00 UTC
Thanks, Cole

I went ahead merged it now with a changelog and bump.
Shall I go ahead and build it for rawhide?

Comment 5 Jens Petersen 2022-09-23 06:24:51 UTC
Rawhide looks good now (at least gettext no longer gets pulled into Workstation).

BTW do you plan to backport/merge libvirt-8.7.0 to F37 later or maybe should I open another PR for this for F37/libvirt-8.6?

Comment 6 Cole Robinson 2022-10-12 14:16:47 UTC
(In reply to Jens Petersen from comment #5)
> BTW do you plan to backport/merge libvirt-8.7.0 to F37 later or maybe should
> I open another PR for this for F37/libvirt-8.6?

Please open a PR for that, thanks. We won't be rebasing libvirt in f37 at this point

FYI the spec patch is in upstream libvirt.git now too.

Comment 7 Jens Petersen 2022-10-17 06:17:44 UTC
Sure thing

I opened https://src.fedoraproject.org/rpms/libvirt/pull-request/14 - thanks

Comment 8 Fedora Update System 2022-11-02 13:49:30 UTC
FEDORA-2022-dad54c6e53 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-dad54c6e53

Comment 9 Jens Petersen 2022-11-02 13:56:25 UTC
If this goes into F37 GA then the gettext base package would no longer be pre-installed in Fedora WS, etc.
So this would in a sense complete https://fedoraproject.org/wiki/Changes/GettextRuntimeSubpackage .

The libvirt change has already been in Rawhide since around 12 Sept.

Comment 10 Sandro 2022-11-02 18:07:22 UTC
> This will help reduce the size of the Fedora Live image(s) etc.

What's the gain (reduction in image size)?

Comment 11 Adam Williamson 2022-11-02 18:18:35 UTC
Per the change page, "Space saving of about ~4.7 MB for typical installations." About 1M compressed (so 1M difference in live image size).

Comment 12 Fedora Update System 2022-11-03 08:46:51 UTC
FEDORA-2022-dad54c6e53 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-dad54c6e53`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-dad54c6e53

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Adam Williamson 2022-11-07 18:08:54 UTC
Discussed at the 2022-11-07 blocker/FE review meeting: https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2022-11-07/ . Rejected as an FE on the basis that the reported benefit is just too small to be worth risking at this point.

Comment 14 Fedora Update System 2022-11-10 22:31:00 UTC
FEDORA-2022-dad54c6e53 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.