Bug 2117537 - agent.iso is created in case of empty or invalid rendezvousIP
Summary: agent.iso is created in case of empty or invalid rendezvousIP
Keywords:
Status: RELEASE_PENDING
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 4.12
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 4.12.0
Assignee: Andrea Fasano
QA Contact: Manoj Hans
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-11 09:27 UTC by Manoj Hans
Modified: 2023-03-02 18:58 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift installer pull 6474 0 None open Bug 2117537: validation rule for invalid rendezvousIP in AgentConfig 2022-10-11 08:46:48 UTC

Description Manoj Hans 2022-08-11 09:27:44 UTC
Description: agent.iso is created in case of empty or invalid rendezvousIP

Here is the content of agent-config.yaml
Empty Case:
--------------------------------------------
kind: AgentConfig
metadata:
  name: sno-cluster
spec:
  rendezvousIP: 
--------------------------------------------
Invalid IP Address Case:
--------------------------------------------
kind: AgentConfig
metadata:
  name: sno-cluster
spec:
  rendezvousIP: 12121221
--------------------------------------------

How reproducible:

always

Repro Steps: 

1) Get the latest agent-installer and build

git clone -b agent-installer https://github.com/openshift/installer.git
cd installer/
hack/build.sh

2) Create agent.iso using agent-config and install-config files.


Expected: Installer should be thrown an error message something like this: spec.rendezvousIP: Invalid value: “”: rendezvousIP must provide the valid IP address.
Actual: Able to create agent.iso image.

Comment 1 Zane Bitter 2022-09-23 16:11:26 UTC
All fields in the agent-config are optional, so an empty rendezvousIP is fine.

It would be good to check for an invalid IP.

Comment 3 Manoj Hans 2022-10-19 07:17:08 UTC
This bug has been verified with registry.ci.openshift.org/ocp/release:4.12.0-0.nightly-2022-10-18-041406 release, its working as expected. Hence moving it to verified.


Note You need to log in before you can comment on or make changes to this bug.