Created attachment 1904978 [details]
install-config.yaml

Description:

When controlPlane.replicas = 1 and compute.replicas is missing from install-config.yaml, assisted-service validation fails because it is looking for more worker nodes and expecting api_vip and ingress_vip to be set. It doesn't recognize that I'm trying to install a SNO cluster. Only when compute.replicas is set to 0 does it recognize it to be SNO. 

We should add a validation to warn users that compute.replicas needs to be set to 0 if controlPlane.replicas = 1.

Steps to reproduce:

1. Create agent.iso using install-config.yaml and agent-config.yaml
2. Deploy a SNO cluster using agent.iso
3. openshift-install agent wait-for install-complete

Expected:

Cluster installation is successful

Actual:

Validation fails

[rwsu@hardprov-fx2-22 openshift-installer]$ ./openshift-install agent wait-for install-complete
INFO Waiting for cluster install to initialize. Sleeping for 30 seconds 
INFO Waiting for cluster install to initialize. Sleeping for 30 seconds 
INFO Waiting for cluster install to initialize. Sleeping for 30 seconds 
INFO Cluster is not ready for install. Check host validations 
WARNING Cluster has stopped installing... working to recover installation 
WARNING Cluster has stopped installing... working to recover installation 
WARNING Cluster has stopped installing... working to recover installation 
INFO Checking for validation failures ---------------------------------------------- 
ERROR Validation failure found for cluster          category=hosts-data label=all-hosts-are-ready-to-install message=The cluster has hosts that are not ready to install.
ERROR Validation failure found for cluster          category=hosts-data label=sufficient-masters-count message=Clusters must have exactly 3 dedicated masters and if workers are added, there should be at least 2 workers. Please check your configuration and add or remove hosts as to meet the above requirement.
ERROR Validation failure found for cluster          category=network label=Machine CIDR message=The Machine Network CIDR is undefined; the Machine Network CIDR can be defined by setting either the API or Ingress virtual IPs.
ERROR Validation failure found for cluster          category=network label=api-vip-defined message=The API virtual IP is undefined and must be provided.
ERROR Validation failure found for cluster          category=network label=ingress-vip-defined message=The Ingress virtual IP is undefined and must be provided.
INFO Checking for validation failures ---------------------------------------------- 
ERROR Validation failure found for cluster          category=hosts-data label=all-hosts-are-ready-to-install message=The cluster has hosts that are not ready to install.
ERROR Validation failure found for cluster          category=hosts-data label=sufficient-masters-count message=Clusters must have exactly 3 dedicated masters and if workers are added, there should be at least 2 workers. Please check your configuration and add or remove hosts as to meet the above requirement.
ERROR Validation failure found for cluster          category=network label=Machine CIDR message=The Machine Network CIDR is undefined; the Machine Network CIDR can be defined by setting either the API or Ingress virtual IPs.
ERROR Validation failure found for cluster          category=network label=api-vip-defined message=The API virtual IP is undefined and must be provided.
ERROR Validation failure found for cluster          category=network label=ingress-vip-defined message=The Ingress virtual IP is undefined and must be provided.
ERROR Validation failure found for control1.ostest.test.metalkube.org  category=network label=DNS wildcard not configured message=Parse error for domain name resolutions result
ERROR Validation failure found for control1.ostest.test.metalkube.org  category=network label=Machine CIDR message=Machine Network CIDR is undefined; the Machine Network CIDR can be defined by setting either the API or Ingress virtual IPs
ERROR Validation failure found for control1.ostest.test.metalkube.org  category=network label=NTP synchronization message=Host couldn't synchronize with any NTP server
INFO Checking for validation failures ---------------------------------------------- 
ERROR Validation failure found for cluster          category=hosts-data label=all-hosts-are-ready-to-install message=The cluster has hosts that are not ready to install.
ERROR Validation failure found for cluster          category=hosts-data label=sufficient-masters-count message=Clusters must have exactly 3 dedicated masters and if workers are added, there should be at least 2 workers. Please check your configuration and add or remove hosts as to meet the above requirement.
ERROR Validation failure found for cluster          category=network label=Machine CIDR message=The Machine Network CIDR is undefined; the Machine Network CIDR can be defined by setting either the API or Ingress virtual IPs.
ERROR Validation failure found for cluster          category=network label=api-vip-defined message=The API virtual IP is undefined and must be provided.
ERROR Validation failure found for cluster          category=network label=ingress-vip-defined message=The Ingress virtual IP is undefined and must be provided.
ERROR Validation failure found for control1.ostest.test.metalkube.org  category=network label=Machine CIDR message=Machine Network CIDR is undefined; the Machine Network CIDR can be defined by setting either the API or Ingress virtual IPs
ERROR Validation failure found for control1.ostest.test.metalkube.org  category=network label=NTP synchronization message=Host couldn't synchronize with any NTP server