Bug 2118078 - Review Request: rust-attohttpc - Small and lightweight HTTP client
Summary: Review Request: rust-attohttpc - Small and lightweight HTTP client
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Michel Lind
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW 1990712
TreeView+ depends on / blocked
 
Reported: 2022-08-14 00:06 UTC by Davide Cavalca
Modified: 2022-11-13 00:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-13 00:45:51 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2022-08-14 00:06:01 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-attohttpc/rust-attohttpc.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-attohttpc/rust-attohttpc-0.22.0-1.fc38.src.rpm

Description:
Small and lightweight HTTP client.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2022-08-14 00:06:02 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=90772919

Comment 2 Davide Cavalca 2022-08-14 00:06:34 UTC
This will need to be unretired on rawhide and f37 once approved: https://src.fedoraproject.org/rpms/rust-attohttpc

Comment 3 Fabio Valentini 2022-08-16 21:55:42 UTC
I recommend dropping the Rustls support features entirely rather than downgrading the dependencies.

I'm currently in the process of removing the Rustls crates from Fedora, because they are unused, and the ring + rustls upstream projects are pretty dead - or at least dormant (which is concerning for a crypto library and TLS implementation).

Comment 4 Michel Lind 2022-08-19 17:52:11 UTC
Will review once Davide addressed Fabio's comment

Comment 5 Package Review 2022-09-19 00:45:25 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

Comment 6 Davide Cavalca 2022-10-05 16:53:28 UTC
I looked at this quite a bit and I don't see a sane way to disable rustls and keep the tests working -- unfortunately the test suite relies on it pretty heavily. We could turn the tests off of course, but that seems suboptimal...

Comment 7 Fabio Valentini 2022-10-05 18:06:28 UTC
If not all dependencies for tests are available (in this case, not on all architectures), then that's a perfectly good reason to disable tests. It's not optimal, but it's definitely not a blocker for packaging something.

Comment 8 Michel Lind 2022-10-13 20:10:17 UTC
This has a broken dependency:

Error: 
 Problem 1: conflicting requests
  - nothing provides (crate(multipart/client) >= 0.18.0 with crate(multipart/client) < 0.19.0~) needed by rust-attohttpc+multipart-devel-0.22.0-1.fc38.noarch
 Problem 2: package rust-attohttpc+multipart-form-devel-0.22.0-1.fc38.noarch requires crate(attohttpc/multipart) = 0.22.0, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(multipart/client) >= 0.18.0 with crate(multipart/client) < 0.19.0~) needed by rust-attohttpc+multipart-devel-0.22.0-1.fc38.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use

Comment 9 Michel Lind 2022-10-13 20:11:23 UTC
It got retired, you need to unretire it - https://src.fedoraproject.org/rpms/rust-multipart

Comment 10 Fabio Valentini 2022-10-13 20:49:58 UTC
(In reply to Michel Alexandre Salim from comment #9)
> It got retired, you need to unretire it -
> https://src.fedoraproject.org/rpms/rust-multipart

Please don't. I retired it intentionally. The "multipart" crate is obsolete and shouldn't be used any longer, "multer" seems to be the modern replacement.
Instead, just disable the "multipart" feature in attohttpc.

Comment 11 Package Review 2022-11-13 00:45:51 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.