Bug 2118722 - package-notes-srpm-macros-0.5 breaks building any packages
Summary: package-notes-srpm-macros-0.5 breaks building any packages
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: package-notes
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-16 14:16 UTC by Ben Beasley
Modified: 2022-08-16 16:09 UTC (History)
6 users (show)

Fixed In Version: package-notes-0.5-4.fc37 package-notes-0.5-4.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-16 15:49:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ben Beasley 2022-08-16 14:16:42 UTC
Description of problem:

error: syntax error in expression: 0%{?_package_note_file:1} && 0%{?name:1} && "%_target_cpu" != "noarch" && 1 : 0
error:                                                                                                         ^
  1<    (%)
  0<  (%_package_note_status)
  6<              (%)
  5<            (%_package_note_flags)
  4<          (%build_ldflags)
-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 
  3<        (%set_build_flags)
  LDFLAGS="${LDFLAGS:--Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 
  2<      (%_auto_set_build_flags)
  LDFLAGS="${LDFLAGS:--Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 
  2<      (%)
  1<    (%expand)
  0<  (%pyproject_buildrequires)

Version-Release number of selected component (if applicable): 0.5-1


How reproducible:


Steps to Reproduce:
1. fedpkg co python-reretry
2. cd python-reretry
3. fedpkg mockbuild --enablerepo=local

Actual results:

Syntax error as pasted above.

Expected results:

Successful build.

Additional info:

I’m not sure yet if this breaks all Python packages, or only those that use pyproject-rpm-macros.

Comment 1 Petr Pisar 2022-08-16 14:27:30 UTC
The same issue with a noarch perl-Bencode.

Comment 2 Petr Pisar 2022-08-16 14:30:05 UTC
Fedora 37 is also affected.

Comment 3 Ben Beasley 2022-08-16 14:35:20 UTC
This PR should fix it (https://src.fedoraproject.org/rpms/package-notes/pull-request/7), but it looks like the regression has broken all RPM builds, not just Python ones, so I can’t even try rebuilding package-notes.

I think releng will have to untag package-notes-0.5-3.fc38, package-notes-0.5-3.fc37, and perhaps package-notes-0.5-3.eln121 (I don’t know much about ELN).

Comment 4 Vitaly Zaitsev 2022-08-16 14:39:14 UTC
Same issue. All F37 and F38 builds are broken now.

Comment 5 Petr Pisar 2022-08-16 14:39:49 UTC
Untagging requested <https://pagure.io/releng/issue/10973>.

Comment 6 Miro Hrončok 2022-08-16 14:43:15 UTC
(In reply to Ben Beasley from comment #3)
> This PR should fix it
> (https://src.fedoraproject.org/rpms/package-notes/pull-request/7), but it
> looks like the regression has broken all RPM builds, not just Python ones,
> so I can’t even try rebuilding package-notes.
> 
> I think releng will have to untag package-notes-0.5-3.fc38,
> package-notes-0.5-3.fc37, and perhaps package-notes-0.5-3.eln121 (I don’t
> know much about ELN).

You can always request a side tag, tag in an older version of package-notes in it, rebuild pacakge-notes and ship an update.

Comment 7 Ben Beasley 2022-08-16 14:45:57 UTC
> You can always request a side tag, tag in an older version of package-notes in it, rebuild pacakge-notes and ship an update.

Thanks. It looks like untagging is in progress, but I’ll try to remember that.

Comment 8 Fedora Update System 2022-08-16 15:47:30 UTC
FEDORA-2022-327de933d3 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-327de933d3

Comment 9 Fedora Update System 2022-08-16 15:48:13 UTC
FEDORA-2022-51b90a342a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-51b90a342a

Comment 10 Fedora Update System 2022-08-16 15:49:31 UTC
FEDORA-2022-327de933d3 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-08-16 15:49:43 UTC
FEDORA-2022-51b90a342a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fabio Valentini 2022-08-16 16:09:20 UTC
The "fixed" build also causes build failures, at least for Rust packages, during linking:

  = note: /usr/bin/ld: cannot open linker script file 1: No such file or directory
          collect2: error: ld returned 1 exit status

https://koji.fedoraproject.org/koji/taskinfo?taskID=90881321


Note You need to log in before you can comment on or make changes to this bug.