Bug 2118891 - Review Request: rust-deltae - Calculate Delta E between two colors in CIE Lab space
Summary: Review Request: rust-deltae - Calculate Delta E between two colors in CIE Lab...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2105859
TreeView+ depends on / blocked
 
Reported: 2022-08-17 02:11 UTC by Davide Cavalca
Modified: 2022-11-10 22:25 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-10-26 02:56:19 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2022-08-17 02:11:28 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-deltae/rust-deltae.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-deltae/rust-deltae-0.3.0-1.fc38.src.rpm

Description:
Calculate Delta E between two colors in CIE Lab space.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2022-08-17 02:11:30 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=90897834

Comment 2 Fabio Valentini 2022-08-17 09:06:09 UTC
Looks like this crate bundles its rustdoc-generated docs in "/docs/", which includes JavaScript, fonts, and their licenses.

You'll need to exclude the "/docs/" directory from the installed files ... and I suspect a PR for upstream to add `exclude = ["/docs/"]` to Cargo.toml would be a good idea (since the crate's docs are 2.8 MB and the entire crate is 2.9 MB ...)

Comment 4 Fabio Valentini 2022-10-19 08:59:24 UTC
Thanks for the update!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Gwyn Ciesla 2022-10-24 16:40:35 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-deltae

Comment 6 Fedora Update System 2022-10-26 02:51:19 UTC
FEDORA-2022-2d16b084e8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2d16b084e8

Comment 7 Fedora Update System 2022-10-26 02:56:19 UTC
FEDORA-2022-2d16b084e8 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2022-10-26 03:03:13 UTC
FEDORA-2022-9ac8750658 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-9ac8750658

Comment 9 Fedora Update System 2022-10-26 03:23:18 UTC
FEDORA-2022-fd6ef198eb has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd6ef198eb

Comment 10 Fedora Update System 2022-10-26 03:40:12 UTC
FEDORA-2022-830c7c55c6 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-830c7c55c6

Comment 11 Fedora Update System 2022-10-26 16:18:51 UTC
FEDORA-2022-9ac8750658 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-9ac8750658 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9ac8750658

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-10-26 18:31:50 UTC
FEDORA-2022-fd6ef198eb has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-fd6ef198eb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fd6ef198eb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-10-26 18:41:05 UTC
FEDORA-2022-830c7c55c6 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-830c7c55c6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-830c7c55c6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-11-03 15:30:42 UTC
FEDORA-2022-830c7c55c6 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2022-11-03 15:57:46 UTC
FEDORA-2022-fd6ef198eb has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-11-10 22:25:52 UTC
FEDORA-2022-9ac8750658 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.