Spec URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/04740138-hcxtools/hcxtools.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/04740138-hcxtools/hcxtools-6.2.7-1.fc38.src.rpm Description: Small set of tools convert packets from captures (h = hash, c = capture, convert and calculate candidates, x = different hashtypes) for the use with latest hashcat or John the Ripper. The tools are 100% compatible to hashcat and John the Ripper and recommended by hashcat. This branch is pretty closely synced to hashcat git and John the Ripper git. Support of hashcat hash-modes: 4800, 5500, 2200x, 16100, 250x (deprecated), 1680x (deprecated) Support of John the Ripper hash-modes: WPAPSK-PMK, PBKDF2-HMAC-SHA1, chap, netntlm, tacacs-plus Support of gzip (.gz) single file compression. Main purpose is to detect weak points within own WiFi networks by analyzing the hashes. Therefore convert the dump file to WPA-PBKDF2-PMKID+EAPOL hash file and check if wlan-key or plainmasterkey was transmitted unencrypted. Or upload the "uncleaned" dump file (pcapng, pcap, cap) here https://wpa-sec.stanev.org/?submit to find out if your ap or the client is vulnerable by using common wordlists or a weak password generation algorithm. Fedora Account System Username: atim --- https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/04740138-hcxtools/fedora-review/review.txt
===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 46 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/hcxtools/2118906-hcxtools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: hcxtools (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/ZerBea/hcxtools/archive/6.2.7/hcxtools-6.2.7.tar.gz : CHECKSUM(SHA256) this package : c9d69b5ddcf61c3deff687fad6c17197970cc75c5dbc7706b31c138bf0c784e1 CHECKSUM(SHA256) upstream package : c9d69b5ddcf61c3deff687fad6c17197970cc75c5dbc7706b31c138bf0c784e1 Requires -------- hcxtools (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libcurl.so.4()(64bit) libssl.so.3()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) hcxtools-debuginfo (rpmlib, GLIBC filtered): hcxtools-debugsource (rpmlib, GLIBC filtered): Provides -------- hcxtools: hcxtools hcxtools(x86-64) hcxtools-debuginfo: debuginfo(build-id) hcxtools-debuginfo hcxtools-debuginfo(x86-64) hcxtools-debugsource: hcxtools-debugsource hcxtools-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2118906 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: PHP, Haskell, R, Perl, SugarActivity, fonts, Java, Python, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH $ rpmlint hcxtools-6.2.7-1.fc38.src.rpm ====================================== rpmlint session starts ====================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ======= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 2.9 s ======= $ rpmlint hcxtools-6.2.7-1.fc38.x86_64.rpm ====================================== rpmlint session starts ====================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 hcxtools.x86_64: W: no-manual-page-for-binary hcxeiutool hcxtools.x86_64: W: no-manual-page-for-binary hcxessidtool hcxtools.x86_64: W: no-manual-page-for-binary hcxhash2cap hcxtools.x86_64: W: no-manual-page-for-binary hcxhashcattool hcxtools.x86_64: W: no-manual-page-for-binary hcxhashtool hcxtools.x86_64: W: no-manual-page-for-binary hcxmactool hcxtools.x86_64: W: no-manual-page-for-binary hcxpcapngtool hcxtools.x86_64: W: no-manual-page-for-binary hcxpmkidtool hcxtools.x86_64: W: no-manual-page-for-binary hcxpmktool hcxtools.x86_64: W: no-manual-page-for-binary hcxpsktool hcxtools.x86_64: W: no-manual-page-for-binary hcxwltool hcxtools.x86_64: W: no-manual-page-for-binary whoismac hcxtools.x86_64: W: no-manual-page-for-binary wlancap2wpasec hcxtools.x86_64: E: env-script-interpreter /usr/share/doc/hcxtools/usefulscripts/hcxgrep.py /usr/bin/env python3 ===== 1 packages and 0 specfiles checked; 1 errors, 13 warnings, 1 badness; has taken 181.0 s ====== $ rpmlint hcxtools-6.2.7-1.fc38.x86_64.rpm ====================================== rpmlint session starts ====================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ======= 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.0 s ======= $ rpmlint hcxtools-debuginfo-6.2.7-1.fc38.x86_64.rpm ====================================== rpmlint session starts ====================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ======= 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.8 s ======= $ rpmlint hcxtools-debugsource-6.2.7-1.fc38.x86_64.rpm ====================================== rpmlint session starts ====================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ======= 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ======= Comments: a) Upstream publishes signatures https://github.com/ZerBea/hcxtools/releases/tag/6.2.7 please verify b) Can you use a newer version of OpenSSL? - Package must not depend on deprecated() packages. Note: openssl1.1-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ Consider replacing "BuildRequires: pkgconfig(openssl)" with the explicit package name. c) Can you enable more architectures in your COPR builds? d) Is it worth packaging the useful scripts?
Thanks for review! a) Done. Please check. b) OpenSSL 3.0.5 used here. I guess this could related to new change [1] and fedora-review tool require some update. Need help there. c) Done: https://copr.fedorainfracloud.org/coprs/atim/hcxtools/build/4784733/ d) I believe it worth packaging. I've added commentary to Spec about these scripts and link to upstream docs. [1]: https://fedoraproject.org/wiki/Changes/OpenSSL3.0 --- Spec URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04784733-hcxtools/hcxtools.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04784733-hcxtools/hcxtools-6.2.7-0.1.fc38.src.rpm
New build with hotfix for script and rpmlint issue: E: env-script-interpreter Spec URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04784777-hcxtools/hcxtools.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04784777-hcxtools/hcxtools-6.2.7-0.2.fc38.src.rpm
Minor update: Spec URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04785335-hcxtools/hcxtools.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04785335-hcxtools/hcxtools-6.2.7-0.3.fc38.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: openssl1.1-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 46 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/hcxtools/2118906-hcxtools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: hcxtools (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/ZerBea/hcxtools/releases/download/6.2.7/hcxtools-6.2.7.tar.gz.asc : CHECKSUM(SHA256) this package : f79d41706bca1880b2e7df2a55d955e2bcb386936df06842ce908e8827e4540d CHECKSUM(SHA256) upstream package : f79d41706bca1880b2e7df2a55d955e2bcb386936df06842ce908e8827e4540d https://github.com/ZerBea/hcxtools/archive/6.2.7/hcxtools-6.2.7.tar.gz : CHECKSUM(SHA256) this package : c9d69b5ddcf61c3deff687fad6c17197970cc75c5dbc7706b31c138bf0c784e1 CHECKSUM(SHA256) upstream package : c9d69b5ddcf61c3deff687fad6c17197970cc75c5dbc7706b31c138bf0c784e1 Requires -------- hcxtools (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libcurl.so.4()(64bit) libssl.so.3()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) hcxtools-debuginfo (rpmlib, GLIBC filtered): hcxtools-debugsource (rpmlib, GLIBC filtered): Provides -------- hcxtools: hcxtools hcxtools(x86-64) hcxtools-debuginfo: debuginfo(build-id) hcxtools-debuginfo hcxtools-debuginfo(x86-64) hcxtools-debugsource: hcxtools-debugsource hcxtools-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2118906 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: R, SugarActivity, fonts, Haskell, Perl, Java, Python, Ocaml, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH $ rpmlint hcxtools-6.2.7-0.3.fc38.src.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ========= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.8 s ======== $ rpmlint hcxtools-6.2.7-0.3.fc38.x86_64.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ========= 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s ======== $ rpmlint hcxtools-debugsource-6.2.7-0.3.fc38.x86_64.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ========= 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s ======== $ rpmlint hcxtools-debuginfo-6.2.7-0.3.fc38.x86_64.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ========= 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.5 s ======== Comments: a) Why use 0.3 for Release instead of 1? See https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ b) hcxpmktool.c seems to have executable permissions. c) Programs seem to work, though have not done extensive testing.
The README indicates that hcxhashcattool, hcxessidtool, hcxpmkidtool and hcxmactool will be removed when switching to OpenSSL 3.0. Maybe these should not be packaged? Build also gives the following warnings: hcxpcapngtool.c: In function ‘testeapolpmk’: hcxpcapngtool.c:2169:9: warning: ‘EVP_PKEY_new_CMAC_key’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 2169 | pkey = EVP_PKEY_new_CMAC_key(NULL, testptk, 16, EVP_aes_128_cbc()); | ^~~~ In file included from hcxpcapngtool.c:23: /usr/include/openssl/evp.h:1826:11: note: declared here 1826 | EVP_PKEY *EVP_PKEY_new_CMAC_key(ENGINE *e, const unsigned char *priv, | ^~~~~~~~~~~~~~~~~~~~~ hcxhashtool.c: In function ‘testeapolpmk’: hcxhashtool.c:527:9: warning: ‘EVP_PKEY_new_CMAC_key’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 527 | pkey = EVP_PKEY_new_CMAC_key(NULL, testptk, 16, EVP_aes_128_cbc()); | ^~~~ In file included from hcxhashtool.c:24: /usr/include/openssl/evp.h:1826:11: note: declared here 1826 | EVP_PKEY *EVP_PKEY_new_CMAC_key(ENGINE *e, const unsigned char *priv, | ^~~~~~~~~~~~~~~~~~~~~ hcxpmktool.c: In function ‘calculatemic’: hcxpmktool.c:287:9: warning: ‘EVP_PKEY_new_CMAC_key’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 287 | pkey = EVP_PKEY_new_CMAC_key(NULL, testptk, 16, EVP_aes_128_cbc()); | ^~~~ In file included from hcxpmktool.c:22: /usr/include/openssl/evp.h:1826:11: note: declared here 1826 | EVP_PKEY *EVP_PKEY_new_CMAC_key(ENGINE *e, const unsigned char *priv, | ^~~~~~~~~~~~~~~~~~~~~
(In reply to Benson Muite from comment #5) a) Why use 0.3 for Release instead of 1? See https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ Fedora maintainers recommend me this when submitting package for review. Maybe we should document this in Guidelines. Such 0.X version only needed for review process and final release version should be '1'. This could help with potential issue for users who used COPR before and they will not receive update when package goes into official repo. b) hcxpmktool.c seems to have executable permissions. Upstreamed: https://github.com/ZerBea/hcxtools/pull/220 > The README indicates that hcxhashcattool, hcxessidtool, hcxpmkidtool and hcxmactool will be removed when switching to OpenSSL 3.0. Maybe these should not be packaged? Agree. Removed deprecated tools. --- Spec URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04813039-hcxtools/hcxtools.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04813039-hcxtools/hcxtools-6.2.7-0.4.fc38.src.rpm
Ok on versioning as indicated in https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_prerelease_versions thanks. Please update to 1 when released. In the spec file, if you replace BuildRequires: pkgconfig(libcurl) BuildRequires: pkgconfig(libpcap) BuildRequires: pkgconfig(openssl) BuildRequires: pkgconfig(zlib) with BuildRequires: libcurl-devel BuildRequires: libpcap-devel BuildRequires: openssl-devel BuildRequires: zlib-devel BuildRequires: pkg-config you no longer get the deprecation warning. Is this an ok change to make?
(In reply to Benson Muite from comment #8) It's should be fine https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/#_rationale New build: Spec URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04831127-hcxtools/hcxtools.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/atim/hcxtools/fedora-rawhide-x86_64/04831127-hcxtools/hcxtools-6.2.7-0.5.fc38.src.rpm
Thanks. Approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/hcxtools
FEDORA-2022-0deba05b12 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0deba05b12
FEDORA-2022-5439cefc88 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5439cefc88
FEDORA-EPEL-2022-30e3b7e627 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-30e3b7e627
FEDORA-2022-16b1940b5d has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-16b1940b5d
FEDORA-2022-0deba05b12 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-0deba05b12 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0deba05b12 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-5439cefc88 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-5439cefc88 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-5439cefc88 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-16b1940b5d has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-16b1940b5d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-16b1940b5d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2022-30e3b7e627 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-30e3b7e627 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2022-30e3b7e627 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-0deba05b12 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-5439cefc88 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-16b1940b5d has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.