Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2119030

Summary: VDOPOOL extension should use --noflush --nolockfs parameters
Product: Red Hat Enterprise Linux 9 Reporter: Zdenek Kabelac <zkabelac>
Component: lvm2Assignee: Zdenek Kabelac <zkabelac>
lvm2 sub component: VDO QA Contact: cluster-qe <cluster-qe>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: agk, awalsh, cmarthal, heinzm, jbrassow, mcsontos, prajnoha, zkabelac
Version: 9.1Keywords: Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: lvm2-2.03.17-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-09 08:23:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zdenek Kabelac 2022-08-17 10:21:32 UTC
Just like when we are extending thin-pool - the similar logic should be used with vdopool.

As suggested by VDO team, they are now confident the extension can work properly.

This enhancement is needed especially in corner cases, where VDOPOOL is approaching 100% fullness to avoid deadlocking on waiting for flush operation before pool is actually extended.

Comment 1 Zdenek Kabelac 2022-08-19 13:23:34 UTC
Current upstream solution: https://listman.redhat.com/archives/lvm-devel/2022-August/024277.html

Patch ensures the extension of VDOPOOL and VDO volume are using 'SUSPEND' with  'noflush'  and 'skiplockfs'.
Visible with strace or  -vvvv trace of 'lvextend' command.

lvextend device_mapper/libdm-deptree.c:1379  Suspending vg-lvol0 (253:2)
lvextend device_mapper/ioctl/libdm-iface.c:2081  dm suspend   (253:2) [ noopencount noflush skiplockfs ]   [2048] (*1)

Should ensure the extension happens before flushing 'in-flight' IO (which might potentially overfill pool before extension)

Comment 4 Corey Marthaler 2022-11-23 17:58:14 UTC
Marking Verified:Tested in the latest rpms.

kernel-5.14.0-176.el9    BUILT: Wed Oct 12 03:57:18 AM CDT 2022
lvm2-2.03.17-1.el9    BUILT: Thu Nov 10 10:02:16 AM CST 2022
lvm2-libs-2.03.17-1.el9    BUILT: Thu Nov 10 10:02:16 AM CST 2022


[root@hayes-03 ~]# lvextend -L +100M -vvvv vdo_sanity/vdo_lv  > /tmp/lvextend 2>&1

[root@hayes-03 ~]# grep suspend /tmp/lvextend | grep dm
11:55:25.314342 lvextend[9730] device_mapper/libdm-config.c:1085  devices/ignore_suspended_devices not found in config: defaulting to 0
11:55:25.530198 lvextend[9730] device_mapper/ioctl/libdm-iface.c:2081  dm suspend   (253:2) [ noopencount noflush skiplockfs ]   [2048] (*1)
11:55:25.534103 lvextend[9730] device_mapper/ioctl/libdm-iface.c:2081  dm suspend   (253:1) [ noopencount noflush skiplockfs ]   [2048] (*1)
11:55:25.562095 lvextend[9730] device_mapper/ioctl/libdm-iface.c:2081  dm suspend   (253:0) [ noopencount noflush skiplockfs ]   [2048] (*1)

Comment 9 Corey Marthaler 2022-12-15 20:03:31 UTC
Verified in the latest rpms as well.

kernel-5.14.0-205.el9    BUILT: Fri Dec  2 07:14:37 AM CST 2022
lvm2-2.03.17-3.el9    BUILT: Wed Dec  7 10:41:40 AM CST 2022
lvm2-libs-2.03.17-3.el9    BUILT: Wed Dec  7 10:41:40 AM CST 2022

Comment 11 errata-xmlrpc 2023-05-09 08:23:40 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (lvm2 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2544