Spec URL: https://orion.fedorapeople.org/rust-nanorand.spec SRPM URL: https://orion.fedorapeople.org/rust-nanorand-0.7.0-1.fc38.src.rpm Description: Tiny, fast, zero-dep library for random number generation. Fedora Account System Username: orion
So, I patched the deps in the following manner: [dependencies.getrandom] version = "0.2.5" -features = ["rdrand", "js"] +features = ["rdrand"] because the current getrandom package does not provide the "js" feature. I have no idea if this is okay to do.
Yes, this is entirely OK - getrandom's "js" feature is intended for WebAssembly environments and has additional dependencies. Since we don't compile to WebAssembly, removing this feature is OK, and indeed, desirable (to prune unnecessary dependencies from the dep tree).
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Zlib) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Two nit-picks: 1) Add a comment below "# Manually created patch for downstream crate metadata changes" that explains what you did, something like # * remove WASM-specific "js" feature from the getrandom dependency 2) Exclude some upstream-development-only files from getting installed, i.e. add this line below "resolver = 2" in Cargo.toml: exclude = ["/deny.toml", "/enforce-conventional-commits.py", "/README.tpl"] and add a comment about it, something like # * prevent some files that are only useful for upstream development from getting installed
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nanorand
Built. Thanks all.