Spec URL: https://elmarco.fedorapeople.org/mingw-gtk4.spec SRPM URL: https://elmarco.fedorapeople.org/mingw-gtk4-4.7.2-1.fc38.src.rpm Description: MinGW Windows GTK+ library Fedora Account System Username: elmarco
@manisandro for you? thanks
Taking
Could you take https://bugzilla.redhat.com/show_bug.cgi?id=2009269?
Full review below. A couple of issues: - glib-compile-schemas apparently not needed anymore - Unowned directories: %{mingwXX_datadir}/{icons,metainfo} could be added to mingw-filesystem. Potentially also all locales (as the native filesystem does). Or the package should own all locale folders it creates. - %{description} is not expanded (build RPMS contain "%{description}" as description) Rest looks good. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - glib-compile-schemas must not be run in %postun and %posttrans for Fedora 24 and later. Note: gschema file(s) in mingw32-gtk4, mingw64-gtk4 See: https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=494555#GSettings_Schema ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/x86_64-w64-mingw32/sys- root/mingw/share/locale/mjw/LC_MESSAGES, /usr/i686-w64-mingw32/sys-root/mingw/share/icons, /usr/x86_64-w64-mingw32/sys- root/mingw/share/metainfo, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons, /usr/i686-w64-mingw32/sys- root/mingw/share/locale/mjw, /usr/x86_64-w64-mingw32/sys- root/mingw/share/locale/mjw, /usr/i686-w64-mingw32/sys- root/mingw/share/locale/mjw/LC_MESSAGES, /usr/i686-w64-mingw32/sys- root/mingw/share/metainfo [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/scalable, /usr/i686-w64-mingw32/sys- root/mingw/share/icons, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/symbolic, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor, /usr/x86_64-w64-mingw32/sys- root/mingw/share/metainfo, /usr/lib/debug/usr/x86_64-w64-mingw32, /usr/i686-w64-mingw32/sys-root/mingw/share/locale/mjw/LC_MESSAGES, /usr/i686-w64-mingw32/sys-root/mingw/share/metainfo, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/scalable/apps, /usr/i686-w64-mingw32/sys-root/mingw/share/icons/hicolor/symbolic, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons/hicolor/scalable, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/scalable/apps, /usr/i686-w64-mingw32/sys-root/mingw/share/locale/mjw, /usr/i686-w64-mingw32/sys- root/mingw/share/icons/hicolor/symbolic/apps, /usr/x86_64-w64-mingw32/sys-root/mingw/share/locale/mjw, /usr/x86_64-w64-mingw32/sys- root/mingw/share/icons/hicolor/symbolic/apps, /usr/x86_64-w64-mingw32/sys-root/mingw/share/icons, /usr/x86_64-w64-mingw32/sys-root/mingw/share/locale/mjw/LC_MESSAGES [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Scriptlets must be sane, if used. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define release_version %(echo %{version} | awk -F. '{print $1"."$2}') [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: mingw32-gtk4-4.7.2-1.fc38.noarch.rpm mingw32-gtk4-update-icon-cache-4.7.2-1.fc38.noarch.rpm mingw64-gtk4-4.7.2-1.fc38.noarch.rpm mingw64-gtk4-update-icon-cache-4.7.2-1.fc38.noarch.rpm mingw64-gtk4-debuginfo-4.7.2-1.fc38.noarch.rpm mingw-gtk4-4.7.2-1.fc38.src.rpm =========================================================================================================== rpmlint session starts ========================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1urpotwk')] checks: 31, packages: 6 mingw32-gtk4.noarch: W: unexpanded-macro %description -l C %{descripton} mingw64-gtk4.noarch: W: unexpanded-macro %description -l C %{description} mingw64-gtk4-debuginfo.noarch: W: only-non-binary-in-usr-lib mingw32-gtk4.noarch: W: no-documentation mingw32-gtk4-update-icon-cache.noarch: W: no-documentation mingw64-gtk4.noarch: W: no-documentation mingw64-gtk4-update-icon-cache.noarch: W: no-documentation mingw32-gtk4.noarch: W: devel-file-in-non-devel-package [snip, false positive] mingw32-gtk4.noarch: W: description-shorter-than-summary mingw64-gtk4.noarch: W: description-shorter-than-summary mingw32-gtk4.noarch: E: arch-independent-package-contains-binary-or-object [snip, false positive] =========================================================================== 6 packages and 0 specfiles checked; 4 errors, 693 warnings, 4 badness; has taken 3.9 s ========================================================================== Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 5 mingw64-gtk4.noarch: W: unexpanded-macro %description -l C %{description} mingw32-gtk4.noarch: W: unexpanded-macro %description -l C %{descripton} mingw64-gtk4-debuginfo.noarch: W: only-non-binary-in-usr-lib mingw32-gtk4-update-icon-cache.noarch: W: no-documentation mingw64-gtk4.noarch: W: no-documentation mingw32-gtk4.noarch: W: no-documentation mingw64-gtk4-update-icon-cache.noarch: W: no-documentation mingw64-gtk4.noarch: W: devel-file-in-non-devel-package [snip, false positive] mingw64-gtk4.noarch: W: description-shorter-than-summary mingw32-gtk4.noarch: W: description-shorter-than-summary mingw64-gtk4.noarch: E: arch-independent-package-contains-binary-or-object [snip, false positive] 5 packages and 0 specfiles checked; 4 errors, 693 warnings, 4 badness; has taken 1.4 s Source checksums ---------------- https://download.gnome.org/sources/gtk/4.7/gtk-4.7.2.tar.xz : CHECKSUM(SHA256) this package : 7b29c0f90ec3c93f9c5c308ea2fb34f90a78adcf0836bf0ff0cb5cd078bb7d0b CHECKSUM(SHA256) upstream package : a901bf54f0dd1a8ccb30800bf203f0335887009467ef6086654634f21bf0a4cd diff -r also reports differences Requires -------- mingw32-gtk4 (rpmlib, GLIBC filtered): /bin/sh mingw32(advapi32.dll) mingw32(comctl32.dll) mingw32(comdlg32.dll) mingw32(crypt32.dll) mingw32(dwmapi.dll) mingw32(gdi32.dll) mingw32(hid.dll) mingw32(imm32.dll) mingw32(kernel32.dll) mingw32(libcairo-2.dll) mingw32(libcairo-gobject-2.dll) mingw32(libcairo-script-interpreter-2.dll) mingw32(libepoxy-0.dll) mingw32(libfribidi-0.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libgdk_pixbuf-2.0-0.dll) mingw32(libgio-2.0-0.dll) mingw32(libglib-2.0-0.dll) mingw32(libgmodule-2.0-0.dll) mingw32(libgobject-2.0-0.dll) mingw32(libgraphene-1.0-0.dll) mingw32(libgstbase-1.0-0.dll) mingw32(libgstgl-1.0-0.dll) mingw32(libgstplayer-1.0-0.dll) mingw32(libgstreamer-1.0-0.dll) mingw32(libgstvideo-1.0-0.dll) mingw32(libgtk-4-1.dll) mingw32(libharfbuzz-0.dll) mingw32(libintl-8.dll) mingw32(libjpeg-62.dll) mingw32(libpango-1.0-0.dll) mingw32(libpangocairo-1.0-0.dll) mingw32(libpangowin32-1.0-0.dll) mingw32(libpng16-16.dll) mingw32(librsvg-2-2.dll) mingw32(libssp-0.dll) mingw32(libtiff-5.dll) mingw32(msvcrt.dll) mingw32(ole32.dll) mingw32(setupapi.dll) mingw32(shell32.dll) mingw32(user32.dll) mingw32(winmm.dll) mingw32-adwaita-icon-theme mingw32-crt mingw32-filesystem mingw32-gtk4-update-icon-cache mingw32-pkg-config mingw32-gtk4-update-icon-cache (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgdk_pixbuf-2.0-0.dll) mingw32(libglib-2.0-0.dll) mingw32(libintl-8.dll) mingw32(libssp-0.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem mingw64-gtk4 (rpmlib, GLIBC filtered): /bin/sh mingw64(advapi32.dll) mingw64(comctl32.dll) mingw64(comdlg32.dll) mingw64(crypt32.dll) mingw64(dwmapi.dll) mingw64(gdi32.dll) mingw64(hid.dll) mingw64(imm32.dll) mingw64(kernel32.dll) mingw64(libcairo-2.dll) mingw64(libcairo-gobject-2.dll) mingw64(libcairo-script-interpreter-2.dll) mingw64(libepoxy-0.dll) mingw64(libfribidi-0.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libgdk_pixbuf-2.0-0.dll) mingw64(libgio-2.0-0.dll) mingw64(libglib-2.0-0.dll) mingw64(libgmodule-2.0-0.dll) mingw64(libgobject-2.0-0.dll) mingw64(libgraphene-1.0-0.dll) mingw64(libgstbase-1.0-0.dll) mingw64(libgstgl-1.0-0.dll) mingw64(libgstplayer-1.0-0.dll) mingw64(libgstreamer-1.0-0.dll) mingw64(libgstvideo-1.0-0.dll) mingw64(libgtk-4-1.dll) mingw64(libharfbuzz-0.dll) mingw64(libintl-8.dll) mingw64(libjpeg-62.dll) mingw64(libpango-1.0-0.dll) mingw64(libpangocairo-1.0-0.dll) mingw64(libpangowin32-1.0-0.dll) mingw64(libpng16-16.dll) mingw64(librsvg-2-2.dll) mingw64(libssp-0.dll) mingw64(libtiff-5.dll) mingw64(msvcrt.dll) mingw64(ole32.dll) mingw64(setupapi.dll) mingw64(shell32.dll) mingw64(user32.dll) mingw64(winmm.dll) mingw64-adwaita-icon-theme mingw64-crt mingw64-filesystem mingw64-gtk4-update-icon-cache mingw64-pkg-config mingw64-gtk4-update-icon-cache (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgdk_pixbuf-2.0-0.dll) mingw64(libglib-2.0-0.dll) mingw64(libintl-8.dll) mingw64(libssp-0.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem mingw64-gtk4-debuginfo (rpmlib, GLIBC filtered): Provides -------- mingw32-gtk4: mingw32(libgtk-4-1.dll) mingw32(libmedia-gstreamer.dll) mingw32-gtk4 mingw32-gtk4-update-icon-cache: mingw32-gtk4-update-icon-cache mingw64-gtk4: mingw64(libgtk-4-1.dll) mingw64(libmedia-gstreamer.dll) mingw64-gtk4 mingw64-gtk4-update-icon-cache: mingw64-gtk4-update-icon-cache mingw64-gtk4-debuginfo: mingw64-gtk4-debuginfo Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2119295 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Ocaml, Java, Python, Haskell, R, fonts, C/C++, SugarActivity, PHP, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Sandro Mani from comment #4) > Full review below. A couple of issues: > > - glib-compile-schemas apparently not needed anymore mingw-gtk3 was still using it, dropped > - Unowned directories: %{mingwXX_datadir}/{icons,metainfo} could be added to > mingw-filesystem. Potentially also all locales (as the native filesystem > does). Or the package should own all locale folders it creates. I dropped those, they are not used by Windows. > - %{description} is not expanded (build RPMS contain "%{description}" as > description) fixed
The locale issue still needs to be addressed, but I suppose that's something for mingw-filesystem. Approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-gtk4
https://bodhi.fedoraproject.org/updates/FEDORA-2022-1d643987a4