Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2119444

Summary:	GHSA-gqf4-p3gv-g8vw: ed25519: Invalid out of bound reads
Product:	Red Hat Enterprise Linux 8	Reporter:	Luca BRUNO <lucab>
Component:	ostree	Assignee:	Luca BRUNO <lucab>
Status:	CLOSED ERRATA	QA Contact:	RHCOS SST QE <rhcos-sst-qe>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.7	CC:	hhei
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.7	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	ostree-2022.2-5.el8	Doc Type:	Bug Fix
Doc Text:	The ed25519 signature verification code did not check that the signature has the correct length. This is believed to be a low severity issue, with practical impact is a local denial of service.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-08 09:39:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Luca BRUNO 2022-08-18 14:58:23 UTC

Full report at https://github.com/ostreedev/ostree/security/advisories/GHSA-gqf4-p3gv-g8vw

The ed25519 signature verification code does not check that the signature is the correct length.
This is believed to be a low severity issue, with practical impact is denial of service only.

Comment 6 HuijingHei 2022-08-25 06:35:49 UTC

Hi Luca, would you help to provide some suggestions about how to do the verify? Thanks!

Comment 7 Luca BRUNO 2022-08-25 07:29:54 UTC

I don't exactly know, sorry.
We do have a test-case for this in the upstream CI, see https://github.com/ostreedev/ostree/commit/e0417957ea1578032da505947ec9cac299015446.
You may try extracting that into an equivalent set of CLI commands.

Comment 8 Luca BRUNO 2022-08-26 08:17:48 UTC

I did this backport for proactive code hardening/patching, but it turned out that the original logic is only reachable if ostree is built with the `sign-ed25519` feature.
The RHEL8 package is currently built without that feature.
That means that there are no direct security concerns, and also that this backport may not have any directly verifiable/observable effects.

Comment 9 HuijingHei 2022-08-26 09:10:25 UTC

Based on Comment 8, mark it as verified from the source code point of view

[core@cosa-devsh ~]$ ostree --version
libostree:
 Version: '2022.2'
 Git: a332611316fee36b1c630f8b266e4a37f77f2c54
 Features:
  - libcurl
  - libsoup
  - gpgme
  - libarchive
  - selinux
  - openssl
  - libmount
  - systemd
  - release
  - p2p

[core@cosa-devsh ~]$ rpm -q ostree
ostree-2022.2-5.el8.x86_64

Comment 10 HuijingHei 2022-08-26 09:15:12 UTC

And thanks Luca a lot for the confirmation!

Comment 12 errata-xmlrpc 2022-11-08 09:39:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (ostree bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:7557