Bug 2119508 - grub-customizer modifies grub.cfg in EFI folder, overriding the original stub file
Summary: grub-customizer modifies grub.cfg in EFI folder, overriding the original stub...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: grub-customizer
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vasiliy Glazov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-18 17:10 UTC by zeroaurora233
Modified: 2023-01-20 16:07 UTC (History)
2 users (show)

Fixed In Version: grub-customizer-5.2.2-1.fc36 grub-customizer-5.2.2-1.fc37
Clone Of:
Environment:
Last Closed: 2023-01-06 00:53:24 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description zeroaurora233 2022-08-18 17:10:34 UTC
Description of problem:

grub-customizer modifies `/boot/efi/EFI/fedora/grub.cfg` by default, which is a stub file since f34.[1] This causes GRUB unable to find fonts and results in more unstable behaviors.

The related source code lies in [2].

[1]: https://fedoraproject.org/wiki/GRUB_2#Updating_the_GRUB_configuration_file
[2]: https://src.fedoraproject.org/rpms/grub-customizer/blob/rawhide/f/grub-customizer.spec#_59

Version-Release number of selected component (if applicable): 

Since commit 94a1069 (https://src.fedoraproject.org/rpms/grub-customizer/c/94a1069a27b4f760936d766ca9f50946ab00eb9b) and f34

How reproducible: Always

Steps to Reproduce:
1. Install grub-customizer in a UEFI boot enabled Fedora installation
2. `cat /etc/grub-customizer/grub.cfg`
3. Try to use it to modify config and reboot

Actual results:

2. Outputs:

-----
$ cat /etc/grub-customizer/grub.cfg
MKCONFIG_CMD=grub2-mkconfig
INSTALL_CMD=grub2-install
MKFONT_CMD=grub2-mkfont
CFG_DIR=/etc/grub.d
OUTPUT_DIR=/boot/efi/EFI/fedora
OUTPUT_FILE=/boot/efi/EFI/fedora/grub.cfg
SETTINGS_FILE=/etc/default/grub
-----

3. GRUB will fail to find fonts and display only ASCII fonts. It might be just one of the unstable behaviors.

Expected results: 

-----
$ cat /etc/grub-customizer/grub.cfg
<...>
OUTPUT_DIR=/boot/grub2
OUTPUT_FILE=/boot/grub2/grub.cfg
<...>
-----

And GRUB behaves normally.

Additional info: 

Just deleting L59-62 in the rpmspec is enough to fix the problem.

Comment 1 Fedora Update System 2022-12-28 12:30:14 UTC
FEDORA-2022-a11846abe1 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a11846abe1

Comment 2 Fedora Update System 2022-12-28 12:30:19 UTC
FEDORA-2022-23606b39a5 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-23606b39a5

Comment 3 Fedora Update System 2022-12-29 01:29:43 UTC
FEDORA-2022-a11846abe1 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-a11846abe1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a11846abe1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Fedora Update System 2022-12-29 02:03:31 UTC
FEDORA-2022-23606b39a5 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-23606b39a5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-23606b39a5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fedora Update System 2023-01-06 00:53:24 UTC
FEDORA-2022-23606b39a5 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2023-01-06 01:42:08 UTC
FEDORA-2022-a11846abe1 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 zeroaurora233 2023-01-20 16:07:45 UTC
From the source code I don't think that it's fixed.


Note You need to log in before you can comment on or make changes to this bug.