Bug 212005 – dnsmasq uses wrong restart type in %post script

Bug 212005 - dnsmasq uses wrong restart type in %post script

Summary:	dnsmasq uses wrong restart type in %post script

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	dnsmasq (Show other bugs)
Sub Component:
Version:	rawhide
Hardware:	All Linux

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Jima
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2006-10-24 12:17 EDT by Ralf Ertzinger
Modified:	2007-11-30 17:11 EST (History)
CC List:	1 user (show)

See Also:
Fixed In Version:	2.34-2
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2006-10-24 16:38:02 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Ralf Ertzinger 2006-10-24 12:17:08 EDT

Description of problem:
dnsmasq uses "service dnsmasq restart" in it's %post script, while the proper
call would be "service dnsmasq condrestart" (which the init.d script supports
already).
This prevents the service being started on updates when it was not running before

Version-Release number of selected component (if applicable):
dnsmasq-2.34-1.fc6

How reproducible:
always

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jima 2006-10-24 16:38:02 EDT

Thanks for the report, Ralf; you're correct, I should have used condrestart. 
I'm also rolling in a few other cleanups your bug report brought to my
attention, and I'm releasing 2.34-2 for FC-5, FC-6, and devel (FC-6 pending the
buildsys' return).

As this should have gotten caught in review, I'm adding this as a note on my
review checklist. :-)

(I'll apply the fix to FC-3/FC-4 if anyone specifically complains about them,
but as this isn't a horribly major bug, I'll otherwise hold off.)

Note You need to log in before you can comment on or make changes to this bug.