Bug 212005 - dnsmasq uses wrong restart type in %post script
Summary: dnsmasq uses wrong restart type in %post script
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: dnsmasq
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jima
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-10-24 16:17 UTC by Ralf Ertzinger
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version: 2.34-2
Clone Of:
Environment:
Last Closed: 2006-10-24 20:38:02 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Ralf Ertzinger 2006-10-24 16:17:08 UTC
Description of problem:
dnsmasq uses "service dnsmasq restart" in it's %post script, while the proper
call would be "service dnsmasq condrestart" (which the init.d script supports
already).
This prevents the service being started on updates when it was not running before

Version-Release number of selected component (if applicable):
dnsmasq-2.34-1.fc6

How reproducible:
always

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jima 2006-10-24 20:38:02 UTC
Thanks for the report, Ralf; you're correct, I should have used condrestart. 
I'm also rolling in a few other cleanups your bug report brought to my
attention, and I'm releasing 2.34-2 for FC-5, FC-6, and devel (FC-6 pending the
buildsys' return).

As this should have gotten caught in review, I'm adding this as a note on my
review checklist. :-)

(I'll apply the fix to FC-3/FC-4 if anyone specifically complains about them,
but as this isn't a horribly major bug, I'll otherwise hold off.)


Note You need to log in before you can comment on or make changes to this bug.