Spec URL: https://jonathanspw.fedorapeople.org/simpleini.spec SRPM URL: https://jonathanspw.fedorapeople.org/simpleini-4.19-1.fc38.src.rpm Description: A cross-platform library that provides a simple API to read and write INI- style configuration files. It supports data files in ASCII, MBCS and Unicode. It is designed explicitly to be portable to any platform and has been tested on Windows, WinCE and Linux. Released as open-source and free using the MIT licence. Fedora Account System Username: jonathanspw Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=91113840
Copr builds/fedora review. https://copr.fedorainfracloud.org/coprs/jonathanspw/simpleini/build/4753110/ https://download.copr.fedorainfracloud.org/results/jonathanspw/simpleini/fedora-rawhide-x86_64/04753110-simpleini/fedora-review/
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unicode strict", "MIT License", "Unknown or generated". 31 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/simpleini/2120139-simpleini/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/brofield/simpleini/archive/v4.19/simpleini-4.19.tar.gz : CHECKSUM(SHA256) this package : dc10df3fa363be2c57627d52cbb1b5ddd0689d474b f13908e822c1522df8377e CHECKSUM(SHA256) upstream package : dc10df3fa363be2c57627d52cbb1b5ddd0689d474b f13908e822c1522df8377e Requires -------- simpleini-devel (rpmlib, GLIBC filtered): Provides -------- simpleini-devel: simpleini-devel simpleini-static Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2120139 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Python, PHP, fonts, Haskell, Java, Perl, SugarActivity, R, Oca ml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH $ rpmlint simpleini-4.19-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 simpleini.spec:31: W: unversioned-explicit-provides %{name}-static 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 1.1 s $ rpmlint simpleini-devel-4.19-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.8 s $ rpmlint simpleini-devel-4.19-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Comments: a) May need Unicode license, license check has the following output: Unicode strict -------------- simpleini-4.19/ConvertUTF.c simpleini-4.19/ConvertUTF.h Maybe upstream could use something that is being actively maintained? The unicode consortium no longer updates this. b) To run the tests, one needs to use make test not make tests
> a) May need Unicode license, license check has the following output: > Unicode strict > -------------- > simpleini-4.19/ConvertUTF.c > simpleini-4.19/ConvertUTF.h > Maybe upstream could use something that is being actively maintained? The > unicode consortium no longer updates this. Added license as "Unicode" for now. It's not listed with SPDX but it is an approved Fedora license per https://fedoraproject.org/wiki/Licensing/Unicode. I'm going to work on its inclusion to SPDX but I don't think that should hold up this package. > b) To run the tests, one needs to use > make test > not > make tests `make -C tests` as written is executing the Makefile in the tests directory. There are no test definitions in the main directory so `make test` does not work. Spec URL: https://jonathanspw.fedorapeople.org/simpleini.spec SRPM URL: https://jonathanspw.fedorapeople.org/simpleini-4.19-1.fc38.src.rpm
The tests will build with `make -C tests` but do not run, to run them you need to add `make test` build log is below: Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1 ENTER ['do_with_status'](['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --nocl ean --target x86_64 --nodeps /builddir/build/SPECS/simpleini.spec'], chrootPath= '/var/lib/mock/fedora-rawhide-x86_64/root'env={'TERM': 'vt100', 'SHELL': '/bin/b ash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/usr/sbin: /sbin', 'PROMPT_COMMAND': 'printf "\\033]0;<mock-chroot>\\007"', 'PS1': '<mock-c hroot> \\s-\\v\\$ ', 'LANG': 'C.UTF-8'}shell=Falselogger=<mockbuild.trace_decora tor.getLog object at 0x7ff99bcdd300>timeout=0uid=1000gid=135user='mockbuild'nspa wn_args=['--capability=cap_ipc_lock', '--bind=/tmp/mock-resolv.3f4et79s:/etc/res olv.conf', '--bind=/dev/btrfs-control', '--bind=/dev/loop-control', '--bind=/dev /loop0', '--bind=/dev/loop1', '--bind=/dev/loop2', '--bind=/dev/loop3', '--bind= /dev/loop4', '--bind=/dev/loop5', '--bind=/dev/loop6', '--bind=/dev/loop7', '--b ind=/dev/loop8', '--bind=/dev/loop9', '--bind=/dev/loop10', '--bind=/dev/loop11' ]unshare_net=TrueprintOutput=False) Using nspawn with args ['--capability=cap_ipc_lock', '--bind=/tmp/mock-resolv.3f 4et79s:/etc/resolv.conf', '--bind=/dev/btrfs-control', '--bind=/dev/loop-control ', '--bind=/dev/loop0', '--bind=/dev/loop1', '--bind=/dev/loop2', '--bind=/dev/l oop3', '--bind=/dev/loop4', '--bind=/dev/loop5', '--bind=/dev/loop6', '--bind=/d ev/loop7', '--bind=/dev/loop8', '--bind=/dev/loop9', '--bind=/dev/loop10', '--bi nd=/dev/loop11'] Executing command: ['/usr/bin/systemd-nspawn', '-q', '-M', '957fab5b858444409162 9a5b69d234d5', '-D', '/var/lib/mock/fedora-rawhide-x86_64/root', '-a', '-u', 'mo ckbuild', '--capability=cap_ipc_lock', '--bind=/tmp/mock-resolv.3f4et79s:/etc/re solv.conf', '--bind=/dev/btrfs-control', '--bind=/dev/loop-control', '--bind=/de v/loop0', '--bind=/dev/loop1', '--bind=/dev/loop2', '--bind=/dev/loop3', '--bind =/dev/loop4', '--bind=/dev/loop5', '--bind=/dev/loop6', '--bind=/dev/loop7', '-- bind=/dev/loop8', '--bind=/dev/loop9', '--bind=/dev/loop10', '--bind=/dev/loop11 ', '--console=pipe', '--setenv=TERM=vt100', '--setenv=SHELL=/bin/bash', '--seten v=HOME=/builddir', '--setenv=HOSTNAME=mock', '--setenv=PATH=/usr/bin:/bin:/usr/s bin:/sbin', '--setenv=PROMPT_COMMAND=printf "\\033]0;<mock-chroot>\\007"', '--se tenv=PS1=<mock-chroot> \\s-\\v\\$ ', '--setenv=LANG=C.UTF-8', '--resolv-conf=off ', 'bash', '--login', '-c', '/usr/bin/rpmbuild -bs --noclean --target x86_64 --n odeps /builddir/build/SPECS/simpleini.spec'] with env {'TERM': 'vt100', 'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/u sr/sbin:/sbin', 'PROMPT_COMMAND': 'printf "\\033]0;<mock-chroot>\\007"', 'PS1': '<mock-chroot> \\s-\\v\\$ ', 'LANG': 'C.UTF-8', 'SYSTEMD_NSPAWN_TMPFS_TMP': '0', 'SYSTEMD_SECCOMP': '0'} and shell False Building target platforms: x86_64 Building for target x86_64 setting SOURCE_DATE_EPOCH=1661040000 Wrote: /builddir/build/SRPMS/simpleini-4.19-1.fc38.src.rpm Child return code was: 0 ENTER ['do_with_status'](['bash', '--login', '-c', '/usr/bin/rpmbuild -bb --nocl ean --target x86_64 --nodeps /builddir/build/SPECS/simpleini.spec'], chrootPath= '/var/lib/mock/fedora-rawhide-x86_64/root'env={'TERM': 'vt100', 'SHELL': '/bin/b ash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/usr/sbin: /sbin', 'PROMPT_COMMAND': 'printf "\\033]0;<mock-chroot>\\007"', 'PS1': '<mock-c hroot> \\s-\\v\\$ ', 'LANG': 'C.UTF-8'}shell=Falselogger=<mockbuild.trace_decora tor.getLog object at 0x7ff99bcdd300>timeout=0uid=1000gid=135user='mockbuild'nspa wn_args=['--capability=cap_ipc_lock', '--bind=/tmp/mock-resolv.3f4et79s:/etc/res olv.conf', '--bind=/dev/btrfs-control', '--bind=/dev/loop-control', '--bind=/dev /loop0', '--bind=/dev/loop1', '--bind=/dev/loop2', '--bind=/dev/loop3', '--bind= /dev/loop4', '--bind=/dev/loop5', '--bind=/dev/loop6', '--bind=/dev/loop7', '--b ind=/dev/loop8', '--bind=/dev/loop9', '--bind=/dev/loop10', '--bind=/dev/loop11' ]unshare_net=TrueprintOutput=False) Using nspawn with args ['--capability=cap_ipc_lock', '--bind=/tmp/mock-resolv.3f 4et79s:/etc/resolv.conf', '--bind=/dev/btrfs-control', '--bind=/dev/loop-control ', '--bind=/dev/loop0', '--bind=/dev/loop1', '--bind=/dev/loop2', '--bind=/dev/l oop3', '--bind=/dev/loop4', '--bind=/dev/loop5', '--bind=/dev/loop6', '--bind=/d ev/loop7', '--bind=/dev/loop8', '--bind=/dev/loop9', '--bind=/dev/loop10', '--bi nd=/dev/loop11'] Executing command: ['/usr/bin/systemd-nspawn', '-q', '-M', 'bda46b5d403d4b2c92df d6a86f656e57', '-D', '/var/lib/mock/fedora-rawhide-x86_64/root', '-a', '-u', 'mo ckbuild', '--capability=cap_ipc_lock', '--bind=/tmp/mock-resolv.3f4et79s:/etc/re solv.conf', '--bind=/dev/btrfs-control', '--bind=/dev/loop-control', '--bind=/de v/loop0', '--bind=/dev/loop1', '--bind=/dev/loop2', '--bind=/dev/loop3', '--bind =/dev/loop4', '--bind=/dev/loop5', '--bind=/dev/loop6', '--bind=/dev/loop7', '-- bind=/dev/loop8', '--bind=/dev/loop9', '--bind=/dev/loop10', '--bind=/dev/loop11 ', '--console=pipe', '--setenv=TERM=vt100', '--setenv=SHELL=/bin/bash', '--seten v=HOME=/builddir', '--setenv=HOSTNAME=mock', '--setenv=PATH=/usr/bin:/bin:/usr/s bin:/sbin', '--setenv=PROMPT_COMMAND=printf "\\033]0;<mock-chroot>\\007"', '--se tenv=PS1=<mock-chroot> \\s-\\v\\$ ', '--setenv=LANG=C.UTF-8', '--resolv-conf=off ', 'bash', '--login', '-c', '/usr/bin/rpmbuild -bb --noclean --target x86_64 --n odeps /builddir/build/SPECS/simpleini.spec'] with env {'TERM': 'vt100', 'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/u sr/sbin:/sbin', 'PROMPT_COMMAND': 'printf "\\033]0;<mock-chroot>\\007"', 'PS1': '<mock-chroot> \\s-\\v\\$ ', 'LANG': 'C.UTF-8', 'SYSTEMD_NSPAWN_TMPFS_TMP': '0', 'SYSTEMD_SECCOMP': '0'} and shell False Building target platforms: x86_64 Building for target x86_64 setting SOURCE_DATE_EPOCH=1661040000 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.xo7PKM + umask 022 + cd /builddir/build/BUILD + cd /builddir/build/BUILD + rm -rf simpleini-4.19 + /usr/lib/rpm/rpmuncompress -x /builddir/build/SOURCES/simpleini-4.19.tar.gz + STATUS=0 + '[' 0 -ne 0 ']' + cd simpleini-4.19 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + RPM_EC=0 ++ jobs -p + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.ORhO30 + umask 022 + cd /builddir/build/BUILD + CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSE RTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong - specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronou s-unwind-tables -fstack-clash-protection -fcf-protection' + export CFLAGS + CXXFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switch es -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_AS SERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchron ous-unwind-tables -fstack-clash-protection -fcf-protection' + export CXXFLAGS + FFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSE RTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong - specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronou s-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/lib64/gfortran/m odules' + export FFLAGS + FCFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switche s -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASS ERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchrono us-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/lib64/gfortran/ modules' + export FCFLAGS + LDFLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/r edhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id= sha1 -Wl,-dT,/builddir/build/BUILD/simpleini-4.19/.package_note-simpleini-4.19-1 .fc38.x86_64.ld' + export LDFLAGS + LT_SYS_LIBRARY_PATH=/usr/lib64: + export LT_SYS_LIBRARY_PATH + CC=gcc + export CC + CXX=g++ + export CXX + '[' -f /usr/lib/rpm/generate-rpm-note.sh ']' + /usr/lib/rpm/generate-rpm-note.sh simpleini 4.19-1.fc38 x86_64 + cd simpleini-4.19 + RPM_EC=0 ++ jobs -p + exit 0 Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.V3QtvK + umask 022 + cd /builddir/build/BUILD + '[' /builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64 '!=' / ']' + rm -rf /builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64 ++ dirname /builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64 + mkdir -p /builddir/build/BUILDROOT + mkdir /builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64 + CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSE RTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong - specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronou s-unwind-tables -fstack-clash-protection -fcf-protection' + export CFLAGS + CXXFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switch es -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_AS SERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchron ous-unwind-tables -fstack-clash-protection -fcf-protection' + export CXXFLAGS + FFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSE RTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong - specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronou s-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/lib64/gfortran/m odules' + export FFLAGS + FCFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switche s -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASS ERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchrono us-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/lib64/gfortran/ modules' + export FCFLAGS + LDFLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/r edhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id= sha1 -Wl,-dT,/builddir/build/BUILD/simpleini-4.19/.package_note-simpleini-4.19-1 .fc38.x86_64.ld' + export LDFLAGS + LT_SYS_LIBRARY_PATH=/usr/lib64: + export LT_SYS_LIBRARY_PATH + CC=gcc + export CC + CXX=g++ + export CXX + cd simpleini-4.19 + install -D -p SimpleIni.h -t /builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x 86_64/usr/include/ + /usr/lib/rpm/check-buildroot + /usr/lib/rpm/redhat/brp-ldconfig + /usr/lib/rpm/brp-compress + /usr/lib/rpm/brp-strip /usr/bin/strip + /usr/lib/rpm/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump + /usr/lib/rpm/redhat/brp-strip-lto /usr/bin/strip + /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip + /usr/lib/rpm/check-rpaths + /usr/lib/rpm/redhat/brp-mangle-shebangs *** WARNING: ./usr/include/SimpleIni.h is executable but has no shebang, removin g executable bit + /usr/lib/rpm/brp-remove-la-files + /usr/lib/rpm/redhat/brp-python-bytecompile '' 1 0 + /usr/lib/rpm/redhat/brp-python-hardlink Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.WQHxP0 + umask 022 + cd /builddir/build/BUILD + CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSE RTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong - specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronou s-unwind-tables -fstack-clash-protection -fcf-protection' + export CFLAGS + CXXFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switch es -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_AS SERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchron ous-unwind-tables -fstack-clash-protection -fcf-protection' + export CXXFLAGS + FFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSE RTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong - specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronou s-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/lib64/gfortran/m odules' + export FFLAGS + FCFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switche s -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASS ERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchrono us-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/lib64/gfortran/ modules' + export FCFLAGS + LDFLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/r edhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id= sha1 -Wl,-dT,/builddir/build/BUILD/simpleini-4.19/.package_note-simpleini-4.19-1 .fc38.x86_64.ld' + export LDFLAGS + LT_SYS_LIBRARY_PATH=/usr/lib64: + export LT_SYS_LIBRARY_PATH + CC=gcc + export CC + CXX=g++ + export CXX + '[' -f /usr/lib/rpm/generate-rpm-note.sh ']' + /usr/lib/rpm/generate-rpm-note.sh simpleini 4.19-1.fc38 x86_64 + cd simpleini-4.19 + make -C tests make: Entering directory '/builddir/build/BUILD/simpleini-4.19/tests' g++ -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs= /usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwi nd-tables -fstack-clash-protection -fcf-protection -Wall -std=c++11 -c -o ts-ro undtrip.o ts-roundtrip.cpp g++ -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs= /usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwi nd-tables -fstack-clash-protection -fcf-protection -Wall -std=c++11 -c -o ts-sn ippets.o ts-snippets.cpp g++ -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs= /usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwi nd-tables -fstack-clash-protection -fcf-protection -Wall -std=c++11 -c -o ts-ut f8.o ts-utf8.cpp g++ -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs= /usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwi nd-tables -fstack-clash-protection -fcf-protection -Wall -std=c++11 -c -o ts-bu gfix.o ts-bugfix.cpp g++ -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs= /usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwi nd-tables -fstack-clash-protection -fcf-protection -Wall -std=c++11 -c -o ts-qu otes.o ts-quotes.cpp g++ -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs= /usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwi nd-tables -fstack-clash-protection -fcf-protection -Wall -std=c++11 -c -o ts-no convert.o ts-noconvert.cpp g++ -o ./tests ts-roundtrip.o ts-snippets.o ts-utf8.o ts-bugfix.o ts-quotes.o ts -noconvert.o -lpthread -lgtest -lgtest_main -lpthread -L/usr/lib -L/usr/lib/x86_ 64-linux-gnu make: Leaving directory '/builddir/build/BUILD/simpleini-4.19/tests' + RPM_EC=0 ++ jobs -p + exit 0 Processing files: simpleini-devel-4.19-1.fc38.noarch Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.j7JkJT + umask 022 + cd /builddir/build/BUILD + cd simpleini-4.19 + DOCDIR=/builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64/usr/share/doc/si mpleini-devel + export LC_ALL=C + LC_ALL=C + export DOCDIR + /usr/bin/mkdir -p /builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64/usr/s hare/doc/simpleini-devel + cp -pr README.md /builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64/usr/sh are/doc/simpleini-devel + RPM_EC=0 ++ jobs -p + exit 0 Executing(%license): /bin/sh -e /var/tmp/rpm-tmp.xuvG7W + umask 022 + cd /builddir/build/BUILD + cd simpleini-4.19 + LICENSEDIR=/builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64/usr/share/li censes/simpleini-devel + export LC_ALL=C + LC_ALL=C + export LICENSEDIR + /usr/bin/mkdir -p /builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64/usr/s hare/licenses/simpleini-devel + cp -pr LICENCE.txt /builddir/build/BUILDROOT/simpleini-4.19-1.fc38.x86_64/usr/ share/licenses/simpleini-devel + RPM_EC=0 ++ jobs -p + exit 0 Provides: simpleini-devel = 4.19-1.fc38 simpleini-static Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDR OOT/simpleini-4.19-1.fc38.x86_64 Wrote: /builddir/build/RPMS/simpleini-devel-4.19-1.fc38.noarch.rpm Child return code was: 0 Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1 Mock Version: 3.1
Doh, fixed. + make -C tests test make: Entering directory '/builddir/build/BUILD/simpleini-4.19/tests' ./tests Running main() from /builddir/build/BUILD/googletest-release-1.12.1/googletest/src/gtest_main.cc [==========] Running 42 tests from 6 test suites. [----------] Global test environment set-up. [----------] 8 tests from TestNoConvert [ RUN ] TestNoConvert.TestSectionAKeyAValA [ OK ] TestNoConvert.TestSectionAKeyAValA (0 ms) [ RUN ] TestNoConvert.TestSectionAKeyAValU [ OK ] TestNoConvert.TestSectionAKeyAValU (0 ms) [ RUN ] TestNoConvert.TestSectionAKeyUValA [ OK ] TestNoConvert.TestSectionAKeyUValA (0 ms) [ RUN ] TestNoConvert.TestSectionAKeyUValU [ OK ] TestNoConvert.TestSectionAKeyUValU (0 ms) [ RUN ] TestNoConvert.TestSectionUKeyAValA [ OK ] TestNoConvert.TestSectionUKeyAValA (0 ms) [ RUN ] TestNoConvert.TestSectionUKeyAValU [ OK ] TestNoConvert.TestSectionUKeyAValU (0 ms) [ RUN ] TestNoConvert.TestSectionUKeyUValA [ OK ] TestNoConvert.TestSectionUKeyUValA (0 ms) [ RUN ] TestNoConvert.TestSectionUKeyUValU [ OK ] TestNoConvert.TestSectionUKeyUValU (0 ms) [----------] 8 tests from TestNoConvert (0 ms total) [----------] 4 tests from TestQuotes [ RUN ] TestQuotes.TestEmpty [ OK ] TestQuotes.TestEmpty (0 ms) [ RUN ] TestQuotes.TestEmptyDisabled [ OK ] TestQuotes.TestEmptyDisabled (0 ms) [ RUN ] TestQuotes.TestGeneral [ OK ] TestQuotes.TestGeneral (0 ms) [ RUN ] TestQuotes.TestGeneralDisabled [ OK ] TestQuotes.TestGeneralDisabled (0 ms) [----------] 4 tests from TestQuotes (0 ms total) [----------] 4 tests from TestBugFix [ RUN ] TestBugFix.TestEmptySection [ OK ] TestBugFix.TestEmptySection (0 ms) [ RUN ] TestBugFix.TestMultiLineIgnoreTrailSpace0 [ OK ] TestBugFix.TestMultiLineIgnoreTrailSpace0 (0 ms) [ RUN ] TestBugFix.TestMultiLineIgnoreTrailSpace1 [ OK ] TestBugFix.TestMultiLineIgnoreTrailSpace1 (0 ms) [ RUN ] TestBugFix.TestMultiLineIgnoreTrailSpace2 [ OK ] TestBugFix.TestMultiLineIgnoreTrailSpace2 (0 ms) [----------] 4 tests from TestBugFix (0 ms total) [----------] 8 tests from TestUTF8 [ RUN ] TestUTF8.TestSectionAKeyAValA [ OK ] TestUTF8.TestSectionAKeyAValA (0 ms) [ RUN ] TestUTF8.TestSectionAKeyAValU [ OK ] TestUTF8.TestSectionAKeyAValU (0 ms) [ RUN ] TestUTF8.TestSectionAKeyUValA [ OK ] TestUTF8.TestSectionAKeyUValA (0 ms) [ RUN ] TestUTF8.TestSectionAKeyUValU [ OK ] TestUTF8.TestSectionAKeyUValU (0 ms) [ RUN ] TestUTF8.TestSectionUKeyAValA [ OK ] TestUTF8.TestSectionUKeyAValA (0 ms) [ RUN ] TestUTF8.TestSectionUKeyAValU [ OK ] TestUTF8.TestSectionUKeyAValU (0 ms) [ RUN ] TestUTF8.TestSectionUKeyUValA [ OK ] TestUTF8.TestSectionUKeyUValA (0 ms) [ RUN ] TestUTF8.TestSectionUKeyUValU [ OK ] TestUTF8.TestSectionUKeyUValU (0 ms) [----------] 8 tests from TestUTF8 (0 ms total) [----------] 9 tests from TestSnippets [ RUN ] TestSnippets.TestSimple [ OK ] TestSnippets.TestSimple (0 ms) [ RUN ] TestSnippets.TestLoadFile [ OK ] TestSnippets.TestLoadFile (0 ms) [ RUN ] TestSnippets.TestLoadString [ OK ] TestSnippets.TestLoadString (0 ms) [ RUN ] TestSnippets.TestSectionsAndKeys [ OK ] TestSnippets.TestSectionsAndKeys (0 ms) [ RUN ] TestSnippets.TestGettingValues [ OK ] TestSnippets.TestGettingValues (0 ms) [ RUN ] TestSnippets.TestExists [ OK ] TestSnippets.TestExists (0 ms) [ RUN ] TestSnippets.TestModifyingData [ OK ] TestSnippets.TestModifyingData (0 ms) [ RUN ] TestSnippets.TestDeletingData [ OK ] TestSnippets.TestDeletingData (0 ms) [ RUN ] TestSnippets.TestSavingData [ OK ] TestSnippets.TestSavingData (0 ms) [----------] 9 tests from TestSnippets (0 ms total) [----------] 9 tests from TestRoundTrip [ RUN ] TestRoundTrip.TestStandard [ OK ] TestRoundTrip.TestStandard (0 ms) [ RUN ] TestRoundTrip.TestMultiGood [ OK ] TestRoundTrip.TestMultiGood (0 ms) [ RUN ] TestRoundTrip.TestMultiBad [ OK ] TestRoundTrip.TestMultiBad (0 ms) [ RUN ] TestRoundTrip.TestSpacesTrue [ OK ] TestRoundTrip.TestSpacesTrue (0 ms) [ RUN ] TestRoundTrip.TestSpacesFalse [ OK ] TestRoundTrip.TestSpacesFalse (0 ms) [ RUN ] TestRoundTrip.TestWithBOM [ OK ] TestRoundTrip.TestWithBOM (0 ms) [ RUN ] TestRoundTrip.TestWithoutBOM [ OK ] TestRoundTrip.TestWithoutBOM (0 ms) [ RUN ] TestRoundTrip.TestAllowKeyOnly1 [ OK ] TestRoundTrip.TestAllowKeyOnly1 (0 ms) [ RUN ] TestRoundTrip.TestAllowKeyOnly2 [ OK ] TestRoundTrip.TestAllowKeyOnly2 (0 ms) [----------] 9 tests from TestRoundTrip (0 ms total) [----------] Global test environment tear-down [==========] 42 tests from 6 test suites ran. (0 ms total) [ PASSED ] 42 tests. Spec URL: https://jonathanspw.fedorapeople.org/simpleini.spec SRPM URL: https://jonathanspw.fedorapeople.org/simpleini-4.19-1.fc38.src.rpm
Looks good. Unicode licenses do have SPDX entries, https://spdx.org/licenses/ but using https://tools.spdx.org/app/check_license/ not for the the text /* * Copyright 2001-2004 Unicode, Inc. * * Disclaimer * * This source code is provided as is by Unicode, Inc. No claims are * made as to fitness for any particular purpose. No warranties of any * kind are expressed or implied. The recipient agrees to determine * applicability of information provided. If this file has been * purchased on magnetic or optical media from Unicode, Inc., the * sole remedy for any claim will be exchange of defective media * within 90 days of receipt. * * Limitations on Rights to Redistribute This Code * * Unicode, Inc. hereby grants the right to freely use the information * supplied in this file in the creation of products supporting the * Unicode Standard, and to make copies of this file in any form * for internal or external distribution as long as this notice * remains attached. */ This would need to go through license review: https://docs.fedoraproject.org/en-US/legal/license-review-process/
The files with the unicode license seem problematic: https://gitlab.com/fedora/legal/fedora-license-data/-/issues/69
As per discussion at https://github.com/AmokHuginnsson/replxx/issues/12 can ConvertUTF.c and ConvertUTF.h be replaced by https://github.com/nemtrif/utfcpp which is packaged https://packages.fedoraproject.org/pkgs/utf8cpp/utf8cpp-devel/
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.