Bug 2120265 - Metrics don't have proper naming
Summary: Metrics don't have proper naming
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Metrics
Version: 4.11.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.11.2
Assignee: João Vilaça
QA Contact: Debarati Basu-Nag
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-22 11:41 UTC by Shirly Radco
Modified: 2023-01-12 14:09 UTC (History)
5 users (show)

Fixed In Version: hco-bundle-registry-v4.11.2-27
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-12 14:08:55 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt kubevirt pull 8401 0 None Merged Rename metrics to follow the naming convention 2022-11-22 13:56:08 UTC
Github kubevirt kubevirt pull 8623 0 None Merged [release-0.53] Rename metrics to follow naming convention 2022-11-22 13:56:07 UTC
Github kubevirt kubevirt pull 8847 0 None Merged [release-0.53] Rename metrics to follow naming convention 2022-11-25 01:40:44 UTC
Github kubevirt ssp-operator pull 412 0 None Merged Rename metrics to follow Prometheus naming conventions 2022-11-22 13:56:07 UTC
Github kubevirt ssp-operator pull 424 0 None Merged [release-v0.15] Rename metrics to follow Prometheus naming conventions 2022-11-22 13:56:06 UTC
Github kubevirt ssp-operator pull 439 0 None Merged [release-v0.16] Rename metrics to follow Prometheus naming conventions 2022-11-22 13:56:06 UTC
Red Hat Issue Tracker CNV-20639 0 None None None 2022-11-09 13:24:31 UTC
Red Hat Product Errata RHEA-2023:0155 0 None None None 2023-01-12 14:09:12 UTC

Description Shirly Radco 2022-08-22 11:41:13 UTC 
Description of problem:
kubevirt_vmi_memory_domain_total_bytes, kubevirt_ssp_total_restored_common_templates, kubevirt_vmi_filesystem_total_bytes don't follow the 
naming conventions as the other metrics.

"total" should be at the end of the metric name
kubevirt_vmi_memory_domain_total_bytes -> kubevirt_vmi_memory_domain_bytes_total
kubevirt_ssp_total_restored_common_templates -> kubevirt_ssp_common_templates_restored_total (also move the action of "restored" after the entity the metric is about) 
kubevirt_vmi_filesystem_total_bytes -> kubevirt_vmi_filesystem_capacity_bytes_total  (also added capacity)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Debarati Basu-Nag 2022-09-29 17:37:14 UTC 
@orevah can you please work with João to verify this bug?
Comment 2 SATHEESARAN 2022-10-18 10:07:51 UTC 
(In reply to Debarati Basu-Nag from comment #1)
> @orevah can you please work with João to verify this bug?

I am taking the ownership of this bug, as I see that the fix is not yet available in 4.11
Comment 3 SATHEESARAN 2022-10-18 10:09:32 UTC 
Tested with CNV-4.11.1-20, and these metrics listed in comment0, still remain the same.
I believe the fix is not yet merged in CNV-4.11.

Moving this bug to ASSIGNED state as the fix is not yet available in 4.11

@Shirly, I request you to confirm the non-availability of the fix in 4.11 and
take necessary action on this bug
Comment 4 SATHEESARAN 2022-10-19 12:51:28 UTC 
(In reply to SATHEESARAN from comment #3)
> Tested with CNV-4.11.1-20, and these metrics listed in comment0, still
> remain the same.
> I believe the fix is not yet merged in CNV-4.11.
> 
> Moving this bug to ASSIGNED state as the fix is not yet available in 4.11
> 
> @Shirly, I request you to confirm the non-availability of the fix in 4.11 and
> take necessary action on this bug

This bug is now re-targeted to 4.11.2, clearing the needinfo as well as the fixed-in-version.
Comment 5 Debarati Basu-Nag 2022-11-23 22:13:08 UTC 
Majority of the changes went in 4.11.1-92.
Verified the followings were renamed correctly:
kubevirt_vmi_memory_domain_total_bytes -> kubevirt_vmi_memory_domain_bytes_total
kubevirt_ssp_total_restored_common_templates -> kubevirt_ssp_common_templates_restored_total 

The following was not changed however:
kubevirt_vmi_filesystem_total_bytes -> kubevirt_vmi_filesystem_capacity_bytes_total 

Failing QE validation.
Comment 7 Debarati Basu-Nag 2023-01-06 19:14:48 UTC 
Verified with 4.11.2-30.
Comment 14 errata-xmlrpc 2023-01-12 14:08:55 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Virtualization 4.11.2 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2023:0155
Note You need to log in before you can comment on or make changes to this bug.