Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/gcp-infra/fedora-rawhide-x86_64/04756154-google-compute-engine/google-compute-engine.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/gcp-infra/fedora-rawhide-x86_64/04756154-google-compute-engine/google-compute-engine-20220211.00-1.fc38.src.rpm Description: Google Compute Engine guest environment configuration Fedora Account System Username: mhayden This configuration only makes sense in the context of a Google Cloud instance.
Jonathan -- You reviewed BZ 2119552 for google-disk-expand, so I figured you might be interested in reviewing this one. If not, that's okay! Thank you.
Sure I can tackle this today :) Up for a trade?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License 2.0", "Unknown or generated", "Apache License 2.0", "GNU General Public License v2.0 or later". 14 files have unknown license. Detailed output of licensecheck in /home/jonathan/fedora-review/2120420-google-compute- engine/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /lib/udev [x]: Package must own all directories that it creates. Note: Directories without known owners: /lib/udev [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/dracut.conf.d/gce.conf %config /etc/modprobe.d/gce-blacklist.conf [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/GoogleCloudPlatform/guest-configs/archive/20220211.00/guest-configs-20220211.00.tar.gz : CHECKSUM(SHA256) this package : eeb95c321a6e73a48e4cb988270b5ce210fb0654951deb153a48ad04dbc74947 CHECKSUM(SHA256) upstream package : eeb95c321a6e73a48e4cb988270b5ce210fb0654951deb153a48ad04dbc74947 Requires -------- google-compute-engine (rpmlib, GLIBC filtered): /usr/bin/bash config(google-compute-engine) curl dracut google-compute-engine-oslogin google-guest-agent nvme-cli Provides -------- google-compute-engine: config(google-compute-engine) google-compute-engine Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2120420 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, Ocaml, PHP, Python, fonts, R, Haskell, SugarActivity, C/C++, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: > %config %{_sysconfdir}/dracut.conf.d/gce.conf > %config %{_sysconfdir}/modprobe.d/gce-blacklist.conf You need to use %config(noreplace) or justify otherwise.
I also just noticed this: > %global _description %{expand: > This package contains scripts, configuration, and init files for features > specific to the Google Compute Engine cloud environment.} > %description %{_description} Since there are no sub-packages what's the point of this versus just setting the description under the %description section without using a var?
This package already exists? https://src.fedoraproject.org/rpms/google-compute-engine-guest-configs
Ah, the names got me confused, Neal. Thanks for pointing that out. No need for this one, then. Thanks for taking a look, Jonathan!