Bug 2120464 - Review Request: golang-howett-plist - A pure Go property list transcoder
Summary: Review Request: golang-howett-plist - A pure Go property list transcoder
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2130734
TreeView+ depends on / blocked
 
Reported: 2022-08-23 02:34 UTC by Anthony Rabbito
Modified: 2023-07-18 14:10 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-10-03 16:39:23 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Anthony Rabbito 2022-08-23 02:34:32 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/anthr76/golang-to-fedora/fedora-rawhide-x86_64/04756438-golang-howett-plist/golang-howett-plist.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/anthr76/golang-to-fedora/fedora-rawhide-x86_64/04756438-golang-howett-plist/golang-howett-plist-1.0.0-1.fc38.src.rpm
Description: Supports encoding/decoding property lists (Apple XML, Apple Binary, OpenStep and GNUStep) from/to arbitrary Go types
Fedora Account System Username: anthr76/@GoSig

Comment 1 Mikel Olasagasti Uranga 2022-09-28 09:19:30 UTC
> %gometa

As suggested on IRC, change to %gometa -f

> # Upstream license specification: BSD-3-Clause
> License:        BSD

Use SPDX tags. 

Based on https://github.com/DHowett/go-plist/blob/main/LICENSE I think BSD-2-Clause AND BSD-3-Clause apply.

> %build
> for cmd in cmd/* ; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done

Is the `ply` command needed? I'm not requesting to remove it, but just want to make sure you want to enable this.

Comment 2 Anthony Rabbito 2022-09-28 16:54:29 UTC
Hi Mikel

> As suggested on IRC, change to %gometa -f

I have done this.

> Use SPDX tags. 

I have updated the licenses to use BSD-2-Clause and BSD-3-Clause with SPDX tags

> Is the `ply` command needed? I'm not requesting to remove it, but just want to make sure you want to enable this.

It doesn't seem necessary to me so I have removed it and added a note to open a RHBZ if someone needs it.



Updated SRPM: https://anthr76.fedorapeople.org/golang-howett-plist/golang-howett-plist-1.0.0-1.fc37.src.rpm
Updated spec: https://anthr76.fedorapeople.org/golang-howett-plist/golang-howett-plist.spec

Comment 3 Mikel Olasagasti Uranga 2022-10-01 21:54:28 UTC
> # Upstream license specification: BSD-3-Clause

You can remove this old comment generated by previous go2rpm releases

> %files
> %license LICENSE
> %doc README.md

You can remove this section, the 3 lines. As no binary is built & installed, %gopkgfiles will take care of the files.

I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 4 Anthony Rabbito 2022-10-02 14:03:36 UTC
Thanks!

Here's the tracking SCM request. https://pagure.io/releng/fedora-scm-requests/issue/47874

Comment 5 Gwyn Ciesla 2022-10-03 15:22:34 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-howett-plist

Comment 6 Fedora Update System 2022-10-03 16:35:22 UTC
FEDORA-2022-b1d6f2c103 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b1d6f2c103

Comment 7 Fedora Update System 2022-10-03 16:39:23 UTC
FEDORA-2022-b1d6f2c103 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2022-10-03 20:35:27 UTC
FEDORA-2022-899b1a9ffb has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-899b1a9ffb

Comment 9 Fedora Update System 2022-10-03 20:35:28 UTC
FEDORA-2022-c4afed4c2f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c4afed4c2f

Comment 10 Fedora Update System 2022-10-04 01:23:23 UTC
FEDORA-2022-c4afed4c2f has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c4afed4c2f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c4afed4c2f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-10-04 01:45:16 UTC
FEDORA-2022-899b1a9ffb has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-899b1a9ffb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-899b1a9ffb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-10-11 11:32:57 UTC
FEDORA-2022-899b1a9ffb has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-11-10 22:09:54 UTC
FEDORA-2022-c4afed4c2f has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-07-18 14:07:54 UTC
FEDORA-2023-565edda98c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-565edda98c

Comment 15 Fedora Update System 2023-07-18 14:10:06 UTC
FEDORA-2023-565edda98c has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.