Bug 2120470 - Crash on "Open With" in pointer_can_grab_surface()
Summary: Crash on "Open With" in pointer_can_grab_surface()
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: mutter
Version: 37
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Florian Müllner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedFreezeException
: 2121658 (view as bug list)
Depends On:
Blocks: F37BetaBlocker F37BetaFreezeException
TreeView+ depends on / blocked
 
Reported: 2022-08-23 03:15 UTC by Ivan Molodetskikh
Modified: 2022-08-26 08:10 UTC (History)
12 users (show)

Fixed In Version: mutter-43~beta-4.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-26 01:09:26 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
bt full (9.08 KB, text/plain)
2022-08-23 03:15 UTC, Ivan Molodetskikh
no flags Details


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME mutter issues 2390 0 None closed Crash in pointer_can_grab_surface 2022-08-24 08:11:42 UTC

Description Ivan Molodetskikh 2022-08-23 03:15:06 UTC
Created attachment 1907033 [details]
bt full

Upstream report: https://gitlab.gnome.org/GNOME/mutter/-/issues/2390

Submitting here because it's potentially blocker-worthy.

Description of problem:

Right click => "Open With" in Nautilus with GTK 4 applications (gnome-text-editor, Identity from Flathub) frequently crashes the session.

Version-Release number of selected component (if applicable):

F37 Silverblue, Wayland, mutter-43~beta-1.fc37.x86_64

How reproducible:

Frequently

Steps to Reproduce:
1. Open Nautilus
2. Right click on some text document
3. Open With
4. Select gnome-text-editor, press Open

Actual results:

The session sometimes crashes.

Expected results:

No crash.

Additional info:

(gdb) bt
#0  0x00007f0e2748140f in meta_get_first_subsurface_node (surface=<optimized out>) at ../src/wayland/meta-wayland-surface.h:397
#1  pointer_can_grab_surface (pointer=0x7f0e040091b0, surface=0x55587c67f450) at ../src/wayland/meta-wayland-pointer.c:1344
#2  0x00007f0e27563ad8 in meta_wayland_pointer_can_grab_surface (serial=624, surface=0x55587c67f450, pointer=<optimized out>) at ../src/wayland/meta-wayland-pointer.c:1359
#3  meta_wayland_seat_get_grab_info (seat=0x55587c294270, surface=0x55587c67f450, serial=624, require_pressed=0, x=0x0, y=0x0) at ../src/wayland/meta-wayland-seat.c:464
#4  0x00007f0e2755796f in token_can_activate (token=<optimized out>) at ../src/wayland/meta-wayland-activation.c:280
#5  activation_activate (client=<optimized out>, resource=<optimized out>, token_str=<optimized out>, surface_resource=<optimized out>) at ../src/wayland/meta-wayland-activation.c:329
#6  0x00007f0e268cf6d6 in ffi_call_unix64 () at ../src/x86/unix64.S:105
#7  0x00007f0e268cc492 in ffi_call_int (cif=<optimized out>, fn=<optimized out>, rvalue=<optimized out>, avalue=<optimized out>, closure=<optimized out>) at ../src/x86/ffi64.c:672
#8  0x00007f0e26e75728 in wl_closure_invoke (closure=closure@entry=0x55587e000300, target=<optimized out>, target@entry=0x55587d1dd5c0, opcode=opcode@entry=2, data=<optimized out>, data@entry=0x55587ee96680,
    flags=2) at ../src/connection.c:1025
#9  0x00007f0e26e79ac8 in wl_client_connection_data (fd=<optimized out>, mask=<optimized out>, data=<optimized out>) at ../src/wayland-server.c:437
#10 0x00007f0e26e78532 in wl_event_loop_dispatch (loop=0x55587c320d80, timeout=timeout@entry=0) at ../src/event-loop.c:1027
#11 0x00007f0e2755373b in wayland_event_source_dispatch (base=<optimized out>, callback=<optimized out>, data=<optimized out>) at ../src/wayland/meta-wayland.c:110
#12 0x00007f0e281b4bff in g_main_dispatch (context=0x55587bcc02f0) at ../glib/gmain.c:3436
#13 g_main_context_dispatch (context=0x55587bcc02f0) at ../glib/gmain.c:4154
#14 0x00007f0e2820a2f8 in g_main_context_iterate.constprop.0 (context=0x55587bcc02f0, block=1, dispatch=1, self=<optimized out>) at ../glib/gmain.c:4230
#15 0x00007f0e281b41cf in g_main_loop_run (loop=0x55587c87b140) at ../glib/gmain.c:4430
#16 0x00007f0e274dfed9 in meta_context_run_main_loop (context=context@entry=0x55587bcba0c0, error=error@entry=0x7ffec9daefc0) at ../src/core/meta-context.c:445
#17 0x000055587b648e09 in main (argc=<optimized out>, argv=<optimized out>) at ../src/main.c:582
(gdb) list
392	meta_get_first_subsurface_node (MetaWaylandSurface *surface)
393	{
394	  GNode *n;
395	
396	  n = g_node_first_child (surface->subsurface_branch_node);
397	  if (!G_NODE_IS_LEAF (n))
398	    return n;
399	  else
400	    return meta_get_next_subsurface_sibling (n);
401	}
(gdb) info locals
n = 0x0
n = <optimized out>

Comment 1 Kalev Lember 2022-08-23 16:58:08 UTC
Proposing as a blocker for Beta as mutter crashes take down the whole session and I've already seen two people mention this one on IRC.

Comment 2 Kalev Lember 2022-08-23 20:35:41 UTC
Upstream fix: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2592

(I'll give it a chance to get reviewed upstream before backporting to Fedora.)

Comment 3 Kamil Páral 2022-08-24 08:11:43 UTC
Upstream fix merged.

Comment 4 Fedora Update System 2022-08-24 08:31:33 UTC
FEDORA-2022-7aff685395 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7aff685395

Comment 5 Fedora Update System 2022-08-24 18:44:47 UTC
FEDORA-2022-7aff685395 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-7aff685395`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7aff685395

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Lukas Ruzicka 2022-08-25 12:08:14 UTC
I am experiencing similar issue with the following workflow:

1. Open Nautilus.
2. Go to root directory.
3. Right-click on the working directory bar.
4. Click "Open with"
5. Select "Disk Usage Analyzer" and click "Open"

The whole session crashes completely and the system ends up at the "GDM" login screen.

Shall I open a new bug for this? I believe this might be connected.

mutter: mutter-43~beta-1.fc38.x86_64

Comment 7 Kalev Lember 2022-08-25 12:39:11 UTC
lruzicka, did mutter-43~beta-4.fc37 solve this for you? Looking at https://bodhi.fedoraproject.org/updates/FEDORA-2022-7aff685395#comment-2693712 it seems so?

Comment 8 Adam Williamson 2022-08-25 23:47:12 UTC
+3 FE in https://pagure.io/fedora-qa/blocker-review/issue/862 , marking accepted.

Comment 9 Fedora Update System 2022-08-26 01:09:26 UTC
FEDORA-2022-7aff685395 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Kalev Lember 2022-08-26 08:10:52 UTC
*** Bug 2121658 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.