Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2120566

Summary: ok_to_renew_cert missing error when upgrading DWH using engine-setup
Product: [oVirt] ovirt-engine-dwh Reporter: Nur Imam Febrianto <nur_imam>
Component: SetupAssignee: Aviv Litman <alitman>
Status: CLOSED NEXTRELEASE QA Contact: Guilherme Santos <gdeolive>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.5.2CC: bugs, dfodor, didi, mperina, sradco
Target Milestone: ovirt-4.5.3Flags: mperina: ovirt-4.5+
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-engine-dwh-4.5.5 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-09-19 14:30:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Metrics RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nur Imam Febrianto 2022-08-23 09:17:17 UTC
Description of problem:

Running engine-setup to upgrade separated DWH server from 4.5.1 to 4.5.2 fail because ok_to_renew_cert error

Version-Release number of selected component (if applicable):
4.5.2

How reproducible:
Happens every time

Steps to Reproduce:
1. Update ovirt-setup from 4.5.1 to 4.5.2 using yum or dnf
2. Run engine-setup

Actual results:
Setup cannot continue with error message : Failed to execute stage 'Environment customization': ok_to_renew_cert() missing 2 required positional arguments: 'short_life' and 'environment'


Expected results:
Setup can continue and successfully upgrading the DWH

Additional info:

Full error message in engine-setup :

[ INFO  ] Stage: Initializing
[ INFO  ] Stage: Environment setup
          Configuration files: /etc/ovirt-engine-setup.conf.d/10-packaging-jboss.conf, /etc/ovirt-engine-setup.conf.d/20-setup-ovirt-post.conf
          Log file: /var/log/ovirt-engine/setup/ovirt-engine-setup-20220823110720-28vs78.log
          Version: otopi-1.10.2 (otopi-1.10.2-1.el8)
[ INFO  ] Stage: Environment packages setup
[ INFO  ] Stage: Programs detection
[ INFO  ] Stage: Environment customization

          --== PRODUCT OPTIONS ==--

[ ERROR ] Failed to execute stage 'Environment customization': ok_to_renew_cert() missing 2 required positional arguments: 'short_life' and 'environment'
[ INFO  ] Stage: Clean up

Comment 1 Yedidyah Bar David 2022-08-23 09:23:02 UTC
Should be fixed by PR 48. I didn't try it myself.

This is a bug on grafana, not dwh. The fix is good if both grafana and dwh are on the same machine. If grafana is on its own machine, separate from both the engine and dwh, it won't be enough.

Comment 2 RHEL Program Management 2022-08-23 09:23:10 UTC
The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Comment 3 Nur Imam Febrianto 2022-08-25 07:23:13 UTC
Already tried the fix on PR48,  and it solves the issue.

Comment 4 Yedidyah Bar David 2022-08-25 07:35:28 UTC
Thanks for the update!

Comment 5 Casper (RHV QE bot) 2022-09-06 12:31:11 UTC
This bug has low overall severity and is not going to be further verified by QE. If you believe special care is required, feel free to properly align relevant severity, flags and keywords to raise PM_Score or use one of the Bumps ('PrioBumpField', 'PrioBumpGSS', 'PrioBumpPM', 'PrioBumpQA') in Keywords to raise it's PM_Score above verification threashold (1000).

Comment 6 Casper (RHV QE bot) 2022-09-19 14:30:46 UTC
This bug has low overall severity and passed an automated regression suite, and is not going to be further verified by QE. If you believe special care is required, feel free to re-open to ON_QA status.