Bug 2120689 - cozy shouldn't install generic icons to avoid conflicts
Summary: cozy shouldn't install generic icons to avoid conflicts
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cozy
Version: 38
Hardware: Unspecified
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Artur Frenszek-Iwicki
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-23 14:36 UTC by Lyes Saadi
Modified: 2023-04-15 02:02 UTC (History)
2 users (show)

Fixed In Version: cozy-1.2.1-2.fc36 cozy-1.2.1-2.fc37 cozy-1.2.1-3.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-06 01:26:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lyes Saadi 2022-08-23 14:36:00 UTC
Hello,

I'm packaging BlackBox, currently only in COPR. But, I noticed there that one of its file conflicted with cozy, which was extremely weird. I then discovered that both BlackBox, and cozy, did the same terrible idea of installing generic icons in the hicolor-icon-theme directory.

Here is the list of icons for cozy:
```
/usr/share/icons/hicolor/scalable/actions/account-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/bed-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/book-alert-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/book-open-variant-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/checkmark-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/clock-outline-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/download-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/downloaded-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/harddisk-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/info-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/message-flash-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/microphone-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/no-bed-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/papyrus-vertical-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/pause-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/play-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/playback-speed-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/settings-symbolic.svg
```

This is clearly very bad and just asking for a potential future conflict. I also guess that this issue should be notified to other packagers that might have the same issue in their packages. Maybe changing the guidelines about that matter?

I didn't patch this for BlackBox yet, but my initial reflexes would be to put all these in a gresource file instead.

Comment 1 Lyes Saadi 2022-08-23 14:44:20 UTC
Just looked at other programs, appending the program's name or uuid to the file seems to also be an acceptable solution.

Comment 2 Artur Frenszek-Iwicki 2022-08-23 20:44:01 UTC
> My initial reflexes would be to put all these in a gresource file instead.
I haven't worked with these before, so I'd need to look up how to do that.

> Appending the program's name or uuid to the file seems to also be an acceptable solution.
I guess that'd require me to patch the program to use these modified names, as well?

Comment 3 Lyes Saadi 2022-08-23 20:52:33 UTC
> I guess that'd require me to patch the program to use these modified names, as well?
Yes.

And, also, now that I think of it, this will create licensing issues as well.

I am considering asking in devel if it would instead be a better idea to create an icon-library-icons, as I'm pretty sure those icons originate from Icon Library: https://apps.gnome.org/fr/app/org.gnome.design.IconLibrary/

Comment 4 Lyes Saadi 2022-08-23 21:24:34 UTC
Hey, so, it seems that even though some of your icon's originate from Icon Library, that is not the case for all of them... :/

Although, good news for Licensing at least, the icons from Icon Library seem to originate from https://gitlab.gnome.org/Teams/Design/icon-development-kit, which is under CC0.

Comment 5 Artur Frenszek-Iwicki 2022-08-24 09:25:46 UTC
It seems this issue has already been brought upstream.
I added a comment referencing the Gnome Icon Library and asking for clarification regarding other icons.
https://github.com/geigi/cozy/issues/710#issuecomment-1225461552

Comment 6 Ben Cotton 2023-02-07 14:54:13 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 7 Fedora Update System 2023-03-28 06:16:07 UTC
FEDORA-2023-87b33587f1 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-87b33587f1

Comment 8 Fedora Update System 2023-03-28 06:30:25 UTC
FEDORA-2023-796c505e68 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-796c505e68

Comment 9 Fedora Update System 2023-03-28 06:37:31 UTC
FEDORA-2023-47c4f6c1ab has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-47c4f6c1ab

Comment 10 Fedora Update System 2023-03-29 02:01:35 UTC
FEDORA-2023-87b33587f1 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-87b33587f1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-03-29 02:38:59 UTC
FEDORA-2023-47c4f6c1ab has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-47c4f6c1ab`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-47c4f6c1ab

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-03-29 03:55:24 UTC
FEDORA-2023-796c505e68 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-796c505e68`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-796c505e68

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-04-06 01:26:22 UTC
FEDORA-2023-47c4f6c1ab has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-04-06 01:53:50 UTC
FEDORA-2023-796c505e68 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2023-04-15 02:02:38 UTC
FEDORA-2023-87b33587f1 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.