Bug 2120770

This bug was initially created as a copy of Bug #2109644

I am copying this bug because: 

Known issue release note for 17.0 ga that UEFI is not working.

Description of problem:  This is an extension of what was already documented for AMD-SEV failure [1]. Booting a guest with an image firmware of UEFI fails with nova.exception.UEFINotSupported. It is the same failure as described in [1] but this happens on non-amd sev deployments with simply UEFI.

(overcloud) [stack@undercloud-0 ~]$ IMGNAME=cirros-0.5.2-x86_64-disk.img
(overcloud) [stack@undercloud-0 ~]$ curl -Ok http://rhos-qe-mirror-tlv.usersys.redhat.com/images/$IMGNAME
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 15.5M  100 15.5M    0     0  7219k      0  0:00:02  0:00:02 --:--:-- 7219k
(overcloud) [stack@undercloud-0 ~]$ openstack image create cirros-uefi --disk-format qcow2 --container-format bare --file $IMGNAME
+------------------+-------------------------------------------------------------------------------------------------------------------------------------------------+
| Field            | Value                                                                                                                                           |
+------------------+-------------------------------------------------------------------------------------------------------------------------------------------------+
| container_format | bare                                                                                                                                            |
| created_at       | 2022-07-21T15:55:40Z                                                                                                                            |
| disk_format      | qcow2                                                                                                                                           |
| file             | /v2/images/276116f5-aa71-4a8f-86cd-14c104231096/file                                                                                            |
| id               | 276116f5-aa71-4a8f-86cd-14c104231096                                                                                                            |
| min_disk         | 0                                                                                                                                               |
| min_ram          | 0                                                                                                                                               |
| name             | cirros-uefi                                                                                                                                     |
| owner            | 4124330826e541e0b5850be5eaedef99                                                                                                                |
| properties       | os_hidden='False', owner_specified.openstack.md5='', owner_specified.openstack.object='images/cirros-uefi', owner_specified.openstack.sha256='' |
| protected        | False                                                                                                                                           |
| schema           | /v2/schemas/image                                                                                                                               |
| status           | queued                                                                                                                                          |
| tags             |                                                                                                                                                 |
| updated_at       | 2022-07-21T15:55:40Z                                                                                                                            |
| visibility       | shared                                                                                                                                          |
+------------------+-------------------------------------------------------------------------------------------------------------------------------------------------+
(overcloud) [stack@undercloud-0 ~]$ openstack image set --property hw_machine_type=q35 cirros-uefi
(overcloud) [stack@undercloud-0 ~]$ openstack image set --property hw_firmware_type=uefi cirros-uefi
(overcloud) [stack@undercloud-0 ~]$ openstack image show cirros-uefi
+------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Field            | Value                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |
+------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| checksum         | b874c39491a2377b8490f5f1e89761a4                                                                                                                                                                                                                                                                                                                                                                                                                                                 |
| container_format | bare                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |
| created_at       | 2022-07-21T15:55:40Z                                                                                                                                                                                                                                                                                                                                                                                                                                                             |
| disk_format      | qcow2                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |
| file             | /v2/images/276116f5-aa71-4a8f-86cd-14c104231096/file                                                                                                                                                                                                                                                                                                                                                                                                                             |
| id               | 276116f5-aa71-4a8f-86cd-14c104231096                                                                                                                                                                                                                                                                                                                                                                                                                                             |
| min_disk         | 0                                                                                                                                                                                                                                                                                                                                                                                                                                                                                |
| min_ram          | 0                                                                                                                                                                                                                                                                                                                                                                                                                                                                                |
| name             | cirros-uefi                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |
| owner            | 4124330826e541e0b5850be5eaedef99                                                                                                                                                                                                                                                                                                                                                                                                                                                 |
| properties       | direct_url='swift+config://ref1/glance/276116f5-aa71-4a8f-86cd-14c104231096', hw_firmware_type='uefi', hw_machine_type='q35', os_hash_algo='sha512', os_hash_value='6b813aa46bb90b4da216a4d19376593fa3f4fc7e617f03a92b7fe11e9a3981cbe8f0959dbebe36225e5f53dc4492341a4863cac4ed1ee0909f3fc78ef9c3e869', os_hidden='False', owner_specified.openstack.md5='', owner_specified.openstack.object='images/cirros-uefi', owner_specified.openstack.sha256='', stores='default_backend' |
| protected        | False                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |
| schema           | /v2/schemas/image                                                                                                                                                                                                                                                                                                                                                                                                                                                                |
| size             | 16300544                                                                                                                                                                                                                                                                                                                                                                                                                                                                         |
| status           | active                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |
| tags             |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                  |
| updated_at       | 2022-07-21T16:03:31Z                                                                                                                                                                                                                                                                                                                                                                                                                                                             |
| virtual_size     | 117440512                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |
| visibility       | shared                                                                                                                                                                                                                                                                                                                                                                                                                                                                           |
+------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
(overcloud) [stack@undercloud-0 ~]$ openstack flavor create --vcpus 2 --ram 512 --disk 1 m1.tiny
+----------------------------+--------------------------------------+
| Field                      | Value                                |
+----------------------------+--------------------------------------+
| OS-FLV-DISABLED:disabled   | False                                |
| OS-FLV-EXT-DATA:ephemeral  | 0                                    |
| description                | None                                 |
| disk                       | 1                                    |
| id                         | 0fa22b23-ba9d-4020-a24b-ce2e0a5a1afa |
| name                       | m1.tiny                              |
| os-flavor-access:is_public | True                                 |
| properties                 |                                      |
| ram                        | 512                                  |
| rxtx_factor                | 1.0                                  |
| swap                       |                                      |
| vcpus                      | 2                                    |
+----------------------------+--------------------------------------+
(overcloud) [stack@undercloud-0 ~]$ openstack server create --flavor m1.tiny --image cirros-uefi test-vm --wait
Error creating server: test-vm
Error creating server
(overcloud) [stack@undercloud-0 ~]$ openstack server event list test-vm
+------------------------------------------+--------------------------------------+--------+----------------------------+
| Request ID                               | Server ID                            | Action | Start Time                 |
+------------------------------------------+--------------------------------------+--------+----------------------------+
| req-865dec1d-3256-4f27-82f1-851329486dde | f7b760db-a572-428c-9ce5-69c580287a7d | create | 2022-07-21T16:03:58.000000 |
+------------------------------------------+--------------------------------------+--------+----------------------------+

(overcloud) [stack@undercloud-0 ~]$ openstack server event show f7b760db-a572-428c-9ce5-69c580287a7d req-865dec1d-3256-4f27-82f1-851329486dde -f json -c events | jq
{
  "events": [
    {
      "event": "compute__do_build_and_run_instance",
      "start_time": "2022-07-21T16:04:03.000000",
      "finish_time": null,
      "result": null,
      "traceback": null,
      "host": "compute-0.redhat.local",
      "hostId": "143c51abe9bc08def726ec26372acc045d269cd64a3ab65b0ad40363",
      "details": null
    },
    {
      "event": "compute__do_build_and_run_instance",
      "start_time": "2022-07-21T16:03:59.000000",
      "finish_time": "2022-07-21T16:04:06.000000",
      "result": "Success",
      "traceback": null,
      "host": "compute-1.redhat.local",
      "hostId": "4347322ca1483135ffac6855cf5bf7204a2f3e470cc9c8aee5ea02f4",
      "details": null
    }
  ]
}
(overcloud) [stack@undercloud-0 ~]$ ssh heat-admin.24.29
Warning: Permanently added '192.168.24.29' (ED25519) to the list of known hosts.
Last login: Thu Jul 21 15:58:57 2022 from 192.168.24.1
[heat-admin@compute-0 ~]$ sudo su
[root@compute-0 heat-admin]# grep req-865dec1d-3256-4f27-82f1-851329486dde /var/log/containers/nova/* | grep ERROR
/var/log/containers/nova/nova-compute.log:2022-07-21 16:04:05.304 2 ERROR nova.compute.manager [req-865dec1d-3256-4f27-82f1-851329486dde e7508b4793464c3c9d3a387c621b16e2 4124330826e541e0b5850be5eaedef99 - default default] [instance: f7b760db-a572-428c-9ce5-69c580287a7d] Instance failed to spawn: nova.exception.UEFINotSupported: UEFI is not supported
/var/log/containers/nova/nova-compute.log:2022-07-21 16:04:05.496 2 ERROR nova.compute.manager [req-865dec1d-3256-4f27-82f1-851329486dde e7508b4793464c3c9d3a387c621b16e2 4124330826e541e0b5850be5eaedef99 - default default] [instance: f7b760db-a572-428c-9ce5-69c580287a7d] Failed to build and run instance: nova.exception.UEFINotSupported: UEFI is not supported
  


Version-Release number of selected component (if applicable):
RHOS-17

How reproducible:
100%

Steps to Reproduce:
1. Deploy a guest with hw_firmware_type=uefi
2.
3.

Actual results:
Guest fails to deploy with UEFINotSupported

Expected results:
Guest deploys

Additional info:
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2090464