Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2121704

Summary: postgresql:11:3820220826064957:75741a8b FTBFS: plperl test fails: ERROR: Useless use of sort in scalar context.
Product: [Fedora] Fedora Modules Reporter: Petr Pisar <ppisar>
Component: postgresqlAssignee: Petr Pisar <ppisar>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: asamalik, fjanus, hhorak, karsten, langdon, mkulik, nphilipp, panovotn, phracek, pkubat, praiskup, rado.pitonak, rbean
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://mbs.fedoraproject.org/module-build-service/2/module-builds/15296
Whiteboard:
Fixed In Version: postgresql:11:3620220829123808:5e5ad4a0 postgresql:10:3620220829124324:5e5ad4a0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-08-29 12:48:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2117176    

Description Petr Pisar 2022-08-26 10:23:56 UTC
postgresql:11:3820220826064957:75741a8b fails to build in Fedora 38 <https://mbs.fedoraproject.org/module-build-service/2/module-builds/15296> because a posgresql test fails <https://koji.fedoraproject.org/koji/taskinfo?taskID=91276203>:

PATH="/builddir/build/BUILD/postgresql-11.16/tmp_install/usr/bin:$PATH" LD_LIBRARY_PATH="/builddir/build/BUILD/postgresql-11.16/tmp_install/usr/lib64"  ../../../src/test/regress/pg_regress --temp-instance=./tmp_check --inputdir=. --bindir=     --dbname=pl_regression --load-extension=plperl  --load-extension=plperlu plperl plperl_lc plperl_trigger plperl_shared plperl_elog plperl_util plperl_init plperlu plperl_array plperl_call plperl_transaction plperl_plperlu
============== creating temporary instance            ==============
============== initializing database system           ==============
============== starting postmaster                    ==============
running on port 60864 with PID 3941354
============== creating database "pl_regression"      ==============
CREATE DATABASE
ALTER DATABASE
============== installing plperl                      ==============
CREATE EXTENSION
============== installing plperlu                     ==============
CREATE EXTENSION
============== running regression test queries        ==============
test plperl                       ... FAILED
test plperl_lc                    ... ok
test plperl_trigger               ... ok
test plperl_shared                ... ok
test plperl_elog                  ... ok
test plperl_util                  ... ok
test plperl_init                  ... ok
test plperlu                      ... ok
test plperl_array                 ... ok
test plperl_call                  ... ok
test plperl_transaction           ... ok
test plperl_plperlu               ... ok
============== shutting down postmaster               ==============
=======================
 1 of 12 tests failed. 
=======================
The differences that caused some tests to fail can be viewed in the
file "/builddir/build/BUILD/postgresql-11.16/src/pl/plperl/regression.diffs".  A copy of the test summary that you see
above is saved in the file "/builddir/build/BUILD/postgresql-11.16/src/pl/plperl/regression.out".
make[1]: Leaving directory '/builddir/build/BUILD/postgresql-11.16/src/pl/plperl'
make[1]: *** [GNUmakefile:114: check] Error 1
make: *** [Makefile:35: check-plperl-recurse] Error 2
[...]
=== trying to find all regression.diffs files in build directory ===
=== make failure: src/pl/plperl/regression.diffs ===
*** /builddir/build/BUILD/postgresql-11.16/src/pl/plperl/expected/plperl.out	Mon May  9 21:20:11 2022
--- /builddir/build/BUILD/postgresql-11.16/src/pl/plperl/results/plperl.out	Fri Aug 26 09:45:53 2022
***************
*** 726,733 ****
  -- check that we can "use warnings" (in this case to turn a warn into an error)
  -- yields "ERROR:  Useless use of sort in scalar context."
  DO $do$ use warnings FATAL => qw(void) ; my @y; my $x = sort @y; 1; $do$ LANGUAGE plperl;
- ERROR:  Useless use of sort in scalar context at line 1.
- CONTEXT:  PL/Perl anonymous code block
  -- make sure functions marked as VOID without an explicit return work
  CREATE OR REPLACE FUNCTION myfuncs() RETURNS void AS $$
     $_SHARED{myquote} = sub {
--- 726,731 ----
======================================================================

Comment 1 Filip Januš 2022-08-26 10:36:51 UTC
Postgresql 10 and 11 are not intended to build in Fedora 37 and later.
Here is the issue setting the EOL https://pagure.io/releng/issue/10945

Comment 2 Petr Pisar 2022-08-26 11:06:53 UTC
Their EOLs are set to 2023-05-16:

$ wget -q -O - 'https://pdc.fedoraproject.org/rest_api/v1/component-branch-slas/?branch_type=module&global_component=postgresql&branch=11'
{"count":1,"next":null,"previous":null,"results":[{"id":788537,"sla":"bug_fixes","branch":{"id":395870,"name":"11","global_component":"postgresql","type":"module","critical_path":false,"active":true},"eol":"2023-05-16"}]}

Today is 2022-08-26.

Looking at the releng ticket, humaton set their EOL to 2023-05-16. If you want to EOL them, you need set the date to something before present. I recommend you reopening the ticket.

Comment 3 Petr Pisar 2022-08-26 11:10:49 UTC
If you want to keep supporting them for Fedora < 37 until 2023-05-16, the PDC EOL is right. But the module YAML file should exclude platforms ≥ 37. I will amend the YAML file.

Comment 4 Petr Pisar 2022-08-26 11:11:09 UTC
Am I right with your intention?

Comment 5 Filip Januš 2022-08-29 06:08:52 UTC
You are completely right.

Comment 6 Petr Pisar 2022-08-29 12:48:47 UTC
I amended the YAML files and built them to be sure they only spawn builds for F35 and F36.