Bug 2121997 - Review Request: rust-temp-env - Set environment variables temporarily
Summary: Review Request: rust-temp-env - Set environment variables temporarily
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-28 08:05 UTC by Alessio
Modified: 2022-11-30 01:35 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-11-21 20:33:02 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Alessio 2022-08-28 08:05:35 UTC
Spec URL: https://alciregi.fedorapeople.org/rustrpm/rust-temp-env.spec
SRPM URL: https://alciregi.fedorapeople.org/rustrpm/rust-temp-env-0.2.0-1.fc37.src.rpm
Description: This crate is for setting environment variables temporarily. It is useful for testing with different environment variables that should not interfere.
Fedora Account System Username: alciregi

Successful koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=91349086

Comment 1 Fabio Valentini 2022-10-13 10:46:00 UTC
Is it explicitly version 0.2.x of this crate that you need? Otherwise, please update to v0.3.0.

FYI, updating to 0.3.1 will not be possible, since that version uses cargo features that aren't supported by Rust packaging tools yet.

Comment 3 Fabio Valentini 2022-11-18 16:24:52 UTC
Thanks for the update! Package looks good to me.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged (0.3.1 is not possible yet)
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Just out of curiosity, what are you packaging this crate for?

Comment 4 Alessio 2022-11-21 11:35:24 UTC
(In reply to Fabio Valentini from comment #3)
> Thanks for the update! Package looks good to me.

Thank you very much.

> 
> Just out of curiosity, what are you packaging this crate for?

I was looking to package this futile program https://github.com/dominikwilkowski/cfonts

Comment 5 Gwyn Ciesla 2022-11-21 16:48:36 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-temp-env

Comment 6 Fedora Update System 2022-11-21 20:30:52 UTC
FEDORA-2022-7f13486089 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7f13486089

Comment 7 Fedora Update System 2022-11-21 20:33:02 UTC
FEDORA-2022-7f13486089 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2022-11-21 21:10:03 UTC
FEDORA-2022-d6b9e41447 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d6b9e41447

Comment 9 Fedora Update System 2022-11-22 02:28:50 UTC
FEDORA-2022-d6b9e41447 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d6b9e41447 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d6b9e41447

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-11-30 01:35:02 UTC
FEDORA-2022-d6b9e41447 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.