Bug 2122528 - flatbuffers compiler 2.0.7 produces C headers with missing include directories
Summary: flatbuffers compiler 2.0.7 produces C headers with missing include directories
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: flatbuffers
Version: rawhide
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Ben Beasley
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-08-30 08:42 UTC by Bruno Pitrus
Modified: 2024-08-12 18:57 UTC (History)
1 user (show)

Fixed In Version: flatbuffers-2.0.8-2.fc38 flatbuffers-2.0.8-2.el9 flatbuffers-2.0.8-2.fc37 flatbuffers-24.3.25-7.el10_0
Clone Of:
Environment:
Last Closed: 2022-08-30 13:15:08 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Bruno Pitrus 2022-08-30 08:42:43 UTC
Hello. I am one of the packagers for the openSUSE package `nodejs-electron`, which we also build for Fedora from the same sources.

After Rawhide updated flatbuffers to 2.0.7, Electron stopped building:

https://build.opensuse.org/package/live_build_log/devel:languages:nodejs/nodejs-electron/Fedora_Rawhide/x86_64

The root cause is flatc now producing a header that says

#include "url_pattern_index_generated.h"

where it previously said

#include "components/[…]/url_pattern_index_generated.h"

Upstream seems to be aware of the issue:

https://github.com/google/flatbuffers/issues/7486

Comment 1 Ben Beasley 2022-08-30 12:28:36 UTC
Thank you for this report!

It looks like version 2.0.8 was released upstream a few hours ago with the necessary fix. I will update to that shortly. In the meantime, I have disabled auto-push-to-stable on the updates for Fedora 37 and EPEL9:

https://bodhi.fedoraproject.org/updates/FEDORA-2022-c209c612ca
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-c4b5c75b18

Comment 2 Fedora Update System 2022-08-30 13:14:02 UTC
FEDORA-2022-5f3acdae74 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5f3acdae74

Comment 3 Fedora Update System 2022-08-30 13:15:08 UTC
FEDORA-2022-5f3acdae74 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Fedora Update System 2022-08-30 13:35:24 UTC
FEDORA-2022-c209c612ca has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c209c612ca

Comment 5 Fedora Update System 2022-08-30 13:56:40 UTC
FEDORA-EPEL-2022-c4b5c75b18 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-c4b5c75b18

Comment 6 Ben Beasley 2022-08-30 13:57:51 UTC
Should be taken care of. The Rawhide package will reach the repositories at the next successful daily compose. Please let me know if there are any issues in 2.0.8. Thanks again for the report!

Comment 7 Fedora Update System 2022-08-31 02:21:24 UTC
FEDORA-2022-c209c612ca has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c209c612ca`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c209c612ca

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Bruno Pitrus 2022-08-31 07:21:31 UTC
I can now confirm that after applying https://github.com/google/flatbuffers/commit/e50696ad9e9622ef7aa9f16d56df5a4ae8aa8d12.patch electron succeeds in building.

I have not tried building it with flatbuffers 2.0.8 yet.

Comment 9 Fedora Update System 2022-08-31 10:09:10 UTC
FEDORA-EPEL-2022-c4b5c75b18 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-c4b5c75b18

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-09-08 11:44:38 UTC
FEDORA-EPEL-2022-c4b5c75b18 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-09-12 17:38:54 UTC
FEDORA-2022-c209c612ca has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2024-08-12 18:55:19 UTC
FEDORA-EPEL-2024-d0643f9aad (flatbuffers-24.3.25-7.el10_0) has been submitted as an update to Fedora EPEL 10.0.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d0643f9aad

Comment 13 Fedora Update System 2024-08-12 18:57:27 UTC
FEDORA-EPEL-2024-d0643f9aad (flatbuffers-24.3.25-7.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.