Description of problem: I have found the following places documenting the options accepted by %pyproject_buildrequires: 1. Packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros 2. pyproject-rpm-macros README: https://src.fedoraproject.org/rpms/pyproject-rpm-macros/blob/b2bb5439dce2639363618f898d238b8d4e2bc8a5/f/README.md?text=True#_64 3. Source of macro implementation: https://src.fedoraproject.org/rpms/pyproject-rpm-macros/blob/b2bb5439dce2639363618f898d238b8d4e2bc8a5/f/pyproject_buildrequires.py#_425 As expected, these are not all identical. In particular, as short as the Packaging Guidelines' variant is, it manages to refer to '-r' option without defining it. README suffers from the same problem, but it is not as obvious since it is much longer. Could at least the Packaging guidelines be improved in this regard? It is quite confusing for people just starting with Python packaging. In my opinion, the packaging guidelines could just refer to the other docs for the options, and only have content like "in situation X, use option -Y". Version-Release number of selected component (if applicable): pyproject-rpm-macros commit b2bb5439dce2639363618f898d238b8d4e2bc8a5 Packaging guidelines commit 7e625c2cd17f14fde2a284268811f754cde2a239
For one, I think that packaging guidelines should not need to mention `-r` at all. The "Implies -r" thing should have been removed when -r was made the default.
(In reply to Miro Hrončok from comment #1) > For one, I think that packaging guidelines should not need to mention `-r` > at all. The "Implies -r" thing should have been removed when -r was made the > default. Proposed change of wording: https://pagure.io/packaging-committee/pull-request/1206
Proposed change for the README: https://src.fedoraproject.org/rpms/pyproject-rpm-macros/pull-request/323
Both proposals look fine to me, thank you for the quick response!
(In reply to Miro Hrončok from comment #2) > (In reply to Miro Hrončok from comment #1) > > For one, I think that packaging guidelines should not need to mention `-r` > > at all. The "Implies -r" thing should have been removed when -r was made the > > default. > > Proposed change of wording: > https://pagure.io/packaging-committee/pull-request/1206 Merged. (In reply to Miro Hrončok from comment #3) > Proposed change for the README: > https://src.fedoraproject.org/rpms/pyproject-rpm-macros/pull-request/323 Merged. I'm now closing this. The updated README will be part of the next update.