Description of problem:

Python 3.9 has renamed the isAlive() method to is_alive(). 

RHEL 9 runs on Python 3.9 but the gofer package we ship via satellite-client-6-for-rhel-9-x86_64-rpms repo, It still contains the isAlive() method. 

# grep -r isAlive /usr/lib/python3.9/site-packages/gofer/
grep: /usr/lib/python3.9/site-packages/gofer/agent/__pycache__/plugin.cpython-39.opt-1.pyc: binary file matches
grep: /usr/lib/python3.9/site-packages/gofer/agent/__pycache__/plugin.cpython-39.pyc: binary file matches
/usr/lib/python3.9/site-packages/gofer/agent/plugin.py:        return self.scheduler.isAlive()


Version-Release number of selected component (if applicable):

Satellite 6.11 and 6.12
RHEL 9
python3-gofer-2.12.5-7.1.el9sat.noarch


How reproducible:

Always

Steps to Reproduce:
1. Install a Sat 6.12 or 6.11

2. Sync satellite-client-6-for-rhel-9-x86_64-rpms in satellite

3. Connect a RHEL 9 client with the satellite.

4. Enable the satellite-client-6-for-rhel-9-x86_64-rpms repo on the RHEL 9 host

5. Install katello-agent on the RHEL 9 host

6. Check the status of goferd on the RHEL 9 host.
 

Actual results:

# systemctl status goferd
× goferd.service - Gofer Agent
     Loaded: loaded (/usr/lib/systemd/system/goferd.service; enabled; vendor preset: disabled)
     Active: failed (Result: exit-code) since Mon 2022-09-05 13:04:11 UTC; 4s ago
    Process: 5093 ExecStart=/usr/bin/env ${PYTHON} /usr/bin/goferd --foreground (code=exited, status=1/FAILURE)
   Main PID: 5093 (code=exited, status=1/FAILURE)
        CPU: 234ms

Sep 05 13:04:10 rhel9.example.com env[5093]:     plugin.start()
Sep 05 13:04:10 rhel9.example.com env[5093]:   File "/usr/lib/python3.9/site-packages/gofer/common.py", line 312, in sfn
Sep 05 13:04:10 rhel9.example.com env[5093]:     return fn(*args, **kwargs)
Sep 05 13:04:10 rhel9.example.com env[5093]:   File "/usr/lib/python3.9/site-packages/gofer/agent/plugin.py", line 317, in start
Sep 05 13:04:10 rhel9.example.com env[5093]:     if self.is_started:
Sep 05 13:04:10 rhel9.example.com env[5093]:   File "/usr/lib/python3.9/site-packages/gofer/agent/plugin.py", line 304, in is_started
Sep 05 13:04:10 rhel9.example.com env[5093]:     return self.scheduler.isAlive()
Sep 05 13:04:10 rhel9.example.com env[5093]: AttributeError: 'Scheduler' object has no attribute 'isAlive'
Sep 05 13:04:11 rhel9.example.com systemd[1]: goferd.service: Main process exited, code=exited, status=1/FAILURE
Sep 05 13:04:11 rhel9.example.com systemd[1]: goferd.service: Failed with result 'exit-code'.


Expected results:


If we are shipping the package and the goferd service, It should be running fine for RHEL 9 as well.


Additional info:




Following fixes the issue on RHEL 9 host.
 
# cd /usr/lib/python3.9/site-packages/gofer/
 
# git init .;git add .;git commit -m 'original state'
 
# vi agent/plugin.py
 
# git diff
diff --git a/agent/plugin.py b/agent/plugin.py
index a3f3c97..ae9d6ba 100644
--- a/agent/plugin.py
+++ b/agent/plugin.py
@@ -301,7 +301,7 @@ class Plugin(object):
 
     @property
     def is_started(self):
-        return self.scheduler.isAlive()
+        return self.scheduler.is_alive()
 
     @property
     def latency(self):

# systemctl restart goferd

# systemctl status goferd -l
● goferd.service - Gofer Agent
     Loaded: loaded (/usr/lib/systemd/system/goferd.service; enabled; vendor preset: disabled)
     Active: active (running) since Mon 2022-09-05 13:08:12 UTC; 5s ago
   Main PID: 16514 (python3)