Spec URL: https://dcavalca.fedorapeople.org/review/duo_unix/duo_unix.spec SRPM URL: https://dcavalca.fedorapeople.org/review/duo_unix/duo_unix-1.12.1-1.fc38.src.rpm Description: Duo provides simple two-factor authentication as a service via: 1. Phone callback 2. SMS-delivered one-time passcode 3. Duo mobile app to generate one-time passcode 4. Duo mobile app for smartphone push authentication 5. Duo hardware token to generate one-time passcode This package allows an admin (or ordinary user) to quickly add Duo authentication to any UNIX login without setting up secondary user accounts, directory synchronization, servers, or hardware. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=91699155
This is an updated version of https://bugzilla.redhat.com/show_bug.cgi?id=1953243
Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/duo_unix/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files => harmless. though maybe just do '%license LICENSE' and delete the file in %{_defaultdocdir}/%{name}/ ? - Package must not depend on deprecated() packages. Note: openssl1.1-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ => oh this can be an issue
- please update to depending on openssl-devel, I just checked locally and it works fine - please add a %check section. `sudo make check` seems to work fine (yes it fails if sudo is not used, sigh) so you might want to disable the tests that involve writing to pam.d - the crypto tests don't require it Exception: Permission denied opening pam.d make sure you run tests with elevated permissions
Spec URL: https://dcavalca.fedorapeople.org/review/duo_unix/duo_unix.spec SRPM URL: https://dcavalca.fedorapeople.org/review/duo_unix/duo_unix-1.12.1-2.fc38.src.rpm Changelog: - Update openssl BR - Fix duplicate license file - Add check section and conditionally run tests
Changes look good. APPROVED
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/duo_unix
FEDORA-2022-04897a2ade has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-04897a2ade
FEDORA-2022-502a017a92 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-502a017a92
FEDORA-2022-4207a7acd1 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4207a7acd1
FEDORA-EPEL-2022-0af92cee1f has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-0af92cee1f
FEDORA-EPEL-2022-4d49b7dddf has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-4d49b7dddf
FEDORA-2022-04897a2ade has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-04897a2ade \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-04897a2ade See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2022-4d49b7dddf has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-4d49b7dddf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-4207a7acd1 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-4207a7acd1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4207a7acd1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2022-0af92cee1f has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-0af92cee1f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-502a017a92 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-502a017a92 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-502a017a92 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2022-0af92cee1f has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2022-4d49b7dddf has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-4207a7acd1 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-502a017a92 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
Removing `pam_duo` from the `duo_unix` package is a divergence from the original Duo package. Since both packages are named `duo_unix` and EPEL packages have a higher priority than third-party repositories, this `duo_unix` will override one from Duo causing unexpected behavior and possibly a system lockout if a user is protecting logins with `pam_duo`. Suggested solutions are: Include `pam_duo` as a part of this package. Rename this package to `login_duo` to avoid conflicting with the upstream package repository
Thanks for the report Mark, I've moved that to https://bugzilla.redhat.com/show_bug.cgi?id=2134160 for ease of tracking.
FEDORA-2022-0c3d3eca33 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.