SRPM URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza-1.04-1.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza.spec Description: This module implements the classic Eliza algorithm. The original Eliza program was written by Joseph Weizenbaum and described in the Communications of the ACM in 1966. Eliza is a mock Rogerian psychotherapist. It prompts for user input, and uses a simple transformation algorithm to change user input into a follow-up question. The program is designed to give the appearance of understanding.
* rpmlint is silent * free software, licence not included * spec legible * simple perl module, no BuildRequires needed * match upstream 754199bbe591eaa11301aee108586fcd Chatbot-Eliza-1.04.tar.gz * sane provides Provides: perl(Chatbot::Eliza) = 1.04 Needswork: The language specific files in %doc should be tagged with the appropriate %lang. Comment: Not a blocker, but I think that there could be a summary explaining better what it the module does.
(In reply to comment #1) > Needswork: > > The language specific files in %doc should be tagged with the > appropriate %lang. Is this a blocker, given that they're sample files in %doc and named "deutsch" and "norsk"? Given that there's a couple sample files for those two languages, I suppose I could put them under, %doc/DE and %doc/NO? Would that suffice?
No need to do that, I just ask for the following, instead of a plain %doc: %doc doctor.txt simple* README debug.cgi twobots %lang(de) %doc deutsch* %lang(??) %doc norsk*
(In reply to comment #3) > No need to do that, I just ask for the following, instead of > a plain %doc: > > %doc doctor.txt simple* README debug.cgi twobots > %lang(de) %doc deutsch* > %lang(??) %doc norsk* Done: SRPM URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza-1.04-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Chatbot-Eliza.spec Out of curiosity, what does tagging these files in this fashion do? Looking at the resulting rpm I'm not seeing any difference.
(In reply to comment #4) > Out of curiosity, what does tagging these files in this fashion do? Looking at > the resulting rpm I'm not seeing any difference. I don't know what it should do, and I believe it does nothing yet. In the summary, I think the s of elisa should be a z. APPROVED
(In reply to comment #5) > In the summary, I think the s of elisa should be a z. Fixed, thanks. > APPROVED Imported & building for devel, branches requested for FC-5, FC-6. Thanks for the review!