Bug 2125569 - Correct property name in GsRemovalDialog .ui file
Summary: Correct property name in GsRemovalDialog .ui file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-software
Version: rawhide
Hardware: x86_64
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: Milan Crha
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: https://ask.fedoraproject.org/t/upgra...
Depends On:
Blocks: F37FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2022-09-09 10:21 UTC by Michael Catanzaro
Modified: 2022-09-29 02:20 UTC (History)
6 users (show)

Fixed In Version: gnome-software-42.4-2.fc36 gnome-software-41.5-2.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-29 02:20:25 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME gnome-software issues 1898 0 None opened Distro upgrade is broken 2022-09-09 10:21:34 UTC

Description Michael Catanzaro 2022-09-09 10:21:34 UTC
Distro upgrade from F36 to F37 via GNOME Software is broken, see https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1898. When clicking the Restart & Upgrade button, an empty dialog is shown and it's not possible to proceed.

Comment 1 Fedora Blocker Bugs Application 2022-09-09 10:25:01 UTC
Proposed as a Blocker for 37-final by Fedora user catanzaro using the blocker tracking app because:

 This fails the Upgrade Requirements criterion https://fedoraproject.org/wiki/Fedora_37_Beta_Release_Criteria#Upgrade_requirements and also the default application functionality criterion https://fedoraproject.org/wiki/Fedora_37_Final_Release_Criteria#Default_application_functionality

Note that this should be a pre-release blocker: to release F37, we need to first fix this in F36. (It doesn't actually need to be fixed in F37 until it's time to release F38.)

Comment 2 Kamil Páral 2022-09-09 11:43:33 UTC
Anyone reading this, see the upstream ticket for a relevant discussion.

Comment 3 Milan Crha 2022-09-12 06:55:24 UTC
I just added an upstream fix, also referenced from the above upstream bug. I'll create an update for Fedora 36 and 35 shortly.

Comment 4 Fedora Update System 2022-09-12 07:15:28 UTC
FEDORA-2022-630657685a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-630657685a

Comment 5 Fedora Update System 2022-09-12 07:15:29 UTC
FEDORA-2022-15b2d61378 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-15b2d61378

Comment 6 Kamil Páral 2022-09-12 10:28:02 UTC
Michael, I don't seem to be able to reproduce this, can you please verify the fix?

Comment 7 Michael Catanzaro 2022-09-12 13:36:33 UTC
Er... well the functionality is fixed, but the dialog is clearly not styled properly: looks awful. I'd say the blocker issue is fixed, but I would call this a QA fail.

Comment 8 Fedora Update System 2022-09-13 02:29:52 UTC
FEDORA-2022-630657685a has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-630657685a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-630657685a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-09-13 02:37:35 UTC
FEDORA-2022-15b2d61378 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-15b2d61378`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-15b2d61378

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Geoffrey Marr 2022-09-13 05:00:08 UTC
Discussed during the 2022-09-12 blocker review meeting: [0]

The decision to classify this bug as an AcceptedPreviousRelease bug was made as a violation of Beta criterion "For each one of the release-blocking package sets, it must be possible to successfully complete a direct upgrade from a fully updated, clean default installation of each of the last two stable Fedora releases with that package set installed". The updates for F35 and F36 need to go stable to consider this addressed.

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2022-09-12/f37-blocker-review.2022-09-12-16.01.txt

Comment 11 Milan Crha 2022-09-13 07:04:23 UTC
(In reply to Michael Catanzaro from comment #7)
> but the dialog is clearly not styled properly: looks awful.

Out of interest, what do you see, please? I saw a dialog with a short description and then with a list of the affected packages. Nothing awful, as the list  looks similar to the Install page, except without icons and summary of the app - these are just bare packages. In any case, if you need to see any change, file an upstream bug, please. Suggestions welcome, or set "Needs Design" tag on it.

Comment 12 Milan Crha 2022-09-13 07:23:25 UTC
(In reply to Milan Crha from comment #11)
> What do you see, please?

Never mind, I see you wrote that upstream:
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1898#note_1550478

Comment 13 Fedora Update System 2022-09-22 01:16:38 UTC
FEDORA-2022-630657685a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Kamil Páral 2022-09-22 08:12:58 UTC
Waiting for the F35 update to hit stable updates as well...

Comment 15 Fedora Update System 2022-09-29 02:20:25 UTC
FEDORA-2022-15b2d61378 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.