Bug 2127286 - Removing old heqders for lv2 package make nearly all lv2 plugins fail to compile
Summary: Removing old heqders for lv2 package make nearly all lv2 plugins fail to compile
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: lv2
Version: 37
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Guido Aulisi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-09-15 20:25 UTC by ycollet
Modified: 2022-09-22 01:45 UTC (History)
6 users (show)

Fixed In Version: lv2-1.18.8-2.fc37
Clone Of:
Environment:
Last Closed: 2022-09-22 01:45:41 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description ycollet 2022-09-15 20:25:55 UTC
J tried to build some external plugins (ones which are not in Fedora) and removing all old headers make nearly all this plugins fqil to compile. Fro, the lv2.spec

%meson \
  -D docs=enabled \
  -D old_headers=false \
  -D tests=disabled

  -D old_headers=false should be set to True

Comment 1 Orcan Ogetbil 2022-09-16 02:34:15 UTC
Below is the error when building muse:

/builddir/build/BUILD/muse-4.0/libs/plugin/plugin_cache_writer.cpp:76:10: fatal error: lv2/lv2plug.in/ns/ext/data-access/data-access.h: No such file or directory
   76 | #include "lv2/lv2plug.in/ns/ext/data-access/data-access.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

https://koji.fedoraproject.org/koji/taskinfo?taskID=92006595

Enabling the "old headers" fixes the problem.

Comment 2 ycollet 2022-09-16 08:53:33 UTC
If you don't want to reenable this compilation flag, at least, build it with this flag and move the older flags into a separate package.
With this package we will have the time to patch things on our side

Comment 3 Guido Aulisi 2022-09-16 09:23:41 UTC
I will reenable old headers ASAP

Comment 4 ycollet 2022-09-16 09:29:43 UTC
Excellent ! Thanks a lot !!

Comment 5 Simone Caronni 2022-09-16 11:27:57 UTC
The (In reply to Orcan Ogetbil from comment #1)
> Below is the error when building muse:
> 
> /builddir/build/BUILD/muse-4.0/libs/plugin/plugin_cache_writer.cpp:76:10:
> fatal error: lv2/lv2plug.in/ns/ext/data-access/data-access.h: No such file
> or directory
>    76 | #include "lv2/lv2plug.in/ns/ext/data-access/data-access.h"

These header paths have been switched behind an optional flag in February 2019 with release 1.16.0.

Comment 6 Fedora Update System 2022-09-17 07:43:17 UTC
FEDORA-2022-c12121e9f4 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c12121e9f4

Comment 7 Fedora Update System 2022-09-18 01:26:31 UTC
FEDORA-2022-c12121e9f4 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c12121e9f4`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c12121e9f4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Mamoru TASAKA 2022-09-19 01:27:30 UTC
Just FYI: this issue was hit when rebuilding some packages on libFLAC soname bump:

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/J3DJ4FD7LFB6G5AFY3YA4SOESQIZMCF4/

Comment 9 Fedora Update System 2022-09-22 01:45:41 UTC
FEDORA-2022-c12121e9f4 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.