Bug 2127529 - drop non-upstream CMAKE_DL_LIBS windows patch
Summary: drop non-upstream CMAKE_DL_LIBS windows patch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cmake
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Björn Esser (besser82)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-09-16 18:03 UTC by Ken Dreyer (Red Hat)
Modified: 2022-10-31 14:34 UTC (History)
5 users (show)

Fixed In Version: cmake-3.25.0-0.2.rc2.fc38
Clone Of:
Environment:
Last Closed: 2022-10-30 13:36:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Fedora Package Sources cmake pull-request 23 0 None None None 2022-09-16 20:41:36 UTC

Description Ken Dreyer (Red Hat) 2022-09-16 18:03:40 UTC
Description of problem:
cmake adds "-ldl" to Windows builds, diverging from upstream

https://src.fedoraproject.org/rpms/cmake/c/ad0e43afe6e48a9189135429c183fbf00bf547ba

Version-Release number of selected component (if applicable):
cmake-3.24.1-1.fc38

How reproducible:
always

Steps to Reproduce:
1. Cross-compile the Ceph Windows client in two environments: Ubuntu and RHEL
2. Note the build flags
3. Note the build results

Actual results:
On Ubuntu, the Ceph Windows client cross-compiles successfully. There is no reference to "-ldl" in the build logs.

Expected results:
On RHEL and Fedora, the Ceph Windows client fails to cross-compile because the compiler fails when searching for "-ldl" ("No such file or directory").

Additional info:
In https://src.fedoraproject.org/rpms/cmake/c/ad0e43afe6e48a9189135429c183fbf00bf547ba, Sandro patched the CMAKE_DL_LIBS variable. On Ubuntu (and cmake upstream), CMAKE_DL_LIBS is blank, but on Fedora, it's now "dl".

The upstream CMake maintainers rejected this patch, so it's a good idea to remove this patch from Fedora as well.

Comment 1 Ken Dreyer (Red Hat) 2022-09-16 20:41:37 UTC
https://src.fedoraproject.org/rpms/cmake/pull-request/23 drops the patch to CMAKE_DL_LIBS, returning to upstream's behavior.

Comment 2 Fedora Update System 2022-10-30 13:11:20 UTC
FEDORA-2022-3e0028ce85 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3e0028ce85

Comment 3 Fedora Update System 2022-10-30 13:36:58 UTC
FEDORA-2022-3e0028ce85 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Ken Dreyer (Red Hat) 2022-10-31 14:34:05 UTC
Thanks. For the record the exact dist-git change is https://src.fedoraproject.org/rpms/cmake/c/59c57b9caae3ceca514772cd3145c25ec8532093


Note You need to log in before you can comment on or make changes to this bug.