Bug 2128545
| Summary: | os-net-config should configure ethtool_opts for SRIOV-VF | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Keigo Noha <knoha> |
| Component: | os-net-config | Assignee: | Karthik Sundaravel <ksundara> |
| Status: | CLOSED ERRATA | QA Contact: | Eran Kuris <ekuris> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 16.1 (Train) | CC: | bfournie, cfontain, gurpsing, hakhande, hbrock, jslagle, ksundara, mburns, mnietoji, vcandapp |
| Target Milestone: | zstream | Keywords: | RFE, Triaged |
| Target Release: | 16.2 (Train on RHEL 8.4) | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | os-net-config-11.5.1-2.20230728005156.8a89b94.el8ost | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-11-08 19:18:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2222869 | ||
|
Description
Keigo Noha
2022-09-21 00:37:12 UTC
Yes Gurpreet, the patch is available in upstream and downstream. Using this config:
{
"name": "nic12",
"numvfs": 10,
"promisc": false,
"type": "sriov_pf",
"use_dhcp": false,
"ethtool_opts": "autoneg on"
},
{
"type": "sriov_vf",
"device": "nic12",
"vfid": 5,
"addresses": [
{
"ip_netmask": "192.0.55.1/24"
}
],
"vlan_id": 100,
"spoofcheck": true,
"macaddr": "00:78:91:81:cc:30",
"trust": true,
"state": "auto",
"promisc": false,
"ethtool_opts": "autoneg on"
}
Executing:
os-net-config -d -c /etc/os-net-config/config.json
I can see that the following commands are executed:
[2023/10/17 10:10:32 AM] [DEBUG] Running cmd (subprocess): /sbin/ethtool -s enp4s0f1 autoneg on
[2023/10/17 10:10:32 AM] [DEBUG] CMD "/sbin/ethtool -s enp4s0f1 autoneg on" returned: 0 in 0.008s
[2023/10/17 10:10:33 AM] [DEBUG] Running cmd (subprocess): /sbin/ethtool -s enp4s0f1v5 autoneg on
[2023/10/17 10:10:33 AM] [DEBUG] CMD "/sbin/ethtool -s enp4s0f1v5 autoneg on" returned: 0 in 0.004s
I change the config to the following one:
{
"name": "nic12",
"numvfs": 10,
"promisc": false,
"type": "sriov_pf",
"use_dhcp": false,
"ethtool_opts": "autoneg off speed 1000 duplex full"
},
{
"type": "sriov_vf",
"device": "nic12",
"vfid": 5,
"addresses": [
{
"ip_netmask": "192.0.55.1/24"
}
],
"vlan_id": 100,
"spoofcheck": true,
"macaddr": "00:78:91:81:cc:30",
"trust": true,
"state": "auto",
"promisc": false,
"ethtool_opts": "autoneg off speed 1000 duplex full"
}
I get the following logs:
os-net-config -d -c /etc/os-net-config/config.json
[2023/10/17 10:18:20 AM] [INFO] Running ethtool -s enp4s0f1 autoneg off speed 1000 duplex full
[2023/10/17 10:18:20 AM] [DEBUG] Running cmd (subprocess): /sbin/ethtool -s enp4s0f1 autoneg off speed 1000 duplex full
[2023/10/17 10:10:33 AM] [INFO] Running ethtool -s enp4s0f1v5 autoneg on
[2023/10/17 10:10:33 AM] [DEBUG] Running cmd (subprocess): /sbin/ethtool -s enp4s0f1v5 autoneg on
We can see that ethtool_opts is configured in the nic by os-net-config
I pasted wrong lines in the os-net-config output, the second time i run os-net-config, i get: [2023/10/17 10:10:33 AM] [DEBUG] Running cmd (subprocess): /sbin/ethtool -s enp4s0f1v5 autoneg on [2023/10/17 10:10:33 AM] [DEBUG] CMD "/sbin/ethtool -s enp4s0f1v5 autoneg on" returned: 0 in 0.004s [2023/10/17 10:18:20 AM] [DEBUG] Running cmd (subprocess): /sbin/ethtool -s enp4s0f1v5 autoneg off speed 1000 duplex full [2023/10/17 10:18:20 AM] [DEBUG] CMD "/sbin/ethtool -s enp4s0f1v5 autoneg off speed 1000 duplex full" returned: 0 in 0.004s Verified with the following versions os-net-config-11.5.1-2.20230728005156.8a89b94.el8ost.noarch RHOS-16.2-RHEL-8-20231005.n.3 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Red Hat OpenStack Platform 16.2.6 (Train) bug fix and enhancement advisory), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2023:6307 |