Description of problem: After last update rsync fail if change parameter order Version-Release number of selected component (if applicable): [lesca@dodo ~]$ rpm -q rsync-daemon rsync rsync-daemon-3.2.6-1.fc36.noarch rsync-3.2.6-1.fc36.x86_64 How reproducible: If I run follow command rsync fail: [lesca@dodo ~]$ sudo /usr/bin/rsync -a --relative rsync://localhost/root/u/rsnapshot/ rsync://localhost/root/u/master/addon/ /tmp/r --dry-run; echo $? # WORK ERR ERROR: rejecting unrequested file-list name: /u/master rsync error: protocol incompatibility (code 2) at flist.c(998) [Receiver=3.2.6] 2 If I change the parameters order rsync work as expected: [lesca@dodo ~]$ sudo /usr/bin/rsync -a --relative rsync://localhost/root/u/master/addon/ rsync://localhost/root/u/rsnapshot/ /tmp/r --dry-run; echo $? # WORK OK 0 When fail, if I use --old-args option command work as expected Is this a new features depend of parameters order or is a bug? Thanks Dario
Hi Dario, thanks for the bug, this is definitely not a feature but rather a consequence of fixing CVE-2022-29154. Some of the changes in filter logic are causing this. I am going to try some latest upstream commits to help with this.
That would be these two? https://www.mail-archive.com/rsync@lists.samba.org/msg33576.html
Hi Dario, can you please test that this build resolves the issue? https://koji.fedoraproject.org/koji/taskinfo?taskID=92345586
(In reply to Michal Ruprich from comment #3) > Hi Dario, > > can you please test that this build resolves the issue? > > https://koji.fedoraproject.org/koji/taskinfo?taskID=92345586 Yes it work [1] Work also with a real command used for backup on another server with problem. Thanks to all. Dario [1] [lesca@dodo ~]$ sudo /usr/bin/rsync -a --relative rsync://localhost/root/u/rsnapshot/ rsync://localhost/root/u/master/addon/ /run/media/lesca/dario-1T-crit-01/rsnapshot/.sync/dodo/ --dry-run; echo $? # WORK ERR ERROR: rejecting unrequested file-list name: /u/master rsync error: protocol incompatibility (code 2) at flist.c(998) [Receiver=3.2.6] 2 [lesca@dodo ~]$ sudo yum update /altro/tmp/rsync- rsync-3.2.6-2.fc36.x86_64.rpm rsync-daemon-3.2.6-2.fc36.noarch.rpm [lesca@dodo ~]$ sudo yum update /altro/tmp/rsync-* Ultima verifica della scadenza dei metadati: 1:04:08 fa il mar 27 set 2022, 09:56:35. Dipendenze risolte. ============================================================================================================================================ Package Architecture Version Repository Size ============================================================================================================================================ Upgrading: rsync x86_64 3.2.6-2.fc36 @commandline 408 k rsync-daemon noarch 3.2.6-2.fc36 @commandline 11 k Riepilogo della transazione ============================================================================================================================================ Aggiornati 2 pacchetti Dimensione totale: 419 k Procedere [s/N]: s Scaricamento dei pacchetti: Esecuzione del controllo di transazione Controllo di transazione eseguito con successo. Test di transazione in corso Test di transazione eseguito con successo Transazione in corso Preparazione in corso : 1/1 Upgrading : rsync-3.2.6-2.fc36.x86_64 1/4 Upgrading : rsync-daemon-3.2.6-2.fc36.noarch 2/4 Esecuzione scriptlet in corso: rsync-daemon-3.2.6-2.fc36.noarch 2/4 Esecuzione scriptlet in corso: rsync-daemon-3.2.6-1.fc36.noarch 3/4 Pulizia : rsync-daemon-3.2.6-1.fc36.noarch 3/4 Esecuzione scriptlet in corso: rsync-daemon-3.2.6-1.fc36.noarch 3/4 Pulizia : rsync-3.2.6-1.fc36.x86_64 4/4 Esecuzione scriptlet in corso: rsync-3.2.6-1.fc36.x86_64 4/4 Verifica in corso : rsync-3.2.6-2.fc36.x86_64 1/4 Verifica in corso : rsync-3.2.6-1.fc36.x86_64 2/4 Verifica in corso : rsync-daemon-3.2.6-2.fc36.noarch 3/4 Verifica in corso : rsync-daemon-3.2.6-1.fc36.noarch 4/4 Aggiornati: rsync-3.2.6-2.fc36.x86_64 rsync-daemon-3.2.6-2.fc36.noarch Fatto! [lesca@dodo ~]$ sudo systemctl restart rsyncd.service [lesca@dodo ~]$ sudo /usr/bin/rsync -a --relative rsync://localhost/root/u/rsnapshot/ rsync://localhost/root/u/master/addon/ /run/media/lesca/dario-1T-crit-01/rsnapshot/.sync/dodo/ --dry-run; echo $? # WORK ERR 0
FEDORA-2022-2d8d4e23a9 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2d8d4e23a9
FEDORA-2022-53d671cb30 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-53d671cb30
FEDORA-2022-67117e2da9 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-67117e2da9
Thanks Dario, builds are in testing, should be out in a couple of days. Regards, Michal
FEDORA-2022-2d8d4e23a9 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-2d8d4e23a9` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-2d8d4e23a9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-53d671cb30 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-53d671cb30` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-53d671cb30 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-67117e2da9 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-67117e2da9` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-67117e2da9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-53d671cb30 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
I ran into a similar-looking failure in Fedora 36. The pending update (https://bodhi.fedoraproject.org/updates/FEDORA-2022-2d8d4e23a9) fixes the problem for me, but it looks like it is blocked from being pushed to stable because the "fedora-ci.koji-build./plans/ci.functional" automated test failed. When I try to view the failure log, I get an error 404, so I don't know what the problem is. It would be great if someone could get the Fedora 36 update straightened out before too many more users waste time troubleshooting the same issue. Thanks!
Hi Matt, thanks for pointing that out, I didn't notice that the test failed. Or rather seems like the infra failed and re-triggering the test helped. The update should now be moved to stable. As to the problem with 404 - this is because the logs are removed after a period of time. Not sure about the exact time but I think after a week. This update was pushed two weeks ago so the logs are gone. New logs should be visible now after I re-triggered them. Regards, Michal
Thanks Michal. Unfortunately, it looks like two other required tests failed this time. It doesn't seem plausible that the failures are actually related to the rsync patches. Just try yet again? (This is frustrating!)
FEDORA-2022-2d8d4e23a9 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-26ca7529e6 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.