Bug 2129191 - Review Request: iir1 - DSP IIR Realtime C++ filter library
Summary: Review Request: iir1 - DSP IIR Realtime C++ filter library
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Till Hofmann
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 2128116
TreeView+ depends on / blocked
Reported: 2022-09-22 20:38 UTC by Otto Liljalaakso
Modified: 2022-10-05 20:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2022-10-05 20:41:43 UTC
Type: ---
thofmann: fedora-review+

Attachments (Terms of Use)

Description Otto Liljalaakso 2022-09-22 20:38:42 UTC
Spec URL: https://oturpe.kapsi.fi/fedora/rpms/iir1/1/iir1.spec
SRPM URL: https://oturpe.kapsi.fi/fedora/rpms/iir1/1/iir1-1.9.3-2.fc38.src.rpm

An infinite impulse response (IIR) filter library for Linux, Mac OSX and Windows
which implements Butterworth, RBJ, Chebychev filters and can easily import
coefficients generated by Python (scipy).

The filter processes the data sample by sample for realtime processing.

It uses templates to allocate the required memory so that it can run without any
malloc / new commands. Memory is allocated at compile time so that there is
never the risk of memory leaks.

All realtime filter code is in the header files which guarantees efficient
integration into the main program and the compiler can optimise both filter code
and main program at the same time.

Fedora Account System Username: oturpe

I am packaging iir1, because dosbox-staging-0.79.0 has a dependency on it.

Comment 1 Till Hofmann 2022-10-03 13:31:14 UTC

===== MUST items =====

[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License". 38 files have unknown
     license. Detailed output of licensecheck in
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
[!]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.

Cannot parse rpmlint output:

Rpmlint (debuginfo)
Cannot parse rpmlint output:

Rpmlint (installed packages)
============================ rpmlint session starts ============================
rpmlint: 2.2.0
checks: 32, packages: 5

iir1-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libiir.so.1.9.3-1.9.3-2.fc38.x86_64.debug
iir1-debugsource.x86_64: W: no-documentation
iir1.x86_64: W: no-documentation
iir1-devel.x86_64: W: no-documentation
iir1-debuginfo.x86_64: W: no-documentation
iir1-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib64/libiir.so.1.9.3-1.9.3-2.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib64/libiir.so.1.9.3-1.9.3-2.fc38.x86_64.debug'

iir1-devel-doc.noarch: W: files-duplicate /usr/share/doc/iir1-devel-doc/docs/search/classes_1.js /usr/share/doc/iir1-devel-doc/docs/search/all_1.js
iir1-devel-doc.noarch: W: files-duplicate /usr/share/doc/iir1-devel-doc/docs/search/classes_2.js /usr/share/doc/iir1-devel-doc/docs/search/all_2.js
iir1-devel-doc.noarch: W: files-duplicate /usr/share/doc/iir1-devel-doc/docs/search/functions_1.js /usr/share/doc/iir1-devel-doc/docs/search/all_4.js
iir1-devel-doc.noarch: W: files-duplicate /usr/share/doc/iir1-devel-doc/docs/search/functions_2.js /usr/share/doc/iir1-devel-doc/docs/search/all_5.js
iir1-devel-doc.noarch: W: files-duplicate /usr/share/doc/iir1-devel-doc/docs/search/classes_4.js /usr/share/doc/iir1-devel-doc/docs/search/all_6.js
iir1-devel-doc.noarch: W: files-duplicate /usr/share/doc/iir1-devel-doc/docs/search/enums_0.js /usr/share/doc/iir1-devel-doc/docs/search/all_8.js
iir1-devel-doc.noarch: W: files-duplicate /usr/share/doc/iir1-devel-doc/docs/search/classes_6.js /usr/share/doc/iir1-devel-doc/docs/search/all_9.js
iir1-devel-doc.noarch: W: files-duplicate /usr/share/doc/iir1-devel-doc/docs/search/classes_8.js /usr/share/doc/iir1-devel-doc/docs/search/all_b.js
iir1-devel-doc.noarch: W: files-duplicate /usr/share/doc/iir1-devel-doc/docs/search/classes_b.js /usr/share/doc/iir1-devel-doc/docs/search/all_e.js
iir1-devel-doc.noarch: E: devel-dependency iir1-devel
iir1-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/a1/879f494550acafd9b8faf19230d3e8a752e897 ../../../.build-id/a1/879f494550acafd9b8faf19230d3e8a752e897
 5 packages and 0 specfiles checked; 2 errors, 15 warnings, 2 badness; has taken 0.5 s 

Source checksums
https://github.com/berndporr/iir1/archive/1.9.3/iir1-1.9.3.tar.gz :
  CHECKSUM(SHA256) this package     : de241ef7a3e5ae8e1309846fe820a2e18978aa3df3922bd83c2d75a0fcf4e78f
  CHECKSUM(SHA256) upstream package : de241ef7a3e5ae8e1309846fe820a2e18978aa3df3922bd83c2d75a0fcf4e78f

iir1 (rpmlib, GLIBC filtered):

iir1-devel (rpmlib, GLIBC filtered):

iir1-devel-doc (rpmlib, GLIBC filtered):

iir1-debuginfo (rpmlib, GLIBC filtered):

iir1-debugsource (rpmlib, GLIBC filtered):






Diff spec file in url and in SRPM
--- /home/till/fedora/reviews/review-iir1/srpm/iir1.spec	2022-10-03 14:58:47.782306623 +0200
+++ /home/till/fedora/reviews/review-iir1/srpm-unpacked/iir1.spec	2022-09-22 22:33:50.000000000 +0200
@@ -1,2 +1,11 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.3.0)
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+    release_number = 2;
+    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+    print(release_number + base_release_number - 1);
+## END: Set by rpmautospec
 Name:           iir1
 Version:        1.9.3
@@ -91,3 +100,7 @@
+* Thu Sep 22 2022 Otto Liljalaakso <otto.liljalaakso> 1.9.3-2
+- Uncommitted changes
+* Thu Sep 22 2022 Otto Liljalaakso <otto.liljalaakso> 1.9.3-1
+- Initial commit

Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -u https://bugzilla.redhat.com/show_bug.cgi?id=2129191
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Perl, Java, Haskell, Ocaml, R, Python, SugarActivity, fonts, PHP

Comment 2 Gwyn Ciesla 2022-10-05 20:17:10 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/iir1

Comment 3 Fedora Update System 2022-10-05 20:39:26 UTC
FEDORA-2022-f89deaaab3 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f89deaaab3

Comment 4 Fedora Update System 2022-10-05 20:41:43 UTC
FEDORA-2022-f89deaaab3 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.