Bug 2130053 - Review Request: typescript - A language for application scale JavaScript development
Summary: Review Request: typescript - A language for application scale JavaScript deve...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-09-27 02:24 UTC by Carl George 🤠
Modified: 2022-10-10 17:40 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-10-10 17:40:48 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Carl George 🤠 2022-09-27 02:24:59 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/04874398-typescript/typescript.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/04874398-typescript/typescript-4.8.3-1.fc38.src.rpm

Description:
TypeScript is a language for application-scale JavaScript. TypeScript adds
optional types to JavaScript that support tools for large-scale JavaScript
applications for any browser, for any host, on any OS. TypeScript compiles to
readable, standards-based JavaScript.

Fedora Account System Username: carlwgeorge

This is a re-review in order to rename nodejs-typescript to typescript.  I would like to do this rename to comply with the current Node.js packaging guidelines [0].  A re-review is required per the Package Renaming Process [1].

[0] https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_naming_guidelines
[1] https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/

Comment 1 Carl George 🤠 2022-09-27 21:37:58 UTC
Based on feedback from one of the nodejs maintainers, since this package is noarch I've switched the build requirements from nodejs-devel to nodejs-packaging.  I also added an explicit build requirement on nodejs for the %check section (nodejs-packaging doesn't currently require it).

Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/04876150-typescript/typescript.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/04876150-typescript/typescript-4.8.3-1.fc38.src.rpm

Comment 2 Neal Gompa 2022-10-09 20:49:19 UTC
This package doesn't look significantly different from the current one.

Packaging notes:

* Package follows packaging guidelines
* Package is named appropriately (now)
* Package builds and installs
* Package licensing is correctly handled
* Package presents no serious rpmlint issues

PACKAGE APPROVED.

Comment 3 Gwyn Ciesla 2022-10-10 13:38:29 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/typescript

Comment 4 Fedora Update System 2022-10-10 17:38:34 UTC
FEDORA-2022-0398edd8b7 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0398edd8b7

Comment 5 Fedora Update System 2022-10-10 17:40:48 UTC
FEDORA-2022-0398edd8b7 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.