Bug 2131090 - Patch3 reverts a patch merged upstream
Summary: Patch3 reverts a patch merged upstream
Keywords:
Status: VERIFIED
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: iscsi-initiator-utils
Version: 8.5
Hardware: All
OS: Linux
urgent
urgent
Target Milestone: rc
: ---
Assignee: Chris Leech
QA Contact: Martin Hoyer
URL:
Whiteboard:
Depends On:
Blocks: 2215111
TreeView+ depends on / blocked
 
Reported: 2022-09-29 20:34 UTC by Paulo Andrade
Modified: 2023-06-26 10:52 UTC (History)
7 users (show)

Fixed In Version: iscsi-initiator-utils-6.2.1.4-8.git095f59c.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2215111 (view as bug list)
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
bz2131090.patch (941 bytes, patch)
2022-10-07 18:33 UTC, Paulo Andrade
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-135381 0 None None None 2022-09-29 20:42:08 UTC

Description Paulo Andrade 2022-09-29 20:34:08 UTC
Without patches open-iscsi-095f59c.tar.gz already has the fix for
https://github.com/open-iscsi/open-iscsi/pull/244

  But 0003-idbm_rec_write-seperate-old-and-new-style-writes.patch
reverts the upstream fix.

  Basically, the chunks:

-@@ -2148,39 +2143,8 @@ static int idbm_rec_write(node_rec_t *rec, bool disable_lock)
+@@ -2170,39 +2165,8 @@ static int idbm_rec_write(node_rec_t *rec, bool disable_lock)
                return ISCSI_ERR_NOMEM;
        }
  
 -      snprintf(portal, PATH_MAX, "%s", NODE_CONFIG_DIR);
 -      if (access(portal, F_OK) != 0) {
--              if (mkdir(portal, 0660) != 0) {
+-              if (mkdir(portal, 0770) != 0) {
 -                      log_error("Could not make %s: %s", portal,
 -                                strerror(errno));
 -                      rc = ISCSI_ERR_IDBM;
@@ -42,7 +42,7 @@ index e6ede85..bc51388 100644
 -
 -      snprintf(portal, PATH_MAX, "%s/%s", NODE_CONFIG_DIR, rec->name);
 -      if (access(portal, F_OK) != 0) {
--              if (mkdir(portal, 0660) != 0) {
+-              if (mkdir(portal, 0770) != 0) {
 -                      log_error("Could not make %s: %s", portal,
 -                                strerror(errno));
 -                      rc = ISCSI_ERR_IDBM;

should have been a mistake, when updating to latest upstream release, related
to bz#1921626.

Comment 1 Paulo Andrade 2022-10-07 18:33:11 UTC
Created attachment 1916748 [details]
bz2131090.patch

User is running a modified package, with this patch, and confirms that
it corrects the problem.


Note You need to log in before you can comment on or make changes to this bug.