Hi @bkunal , In 4.11 we copied the the rook-ceph toolbox enable & tolerations etc logic to the storagecluster cr see here-https://github.com/red-hat-storage/ocs-operator/pull/1602. But as it's not possible to remove fields from public API so we had to keep those fields still in ocsinitialization cr. I think we should have added a deprecation warning or probably could have made an implementation such that it considers edits to the ocsinitialization cr too while reconciling the toolbox pod. something like that, But I think we missed that. So instead of the way mentioned here https://bugzilla.redhat.com/show_bug.cgi?id=2012084#c11, Can you do like this oc edit storagecluster -n openshift-storage <storage-cluster-name> In this look for Spec.ManagedResources.CephToolbox field, ``` spec: arbiter: {} encryption: kms: {} externalStorage: {} managedResources: cephBlockPools: {} cephCluster: {} cephConfig: {} cephDashboard: {} cephFilesystems: {} cephNonResilientPools: {} cephObjectStoreUsers: {} cephObjectStores: {} cephToolbox: {} ``` I this you have to add the tolerations to the cephToolbox field like below cephToolbox: tolerations: <non-ocs-tolerations>
Ack, Agreed there is too much variation. Will keep it in mind. If possible in 4.13 I will try to align the toleration of all the resources to a similar structure.
It can be in 4.12, But I think it will require a good amount of effort, so it's difficult to commit to 4.12. I will keep this in mind for 4.12 for now though.
Hi Bipin, Working on it. PR will be up today
PR is up, I have made it such that the old way of adding tolerations via the ocsinitialization still works & the new way of adding via the storagecluster is now structured Spec->Placement->Tolerations.
In 4.11 when we moved the toolbox logic from ocsinitilization to storagecluster, it was a design decision. The toolbox should have been associated with the storagecluster itself from the beginning as it's unique to each cephcluster. So we are trying to move all the enable/disable, and reconcile logic to the storagecluster now but still keeping backward compatibility. The plan is in the future somewhere the compatibility with ocsinitialization would be removed & storagecluster would be the only place for anything related to the ceph toolbox.