Bug 2131496 - Review Request: golang-github-sahilm-fuzzy - Go library that provides fuzzy string matching
Summary: Review Request: golang-github-sahilm-fuzzy - Go library that provides fuzzy s...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Anthony Rabbito
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2131497
TreeView+ depends on / blocked
 
Reported: 2022-10-01 20:36 UTC by Mikel Olasagasti Uranga
Modified: 2022-10-31 14:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-10-31 14:34:24 UTC
Type: ---
Embargoed:
hello: fedora-review+


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2022-10-01 20:36:07 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-sahilm-fuzzy.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-sahilm-fuzzy-0.1.0-1.fc36.src.rpm
Description: symbols in the style of Sublime Text, VSCode, IntelliJ IDEA et al.
Fedora Account System Username: mikelo2

Comment 1 Anthony Rabbito 2022-10-17 12:59:33 UTC
Hi Mikel

I've noticed:

> BuildRequires:  golang(github.com/kylelemons/godebug/pretty)

and 

> %generate_buildrequires
> %go_generate_buildrequires

Is godebug/pretty an added dependency on top of the generated deps?

Comment 2 Mikel Olasagasti Uranga 2022-10-27 21:05:10 UTC
%go_generate_buildrequires is not pulling " golang(github.com/kylelemons/godebug/pretty)" dep, so I added manually and left %go_generate_buildrequires as it doesn't break, but I removed it now.

Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-sahilm-fuzzy.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-sahilm-fuzzy-0.1.0-1.fc36.src.rpm

Comment 3 Anthony Rabbito 2022-10-29 02:00:37 UTC
go2rpm package:

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 4 Gwyn Ciesla 2022-10-31 13:43:11 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-sahilm-fuzzy

Comment 5 Fedora Update System 2022-10-31 14:31:24 UTC
FEDORA-2022-bda99b2f6d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bda99b2f6d

Comment 6 Fedora Update System 2022-10-31 14:34:24 UTC
FEDORA-2022-bda99b2f6d has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.