Bug 2131499 - Review Request: golang-github-erikgeiser-promptkit - Go prompt library
Summary: Review Request: golang-github-erikgeiser-promptkit - Go prompt library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: W. Michael Petullo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2131402 2131497
Blocks: 2128574
TreeView+ depends on / blocked
 
Reported: 2022-10-01 21:00 UTC by Mikel Olasagasti Uranga
Modified: 2023-01-12 14:53 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-01-12 14:53:52 UTC
Type: ---
Embargoed:
mike: fedora-review+


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2022-10-01 21:00:35 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-erikgeiser-promptkit.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-erikgeiser-promptkit-0.7.0-1.fc36.src.rpm
Description: Go prompt library.
Fedora Account System Username: mikelo2

Comment 2 W. Michael Petullo 2023-01-11 22:00:43 UTC
I found that the mock build failed, as run by "fedora-review -b 2131499". Building with "rpmbuild --rebuild ..." on Fedora 37 similarly failed.

+ go-rpm-integration check -i github.com/erikgeiser/promptkit -b /builddir/build/BUILD/promptkit-1f33bc73d091f90faf118ee5ab5d85cb6474ca7c/_build/bin -s /builddir/build/BUILD/promptkit-1f33bc73d091f90faf118ee5ab5d85cb6474ca7c/_build -V 0.7.0-1.20221001git1f33bc7.fc38 -C 1f33bc73d091f90faf118ee5ab5d85cb6474ca7c -p /builddir/build/BUILDROOT/golang-github-erikgeiser-promptkit-0.7.0-1.20221001git1f33bc7.fc38.x86_64 -g /usr/share/gocode -r '.*example.*'
Testing    in: /builddir/build/BUILD/promptkit-1f33bc73d091f90faf118ee5ab5d85cb6474ca7c/_build/src
         PATH: /builddir/build/BUILD/promptkit-1f33bc73d091f90faf118ee5ab5d85cb6474ca7c/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/promptkit-1f33bc73d091f90faf118ee5ab5d85cb6474ca7c/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags " -X github.com/erikgeiser/promptkit/version=0.7.0 -X github.com/erikgeiser/promptkit/version.commit=1f33bc73d091f90faf118ee5ab5d85cb6474ca7c -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes '"
      testing: github.com/erikgeiser/promptkit
github.com/erikgeiser/promptkit
PASS
ok  	github.com/erikgeiser/promptkit	0.001s
github.com/erikgeiser/promptkit/confirmation
--- FAIL: TestDefaultYes (0.00s)
    model_test.go:29: view mismatch in default_yes.golden:
        Expected:
            ready? Yes
        
        Got:
            ready? Yes
--- FAIL: TestDefaultNilIsUndecided (0.00s)
    model_test.go:93: view mismatch in default_nil.golden:
        Expected:
            ready?  Yes  No
        Got:
            ready?  Yes  No
--- FAIL: TestImmediatelyChooseNo (0.00s)
    model_test.go:137: view mismatch in choose_no.golden:
        Expected:
            ready? No
        
        Got:
            ready? No
--- FAIL: TestToggle (0.00s)
    model_test.go:155: view mismatch in toggle_before.golden:
        Expected:
            ready?  Yes  No
        Got:
            ready?  Yes  No
    model_test.go:163: view mismatch in toggle_once.golden:
        Expected:
            ready? �Yes  No
        Got:
            ready? �Yes  No
    model_test.go:171: view mismatch in toggle_twice.golden:
        Expected:
            ready?  Yes �No
        Got:
            ready?  Yes �No
    model_test.go:180: view mismatch in toggle_confirmed.golden:
        Expected:
            ready? Yes
        
        Got:
            ready? Yes
--- FAIL: TestTemplateYN (0.00s)
    model_test.go:271: view mismatch in templateyn_undecided.golden:
        Expected:
            yes or no? [y/n]
        Got:
            yes or no? [y/n]
    model_test.go:276: view mismatch in templateyn_no.golden:
        Expected:
            yes or no? [y/N]
        Got:
            yes or no? [y/N]
    model_test.go:281: view mismatch in templateyn_yes.golden:
        Expected:
            yes or no? [Y/n]
        Got:
            yes or no? [Y/n]
    model_test.go:290: view mismatch in templateyn_result.golden:
        Expected:
            yes or no? [Y/n]
        
        Got:
            yes or no? [Y/n]
--- FAIL: TestDefaultUndecided (0.00s)
    model_test.go:70: view mismatch in default_undecided.golden:
        Expected:
            ready?  Yes  No
        Got:
            ready?  Yes  No
--- FAIL: TestDefaultNo (0.00s)
    model_test.go:47: view mismatch in default_no.golden:
        Expected:
            ready? No
        
        Got:
            ready? No
--- FAIL: TestImmediatelyChooseYes (0.00s)
    model_test.go:115: view mismatch in choose_yes.golden:
        Expected:
            ready? Yes
        
        Got:
            ready? Yes
--- FAIL: TestSubmit (0.00s)
    model_test.go:256: view mismatch in submit.golden:
        Expected:
            ready? Yes
        
        Got:
            ready? Yes
--- FAIL: TestSelectNo (0.00s)
    model_test.go:216: view mismatch in select_no.golden:
        Expected:
            ready?  Yes �No
        Got:
            ready?  Yes �No
    model_test.go:218: view mismatch in select_no_confirmed.golden:
        Expected:
            ready? No
        
        Got:
            ready? No
--- FAIL: TestSelectYes (0.00s)
    model_test.go:197: view mismatch in select_yes.golden:
        Expected:
            ready? �Yes  No
        Got:
            ready? �Yes  No
    model_test.go:199: view mismatch in select_yes_confirmed.golden:
        Expected:
            ready? Yes
        
        Got:
            ready? Yes
FAIL
exit status 1
FAIL	github.com/erikgeiser/promptkit/confirmation	0.005s
error: Bad exit status from /var/tmp/rpm-tmp.snR5zg (%check)
    Bad exit status from /var/tmp/rpm-tmp.snR5zg (%check)
RPM build errors:
Child return code was: 1
EXCEPTION: [Error('Command failed: \n # /usr/bin/systemd-nspawn -q -M 3445907e19af467db4a77a1d2527a461 -D /var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild --capability=cap_ipc_lock --bind=/tmp/mock-resolv.6nv75dot:/etc/resolv.conf --bind=/dev/btrfs-control --bind=/dev/mapper/control --bind=/dev/loop-control --bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 --bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 --bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\\033]0;<mock-chroot>\\007" --setenv=PS1=<mock-chroot> \\s-\\v\\$  --setenv=LANG=C.UTF-8 --resolv-conf=off bash --login -c /usr/bin/rpmbuild -ba --noprep --noclean --target x86_64 --nodeps /builddir/build/SPECS/golang-github-erikgeiser-promptkit.spec\n', 1)]
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/mockbuild/trace_decorator.py", line 93, in trace
    result = func(*args, **kw)
             ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/mockbuild/util.py", line 598, in do_with_status
    raise exception.Error("Command failed: \n # %s\n%s" % (command, output), child.returncode)
mockbuild.exception.Error: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 3445907e19af467db4a77a1d2527a461 -D /var/lib/mock/fedora-rawhide-x86_64/root -a -u mockbuild --capability=cap_ipc_lock --bind=/tmp/mock-resolv.6nv75dot:/etc/resolv.conf --bind=/dev/btrfs-control --bind=/dev/mapper/control --bind=/dev/loop-control --bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2 --bind=/dev/loop3 --bind=/dev/loop4 --bind=/dev/loop5 --bind=/dev/loop6 --bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 --bind=/dev/loop10 --bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$  --setenv=LANG=C.UTF-8 --resolv-conf=off bash --login -c /usr/bin/rpmbuild -ba --noprep --noclean --target x86_64 --nodeps /builddir/build/SPECS/golang-github-erikgeiser-promptkit.spec

Comment 3 Mikel Olasagasti Uranga 2023-01-12 09:09:35 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-erikgeiser-promptkit.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-erikgeiser-promptkit-0.7.0-1.20221001git1f33bc7.fc37.src.rpm

Updated the spect to skip tests.

Reported issue upstream https://github.com/erikgeiser/promptkit/issues/15

The style output with termenv 0.13.0  changed a little bit and doesn't match the static test data the project has, but functionality works correctly.

Comment 5 W. Michael Petullo 2023-01-12 14:26:38 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 6 Fedora Admin user for bugzilla script actions 2023-01-12 14:38:01 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-erikgeiser-promptkit

Comment 7 Fedora Update System 2023-01-12 14:53:20 UTC
FEDORA-2023-bfcb01b3c7 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bfcb01b3c7

Comment 8 Fedora Update System 2023-01-12 14:53:52 UTC
FEDORA-2023-bfcb01b3c7 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.