Spec URL: https://thofmann.fedorapeople.org/nagios-plugins-check_ssl_cert.spec SRPM URL: https://thofmann.fedorapeople.org/nagios-plugins-check_ssl_cert-2.49.0-1.fc36.src.rpm Description: A POSIX shell script (that can be used as a Nagios/Icinga plugin) to check an SSL/TLS connection and certificate COPR build: https://copr.fedorainfracloud.org/coprs/thofmann/nagios-plugins/build/4883344/ Fedora Account System Username: thofmann
Spec URL: https://thofmann.fedorapeople.org/nagios-plugins-check_ssl_cert.spec SRPM URL: https://thofmann.fedorapeople.org/nagios-plugins-check_ssl_cert-2.49.0-2.fc38.src.rpm Switched to SPDX license identifier.
> Name: nagios-plugins-check_ssl_cert As discussed in bug 2082886, following the usual Nagios plugin naming, this should be nagion-plugins-ssl_cert. (This comment is not review blocking.) > Version: 2.49.0 This is not the latest version. v2.25.0 is out already. The latest version should be packaged. However, upstream releases so often (three releases yesterday!), that I am not going to block the review because of this. > URL: https://exchange.nagios.org/directory/Plugins/Network-Protocols/HTTP/check_ssl_cert This link is not correct. It shows a corrupted version of the /directory/ path. Appending /details/ shows the intended page. However, that page has not been updated since 2020-08, and e.g. claims that the latest version is 1.122.0. I am not sure if it better to use this or the GitHub repo — your call. > [!]: %check is present and all tests pass. Upstream provides folder test/ with some tests, either execute it or provide a comment explaining why not. > [!]: Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see > attached diff). > See: (this test has no URL) This is just because 'fedpkg srpm', fedora-review and rpmautospec are not compatible. No action needed, just do not try to 'fedpkg import' that srpm. > nagios-plugins-check_ssl_cert.x86_64: W: only-non-binary-in-usr-lib $ rpmlint -e only-non-binary-in-usr-lib only-non-binary-in-usr-lib: There are only non binary files in /usr/lib so they should be in /usr/share. Nagios plugins directory in under /usr/lib64, putting a shell script there is valid. No action needed.
Spec URL: https://thofmann.fedorapeople.org/nagios-plugins-ssl_cert.spec SRPM URL: https://thofmann.fedorapeople.org/nagios-plugins-ssl_cert-2.54.0-1.fc38.src.rpm Sorry for the long silence, I got busy with other things. I did the following changes: * Rename package to nagios-plugins-ssl_cert * Change summary according to common pattern used for nagios plugins * Fix URL (I kept the exchange.nagios.org URL, as it contains some useful information and also directly points to GitHub) * Mention why we do not run unittests (it requires internet access) * Do not wildcard-install script * Update to 2.54.0
Looks good now, package approved! Thank you for your contribution.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nagios-plugins-ssl_cert
FEDORA-2022-b18e208414 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b18e208414
FEDORA-2022-7a07517e8a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7a07517e8a
FEDORA-2022-b18e208414 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-b18e208414 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b18e208414 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-7a07517e8a has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-7a07517e8a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7a07517e8a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-b18e208414 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-7a07517e8a has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.